openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-10 20:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Heap-allocate the resume future in the legacy history test (#43966)

Browse Source 
Use `Box::pin` in
`cached_legacy_resume_revalidates_history_across_migration_settings` to
keep the large resume future off the Windows test thread's stack.

GitOrigin-RevId: 2539b7733e9f92e65a27bbea8f75170ce01b1884
This commit is contained in:
dermanyang-oai
2026-09-09 01:18:05 +00:00
committed by copyberry
parent 8c72f2ff56
commit dafb6781ee
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
codex-rs/tui/src/app_server_session/rollout_history_tests.rs
View File

@@ -319,13 +319,13 @@ async fn cached_legacy_resume_revalidates_history_across_migration_settings() ->
let local_settings = crate::local_settings::LocalSettings::from(&resume_config);
let next_request_id = app_server.next_request_id;
let legacy = {
let resume = app_server.resume_thread(
// Keep the large resume future off the Windows test thread's stack.
let mut resume = Box::pin(app_server.resume_thread(
&local_settings,
resume_config.clone(),
legacy_thread_id,
ResumeModelSettings::RestoreFromThread,
);
tokio::pin!(resume);
));
drop(maintenance_guard);
// This current-thread test polls resume before yielding to the startup worker.
// Resume must acquire its guard before waiting for metadata revalidation.