From dafb6781ee76b06ed41bdbe004484087925e22a6 Mon Sep 17 00:00:00 2001 From: dermanyang-oai Date: Wed, 9 Sep 2026 01:18:05 +0000 Subject: [PATCH] Heap-allocate the resume future in the legacy history test (#43966) Use `Box::pin` in `cached_legacy_resume_revalidates_history_across_migration_settings` to keep the large resume future off the Windows test thread's stack. GitOrigin-RevId: 2539b7733e9f92e65a27bbea8f75170ce01b1884 --- .../tui/src/app_server_session/rollout_history_tests.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/codex-rs/tui/src/app_server_session/rollout_history_tests.rs b/codex-rs/tui/src/app_server_session/rollout_history_tests.rs index e3b5333412..0250b747c7 100644 --- a/codex-rs/tui/src/app_server_session/rollout_history_tests.rs +++ b/codex-rs/tui/src/app_server_session/rollout_history_tests.rs @@ -319,13 +319,13 @@ async fn cached_legacy_resume_revalidates_history_across_migration_settings() -> let local_settings = crate::local_settings::LocalSettings::from(&resume_config); let next_request_id = app_server.next_request_id; let legacy = { - let resume = app_server.resume_thread( + // Keep the large resume future off the Windows test thread's stack. + let mut resume = Box::pin(app_server.resume_thread( &local_settings, resume_config.clone(), legacy_thread_id, ResumeModelSettings::RestoreFromThread, - ); - tokio::pin!(resume); + )); drop(maintenance_guard); // This current-thread test polls resume before yielding to the startup worker. // Resume must acquire its guard before waiting for metadata revalidation.