mirror of
https://github.com/openai/codex.git
synced 2026-10-30 19:18:49 +00:00
Sean Huang
ab190cdfdf
## Why Source-built V8 archives and generated Rust bindings must agree on their ABI, including in debug builds. Linux platform selection must also distinguish GNU and musl when using LLVM platforms. ## What changed - Always select source-built V8 archives and matching bindings for Bazel consumers, removing the `rusty_v8_from_source` flag. - Use LLVM's libc-aware Linux selectors for archives, bindings, headers, and bindgen targets. - Keep `V8_ENABLE_CHECKS` undefined in debug builds to match Rust's `HandleScope` layout, and set `V8_LOGGING_LEVEL=2` for debug verification. - Include compiler-rt builtins in the ARM64 GNU/Linux archive to provide `__clear_cache`. - Set the Intel macOS minimum version for `codex-code-mode-host` releases to 10.13 for V8's aligned allocation support. ## Testing Always include the existing ignored CppGC ABI checks in Bazel `v8-poc` unit tests and remove their exclusion from Bazel CI. GitOrigin-RevId: f698a47502154cdfb80febed02e4465d9f2d1e0c
14 lines
365 B
Python
14 lines
365 B
Python
load("//:defs.bzl", "codex_rust_crate")
|
|
load("//bazel/rules:runtime_package.bzl", "release_binary")
|
|
|
|
codex_rust_crate(
|
|
name = "code-mode-host",
|
|
crate_name = "codex_code_mode_host",
|
|
)
|
|
|
|
release_binary(
|
|
binary = ":codex-code-mode-host",
|
|
# V8 and its libc++ use aligned new and delete, available on macOS 10.13.
|
|
macos_x86_64_minimum_os = "10.13",
|
|
)
|