Commit Graph
38 Commits
Author SHA1 Message Date
Ahmed IbrahimandCodex af5bfe8b8d Record validation pass 4
Co-authored-by: Codex <noreply@openai.com>
2026-03-17 06:17:15 +00:00
Ahmed IbrahimandCodex 7814705a19 Record validation pass 3
Co-authored-by: Codex <noreply@openai.com>
2026-03-17 05:51:39 +00:00
Ahmed IbrahimandCodex e1e205c2df Record validation pass 2
Co-authored-by: Codex <noreply@openai.com>
2026-03-17 05:25:53 +00:00
Ahmed IbrahimandCodex ad5be933da Record validation pass 1
Co-authored-by: Codex <noreply@openai.com>
2026-03-17 04:59:33 +00:00
Ahmed IbrahimandCodex d8450f8e2a Fix code mode yield startup race
Co-authored-by: Codex <noreply@openai.com>
2026-03-17 04:12:38 +00:00
Ahmed IbrahimandCodex 65f7f64ae5 Record validation pass 1
Co-authored-by: Codex <noreply@openai.com>
2026-03-17 03:54:03 +00:00
Ahmed IbrahimandCodex 4a3181290d Suppress PowerShell CLIXML in apply_patch test
Keep the Windows cmd.exe harness for apply_patch_cli_can_use_shell_command_output_as_patch_input, but make the nested PowerShell read deterministic by silencing progress output, switching to ReadAllText, and running non-interactively.

Co-authored-by: Codex <noreply@openai.com>
2026-03-17 03:26:25 +00:00
Ahmed IbrahimandCodex 6a302cb2e3 Fix cmd-wrapped PowerShell test quoting
Keep the Windows cmd.exe harness for apply_patch_cli, but encode the nested PowerShell read so cmd does not pass the script through as a quoted string literal. This preserves the test coverage while making the file-read path deterministic again.

Update the flaky-test ledger with the c14493260 CI failure and the new quoting diagnosis.

Co-authored-by: Codex <noreply@openai.com>
2026-03-17 02:55:21 +00:00
Ahmed IbrahimandCodex c144932603 Fix Windows PowerShell parser stdin
Restore the parser subprocess stdin behavior that Command::output() provided so safe PowerShell wrapper commands do not time out on Windows, and add the argument-name comments required by the stale lint failure.

Co-authored-by: Codex <noreply@openai.com>
2026-03-17 00:47:00 +00:00
Ahmed IbrahimandCodex a2b78a6602 Stabilize Windows shell test harnesses
Add a test-only user shell override so the Windows-flaky shell command
integration tests can pin cmd.exe without changing live session state.
Use that seam in the apply_patch and websocket shell-chain suites, and
trim the redundant live PowerShell discovery from the safe-command
handler regression test. Update the flaky-test triage notes with the
latest Windows-only CI failure pair and this follow-up.

Co-authored-by: Codex <noreply@openai.com>
2026-03-17 00:17:02 +00:00
Ahmed IbrahimandCodex 9192637e4a Merge main to restore PR CI
GitHub stopped enqueuing pull_request workflows once the PR head became merge-conflicted against main. Merge main into the branch, preserve the flaky-test fixes, and record the CI trigger issue in the triage ledger.

Co-authored-by: Codex <noreply@openai.com>
2026-03-16 22:55:36 +00:00
Ahmed IbrahimandCodex 9f21509abf Retrigger PR CI after dropped event
Co-authored-by: Codex <noreply@openai.com>
2026-03-16 22:48:38 +00:00
Ahmed IbrahimandCodex 83e7ab58a9 Bound Windows PowerShell parser hangs
Co-authored-by: Codex <noreply@openai.com>
2026-03-16 22:42:10 +00:00
Ahmed IbrahimandCodex 5399ca70da Record validation pass 1
Document the fully green CI result for cc4785e3f and continue the streak toward five consecutive passing commits on this PR.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 10:39:50 +00:00
Ahmed IbrahimandCodex cc4785e3f6 Buffer fuzzy search session notifications
Preserve out-of-order fuzzy-search notifications in the in-process test harness so session completion events are not dropped while waiting for a later matching update.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 10:14:00 +00:00
Ahmed IbrahimandCodex d4cbc97a9b Remove unused fuzzy search test import
Co-authored-by: Codex <noreply@openai.com>
2026-03-14 09:54:26 +00:00
Ahmed IbrahimandCodex d87051f57e Factor in-process request response alias
Co-authored-by: Codex <noreply@openai.com>
2026-03-14 09:37:59 +00:00
Ahmed IbrahimandCodex ef5a05fa3f Inline in-process request response types
Avoid exposing a private type alias through the app-server public API so the fuzzy-search request-order fix builds cleanly across the rust-ci matrix.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 09:23:26 +00:00
Ahmed IbrahimandCodex 4195e7e808 Preserve in-process fuzzy search request ordering
Co-authored-by: Codex <noreply@openai.com>
2026-03-14 09:11:01 +00:00
Ahmed IbrahimandCodex d017d0fc35 Stabilize Windows shell and fuzzy search tests
Co-authored-by: Codex <noreply@openai.com>
2026-03-14 08:51:10 +00:00
Ahmed IbrahimandCodex 495ef3f76f Expose nextest failure tail in CI
Co-authored-by: Codex <noreply@openai.com>
2026-03-14 08:10:01 +00:00
Ahmed IbrahimandCodex 7613630080 Annotate nextest failures in CI
Capture nextest output in rust-ci and emit parsed FAIL/LEAK lines as annotations and step-summary text when tests fail.

Also record the isolated Linux test failure on b6e18d2e8 in the flaky-test ledger.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 07:40:42 +00:00
Ahmed IbrahimandCodex b6e18d2e8c Record validation pass 2
Record the green 9835ec89d CI run and advance the consecutive-pass streak to 2/5.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 07:15:02 +00:00
Ahmed IbrahimandCodex 9835ec89dd Record validation pass 1
Record the green c3b8a0ebf CI run and restart the consecutive-pass streak at 1/5.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 06:19:39 +00:00
Ahmed IbrahimandCodex c3b8a0ebfa Correct Windows popup selection assertions
Use exact selected preset names in the permissions popup tests and restore the correct Windows expectation for the default unelevated popup opening on Read Only instead of Default.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 05:56:09 +00:00
Ahmed IbrahimandCodex 13c9d91b0f Avoid false matches in permissions popup helper
Match the selected permissions preset by the row name prefix instead of a loose substring search so the Smart Approvals description cannot masquerade as Default during popup navigation.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 05:27:21 +00:00
Ahmed IbrahimandCodex 87941e5d75 Harden remaining Windows permissions popup navigation
Co-authored-by: Codex <noreply@openai.com>
2026-03-14 05:08:11 +00:00
Ahmed IbrahimandCodex e96d895c9f Stabilize Windows permissions popup navigation
Handle the Windows-only Read Only preset in the generic helper and drive the permission history snapshot tests by the selected label instead of hard-coded key counts.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 04:39:59 +00:00
Ahmed IbrahimandCodex 8bc3d489a3 Relax popup current-label assertions
Match the selected permission preset label directly in the generic history tests instead of assuming the popup always renders a  suffix.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 04:11:56 +00:00
Ahmed IbrahimandCodex a30e8e2ecb Narrow permissions popup selection helper
Restrict the selection helper to permission preset rows so popup assertions cannot bind to unrelated rendered lines.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 04:07:03 +00:00
Ahmed IbrahimandCodex fc98d21ad8 Select Smart Approvals in session-configured popup tests
Co-authored-by: Codex <noreply@openai.com>
2026-03-14 03:55:32 +00:00
Ahmed IbrahimandCodex 1b6e21ccc7 Pin snapshot popup navigation to concrete presets
Co-authored-by: Codex <noreply@openai.com>
2026-03-14 03:54:43 +00:00
Ahmed IbrahimandCodex dc8d5d46da Assert popup selection in permissions history tests
Co-authored-by: Codex <noreply@openai.com>
2026-03-14 03:52:57 +00:00
Ahmed IbrahimandCodex 5dbb9c0048 Stabilize Smart Approvals popup selection test
Co-authored-by: Codex <noreply@openai.com>
2026-03-14 03:28:27 +00:00
Ahmed IbrahimandCodex b9c655ad46 Stabilize approval matrix write-file command
Replace the approval-matrix shell redirection write path with deterministic Python file I/O and keep scenario-level diagnostics in CI while the flake is being verified.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 03:00:42 +00:00
Ahmed IbrahimandCodex 60f44b4d7c Document flaky test triage
Track CI-history evidence, hypotheses, and the per-commit pass ledger for the flaky-test investigation.

Co-authored-by: Codex <noreply@openai.com>
2026-03-14 02:54:13 +00:00
Eric Traut 7e569f1162 Add PR babysitting skill for this repo (#12513)
## PR Notes

This PR adds a project-scoped `babysit-pr` skill for ongoing PR
monitoring (CI, reviews, mergeability).

Simply invoke this skill after creating a PR, and codex will do its best
to get it to a mergeable state:

### What the skill does
* Fixes CI failures related to the PR
* Retries CI failures due to flaky tests
* Addresses code review comments if it agrees with them
* Addresses merge conflicts on main branch

### How the skill works
- Polls PR status on a loop (CI checks, workflow runs, review activity,
mergeability, and review decision).
- Detects new review feedback (including inline comments and automated
Codex review comments) and prompts/handles follow-up work.
- Distinguishes pending vs failed vs passed CI and identifies likely
flaky failures.
- Can retry failed checks/workflows when appropriate.
- Prioritizes actionable code review feedback over flaky CI retries (to
avoid rerunning CI on a SHA that is about to be replaced).
- Continues monitoring after fixes are applied and pushed, rather than
stopping after a progress update.
- Uses a slower backoff polling cadence once CI is green, while still
watching for new review feedback or state changes.
- Treats required review/approval as a blocking condition and keeps
watching until the PR is actually merge-ready (or merged/closed, or
human intervention is needed).

### Intended outcome

Keep the PR moving with minimal manual babysitting by continuously
watching for CI failures, reviewer feedback, and merge blockers, and
responding in the right order until the PR is ready to merge.
2026-02-22 15:36:28 -08:00
pakrym-oai b8e0d7594f Teach codex to test itself (#11531)
For fun and profit!
2026-02-11 20:03:19 -08:00