mirror of
https://github.com/openai/codex.git
synced 2026-11-17 22:10:37 +00:00
Buffer fuzzy search session notifications
Preserve out-of-order fuzzy-search notifications in the in-process test harness so session completion events are not dropped while waiting for a later matching update. Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
@@ -54,6 +54,7 @@ Older failures also appeared on Linux, but the repeated cross-PR signal is stron
|
||||
- Commit `4195e7e80` fixed that ordering race, but the new public in-process request helpers returned a private type alias and tripped the `Lint/Build` matrix before the remaining test jobs could finish.
|
||||
- Commit `ef5a05fa3` narrowed those signatures back to public concrete types, but the same methods still expanded to a complex nested `Result` in every `cargo clippy` target. The follow-up replaces that inline type with a documented public alias so the request-order fix does not keep failing non-release `Lint/Build`.
|
||||
- Commit `d87051f57` replaced the inline nested `Result` with a documented public alias, which cleared the type-complexity issue locally, but `cargo clippy` still failed in every non-release target because the new in-process fuzzy-search harness kept an unused `JSONRPCErrorError` import. The follow-up removes that stray test-only import.
|
||||
- Commit `d4cbc97a9` removed that unused import, which cleared the clippy matrix and stabilized Bazel after rerunning one flaky shard, but `Tests — ubuntu-24.04-arm - aarch64-unknown-linux-gnu` still exposed an ordering race in the fuzzy-search harness: `wait_for_session_updated` discarded out-of-order `sessionCompleted` notifications, so the later completion wait could time out on faster runners. The follow-up buffers unmatched notifications and adds timeout diagnostics instead of dropping them.
|
||||
- Current patch set:
|
||||
- Pin the standalone shell test to `cmd.exe` on Windows so it validates reference-context isolation without depending on PowerShell startup behavior.
|
||||
- Replace the fuzzy-file-search suite's spawned `codex-app-server` harness with the in-process app-server runtime so the tests still exercise request/notification behavior without the flaky stdio startup path.
|
||||
@@ -61,6 +62,8 @@ Older failures also appeared on Linux, but the repeated cross-PR signal is stron
|
||||
- Inline the public in-process request return types so the request-order fix no longer leaks a private alias through the `app-server` public API.
|
||||
- Expose that request-response shape through a documented public alias so `cargo clippy -D warnings` does not reject the in-process helper API for `type_complexity`.
|
||||
- Remove the unused `JSONRPCErrorError` import from the in-process fuzzy-search test harness so non-release `cargo clippy --tests` can build the suite again.
|
||||
- Buffer unmatched in-process notifications in the fuzzy-search harness so `sessionCompleted` events that arrive before the test starts waiting for them are preserved instead of dropped.
|
||||
- Include buffered-notification method names in timeout failures so any future ordering bugs surface directly in CI annotations.
|
||||
- Rationale: these failures are test-harness flakes, not product behaviors. The fixes keep the assertions intact and remove environment-sensitive startup and ordering hazards instead of stretching timeouts.
|
||||
|
||||
## Constraints
|
||||
@@ -94,3 +97,4 @@ Older failures also appeared on Linux, but the repeated cross-PR signal is stron
|
||||
| `4195e7e80` | Preserve in-process fuzzy search request ordering | failed | Run `23084952538` proved the Linux ordering fix was necessary, but the follow-up widened the `app-server` public API with methods that returned a private type alias. `Lint/Build` failed on Linux and macOS before the remaining `Tests` jobs finished, so the next follow-up narrows the public signatures back to concrete types and reuses the same request-order behavior. |
|
||||
| `ef5a05fa3` | Inline in-process request response types | failed | Run `23085144063` cleared the private-alias compile break, but every non-release `Lint/Build` target still failed in `cargo clippy` while release builds passed. The next follow-up replaces the inline `IoResult<Result<...>>` signatures with a documented public alias, which is the smallest code change consistent with the cross-target `cargo clippy` pattern. |
|
||||
| `d87051f57` | Factor in-process request response alias | failed | Run `23085369065` narrowed the non-release `cargo clippy` failures down to a single test-harness warning: `unused import: codex_app_server_protocol::JSONRPCErrorError` in `app-server/tests/suite/fuzzy_file_search.rs`. The next follow-up removes that import so the request-order fix can finish the matrix. |
|
||||
| `d4cbc97a9` | Remove unused fuzzy search test import | failed | Run `23085620967` cleared every completed non-release `Lint/Build` lane and passed Bazel after rerunning a flaky macOS x64 shard, but `Tests — ubuntu-24.04-arm - aarch64-unknown-linux-gnu` failed in `all::suite::fuzzy_file_search::test_fuzzy_file_search_session_multiple_query_updates_work`. The failure stack pointed to `wait_for_session_completed`, and the harness was still dropping out-of-order `sessionCompleted` notifications while waiting for matching `sessionUpdated` events. |
|
||||
|
||||
Reference in New Issue
Block a user