mirror of
https://github.com/openai/codex.git
synced 2026-11-17 22:10:37 +00:00
Stabilize Smart Approvals popup selection test
Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
@@ -38,12 +38,18 @@ Older failures also appeared on Linux, but the repeated cross-PR signal is stron
|
||||
1. Approval-related tests in `codex-rs/core/tests/suite/approvals.rs` still have timing-sensitive behavior, especially in cross-platform CI.
|
||||
2. Windows-specific approval UI tests in `codex-rs/tui/src/chatwidget/tests.rs` may depend on partially implicit sandbox state and can fail intermittently on Windows runners.
|
||||
|
||||
## Current Fix In Progress
|
||||
## First Fix Landed
|
||||
|
||||
- Replace the approval-matrix write-file command from shell redirection (`printf > file && cat file`) with a deterministic `python3 -c` file write/readback command.
|
||||
- Keep targeted scenario diagnostics in the matrix so CI logs include the exact command, exit code, and stdout when a scenario fails again.
|
||||
- Rationale: the known `read_only_unless_trusted_requires_approval` flake was previously "fixed" by increasing timeout budget. This change removes shell-redirection timing sensitivity instead of stretching the timeout further.
|
||||
|
||||
## Current Fix In Progress
|
||||
|
||||
- Harden `permissions_selection_can_disable_smart_approvals` in `codex-rs/tui/src/chatwidget/tests.rs`.
|
||||
- Seed the popup into Smart Approvals mode explicitly, then assert the selected row before and after navigation instead of assuming the initial cursor position.
|
||||
- Rationale: recent merged PR `#14645` fixed another Smart Approvals popup test that was implicitly relying on selection state. This remaining test still used the same brittle pattern.
|
||||
|
||||
## Constraints
|
||||
|
||||
- Do not run tests locally.
|
||||
@@ -56,4 +62,4 @@ Older failures also appeared on Linux, but the repeated cross-PR signal is stron
|
||||
| Commit | Purpose | PR CI result | Notes |
|
||||
| --- | --- | --- | --- |
|
||||
| `60f44b4d7` | PR bootstrap | partial pass | PR opened and non-Rust checks passed after rebasing to current `main`, but `rust-ci` skipped because only the tracking doc changed. This commit does not count toward the five full-suite green commits. |
|
||||
| _pending_ | First full-suite flaky-test fix | _pending_ | Approvals matrix write-file command now uses deterministic Python I/O instead of shell redirection. |
|
||||
| `b9c655ad4` | First full-suite flaky-test fix | full pass | Full PR CI passed on run `23078933382`, including `Tests — windows-x64 - x86_64-pc-windows-msvc` and `Tests — windows-arm64 - aarch64-pc-windows-msvc`. The approvals matrix write-file command now uses deterministic Python I/O instead of shell redirection. This is pass 1 of 5. |
|
||||
|
||||
Reference in New Issue
Block a user