Commit Graph
7984 Commits
Author SHA1 Message Date
Chris Bookholt 7a02f212e9 fix(core): require authority without filesystem containment 2026-07-03 15:15:55 -07:00
Chris Bookholt 1b7971db15 Merge commit '22e9d5ff64c6c0be7563f15227d875ca097f2984' into bookholt/psec-4922-powershell-one-shot-policy 2026-07-03 11:49:30 -07:00
Chris Bookholt 22e9d5ff64 Merge commit 'e2c95101bcb0bcf7390954b7f0fbb7188214631b' into bookholt/psec-4922-namespace-safe-execpolicy-published 2026-07-03 11:49:10 -07:00
Chris Bookholt e2c95101bc Merge commit 'f9c6f4acfad76b152ef88326d503e6ce6f7516b1' into bookholt/psec-4922-one-shot-approval-lifecycle-published 2026-07-03 11:48:47 -07:00
Chris Bookholt f9c6f4acfa Merge commit 'e3c97a97ae19b1da1662fccc37178bb22fdac1cd' into bookholt/psec-4922-explicit-approval-purpose 2026-07-03 11:48:24 -07:00
Chris Bookholt e3c97a97ae Merge commit 'a0eb300e647051b2fecf3954e6df2a7187d5f0ba' into bookholt/psec-4922-repeated-approval-client-integrity 2026-07-03 11:48:03 -07:00
Chris Bookholt a0eb300e64 Merge commit '13a5b13880195b1b43906b4577b5b1fa656fda9c' into bookholt/psec-4922-approval-integrity 2026-07-03 11:47:43 -07:00
Chris Bookholt 13a5b13880 Fix Windows compaction shell fixtures 2026-07-03 11:36:37 -07:00
Chris Bookholt 1c37924e39 test: remove redundant approval wait loop 2026-07-03 06:13:07 -07:00
Chris Bookholt 2d13f93d85 test: follow PowerShell approval abort lifecycle 2026-07-03 06:02:40 -07:00
Chris Bookholt 485ecf740f test: assert requested PowerShell argv 2026-07-03 05:37:49 -07:00
Chris Bookholt 8f03e96cf7 Fix Windows policy test redundant clones 2026-07-03 05:13:09 -07:00
Chris Bookholt 42a055cc3b Restore one-shot policy for inspected PowerShell wrappers 2026-07-03 04:50:10 -07:00
Chris Bookholt 0a8f5f1e26 Merge PR #30983 one-shot approval lifecycle layer 2026-07-03 03:23:54 -07:00
Chris Bookholt 7f7fd528a6 Merge PR #30976 approval purpose layer 2026-07-03 02:49:07 -07:00
Chris Bookholt 5337f1087e Merge commit '627ece53833650a86257e08d9a2ea935fc3e8d97' into bookholt/psec-4922-explicit-approval-purpose 2026-07-03 02:06:55 -07:00
Chris Bookholt 4dc7747cc3 Merge final repeated-approval parent 2026-07-03 02:06:51 -07:00
Chris Bookholt 627ece5383 Fix TUI argument comment lint 2026-07-03 02:01:44 -07:00
Chris Bookholt 8c9c1ea9fe Harden TUI app-server request correlation 2026-07-03 01:37:58 -07:00
Chris Bookholt e7a5490858 Merge commit 'ee10594f6cea193c6eb3530b80454a6f298c44f5' into bookholt/psec-4922-repeated-approval-client-integrity 2026-07-03 00:05:17 -07:00
Chris Bookholt ee10594f6c Merge commit '20be6f275ee88225a4974687e07e4d5210e5de4d' into bookholt/psec-4922-approval-integrity 2026-07-02 23:50:47 -07:00
Chris Bookholt 416a3672e4 Merge one-shot approval lifecycle parent 2026-07-02 23:29:47 -07:00
Chris Bookholt 924589da6e Harden namespace host mapping aliases 2026-07-02 23:29:35 -07:00
Chris Bookholt 498ca9ee04 fix(core): bound interim one-shot dead-code expectation 2026-07-02 22:41:16 -07:00
Chris Bookholt 45e2d1c252 Harden namespace-aware executable policy matching 2026-07-02 22:24:55 -07:00
Chris Bookholt 20be6f275e fix(shell-command): satisfy Windows and argument lint 2026-07-02 22:18:23 -07:00
Chris Bookholt 00e7179f00 Bind retry approvals to fresh callback authority 2026-07-02 22:02:53 -07:00
Chris Bookholt 19cd2cb97c Harden one-shot command approval retries 2026-07-02 22:02:34 -07:00
Chris Bookholt 91798e6206 fix(shell-command): reject assembly-qualified parser input 2026-07-02 21:54:03 -07:00
Chris Bookholt 7697208282 fix(shell-command): harden PowerShell policy parsing 2026-07-02 21:42:31 -07:00
Chris Bookholt 8a241c6ef8 Merge corrected repeated-approval parent
# Conflicts:
#	codex-rs/analytics/src/reducer.rs
2026-07-02 20:57:08 -07:00
Chris Bookholt 458fc093c4 Fix argument comment lint in approval tests 2026-07-02 20:49:38 -07:00
Chris Bookholt 7346a178fd Merge explicit command approval purpose 2026-07-02 20:42:51 -07:00
Chris Bookholt 90b2b3c717 Add explicit command approval purpose 2026-07-02 20:36:58 -07:00
Chris Bookholt 76e663de9b Merge repeated approval client integrity 2026-07-02 20:12:05 -07:00
Chris Bookholt 9091ab403d Preserve repeated approval client integrity 2026-07-02 20:09:58 -07:00
Chris Bookholt 2e3904d2a7 Merge corrected PSEC-4922 parser base 2026-07-02 19:59:02 -07:00
Chris Bookholt d62080c197 Fix Windows PowerShell test macro resolution 2026-07-02 19:58:20 -07:00
Chris Bookholt 8fe3565b5b Merge commit 'c1ff6221c1eb5842636ea0fc85e1c9542c550080' into bookholt/psec-4922-approval-integrity 2026-07-02 19:47:16 -07:00
Chris Bookholt c1ff6221c1 Harden PowerShell exec-policy classification 2026-07-02 19:40:51 -07:00
Chris Bookholt 4a312592ba Merge refreshed PSEC-4922 base into approval integrity 2026-07-02 19:09:32 -07:00
Chris Bookholt 9f9db61ddf Merge current main into PSEC-4922 stack base 2026-07-02 19:07:50 -07:00
Chris Bookholt 5e50079976 Merge dispatcher lifecycle tests into client stack 2026-07-02 19:01:36 -07:00
Chris Bookholt 474b1d4ec9 Test repeated approval lifecycle through dispatcher 2026-07-02 19:00:02 -07:00
Chris Bookholt 122f8f2f59 Merge duplicate approval ID hardening into client stack 2026-07-02 18:53:20 -07:00
Chris Bookholt bfb7344449 Reject duplicate pending approval IDs 2026-07-02 18:52:04 -07:00
Chris Bookholt 4f90af46c7 Prepare clients for repeated command approvals 2026-07-02 18:47:49 -07:00
Shijie Rao da4c8ca57d [codex] Add configurable multi-agent mode hint text (#30493)
## Why

Multi-agent V2 normally derives its mode instructions from reasoning
effort: Ultra enables proactive delegation, while other efforts require
an explicit request. Some deployments need to provide one configured
delegation policy that replaces those built-ins and remains stable when
reasoning effort changes.

## What changed

- Add `features.multi_agent_v2.multi_agent_mode_hint_text` alongside the
existing root and subagent hint settings.
- Treat any configured value, including an empty string, as
`MultiAgentMode::Custom(hint_text)`, so the configured text replaces the
built-in explicit-only and proactive policies.
- Persist the full custom variant and hint text in the turn-context
snapshot, so the durable comparison baseline detects both
reasoning-effort changes and configured policy-text changes.
- Preserve the existing explicit-only/proactive behavior when the
setting is absent.
- Replace the ambiguous `MultiAgentMode::None` variant with
`MultiAgentMode::Custom(String)` in new rollouts and API schemas. A
compatibility wire type maps legacy serialized `none` values to
`Custom("")` when resuming existing rollouts.
- Regenerate the config and app-server schemas.

## Configuration examples

The distinction is whether `multi_agent_mode_hint_text` is present. An
empty string is still a configured value and intentionally suppresses
the built-in mode instructions.

### Unset: preserve existing effort-derived behavior

```toml
[features.multi_agent_v2]
enabled = true
# multi_agent_mode_hint_text is omitted
```

- Ultra reasoning uses the built-in proactive delegation instructions.
- Other reasoning efforts use the built-in explicit-request-only
instructions.

### Empty: suppress all mode hint text

```toml
[features.multi_agent_v2]
enabled = true
multi_agent_mode_hint_text = ""
```

This selects effective mode `custom` at every reasoning effort and
injects an empty mode body, suppressing both built-in policies.

### Set: always use the configured text

```toml
[features.multi_agent_v2]
enabled = true
multi_agent_mode_hint_text = "Delegate to subagents when it will materially improve the result."
```

This selects effective mode `custom` at every reasoning effort and
injects the configured text verbatim instead of either built-in policy.

## Verification

- `just test -p codex-core multi_agent_mode`
- Covers a configured hint across High and Ultra reasoning efforts and
verifies the full custom hint is recorded for both turns.
- Covers an empty-string override suppressing both built-in instruction
bodies.
- `just test -p codex-protocol -p codex-app-server-protocol`
- Covers legacy `none` turn-context deserialization as `Custom("")` and
verifies the regenerated schemas.
2026-07-02 18:44:34 -07:00
Chris Bookholt 2e1ed41bcb Validate responses against typed pending approvals
Approval responses were keyed only by string ID and could return values the server did not offer. That allowed one approval kind to consume another kind’s waiter and trusted client-supplied persistence payloads too broadly.

Key pending approvals by request kind, record the exact accepted ReviewDecision values, and consume each waiter once before applying an amendment or continuing execution. Preserve ordinary session approval and the exact server-proposed restrictive network-deny path, while treating unoffered responses as denied.

Route delegated cancellation to the matching exec or patch waiter and keep Guardian-only reviews independent of the approval ledger. Add unit, integration, delegation, and telemetry coverage for exact payloads, kind isolation, cancellation, replay, and compatibility.
2026-07-02 18:35:56 -07:00
Michael Bolin beca198b8a telemetry: log structured direct tool-call timing (#30334)
## Why

App-server deployments can consume structured JSON logs for operational
measurements without requiring an OTEL exporter. Existing tool-result
telemetry reports the handler outcome, but it does not separate time
spent waiting to dispatch from time spent executing the handler.

A compact completion event for the outer, direct tool call lets
consumers measure those phases and correlate them with a conversation
and turn. Code-mode calls are intentionally excluded so nested runtime
calls do not create overlapping events that are easy to double-count.

## What changed

- Added a
[`ToolCallTimingGuard`](https://github.com/openai/codex/blob/141110a73cff041c42fd51f47e363e83df1dde51/codex-rs/core/src/tools/parallel.rs#L32)
around direct tool calls. Event-only strings and timing state are
captured only when the `codex_core::tools::parallel` `INFO` target is
enabled.
- Added a
[`codex.tool_call`](https://github.com/openai/codex/blob/141110a73cff041c42fd51f47e363e83df1dde51/codex-rs/core/src/tools/parallel.rs#L313)
completion event with conversation, turn, tool, call, trace, dispatch,
handler, and total timing fields.
- Recorded the execution-start marker after the dispatch lock is
acquired. Event emission snapshots that marker once so a concurrently
starting dispatch cannot produce internally inconsistent fields.
- Limited the event to `ToolCallSource::Direct`; [unit
coverage](https://github.com/openai/codex/blob/141110a73cff041c42fd51f47e363e83df1dde51/codex-rs/core/src/tools/parallel.rs#L365)
verifies code-mode calls are ignored.
- Added [cancellation
coverage](https://github.com/openai/codex/blob/141110a73cff041c42fd51f47e363e83df1dde51/codex-rs/core/src/tools/parallel.rs#L408)
that holds the execution gate and verifies a call cancelled before
admission emits exactly one dispatch-only timing event.
- Added reusable
[`JsonLogCapture`](https://github.com/openai/codex/blob/141110a73cff041c42fd51f47e363e83df1dde51/codex-rs/app-server/tests/common/json_logging.rs#L15)
support, a [JSON-logging-specific `TestAppServer`
constructor](https://github.com/openai/codex/blob/141110a73cff041c42fd51f47e363e83df1dde51/codex-rs/app-server/tests/common/test_app_server.rs#L172),
and an [end-to-end app-server
test](https://github.com/openai/codex/blob/141110a73cff041c42fd51f47e363e83df1dde51/codex-rs/app-server/tests/suite/logging.rs#L52)
that drives a direct `exec_command` through the public v2 JSON-RPC API
and validates the emitted JSON event.

Exec-server-specific request and process timing remains in the stacked
PR #30901.

## Suggested logging filter

```bash
LOG_FORMAT=json \
RUST_LOG='warn,codex_core::tools::parallel=info' \
codex app-server
```

## Event example

Identifier and timing values are illustrative.

### `codex.tool_call`

```json
{
  "timestamp": "2026-06-27T03:45:20.443Z",
  "level": "INFO",
  "fields": {
    "message": "tool call completed",
    "event.name": "codex.tool_call",
    "trace_id": "4bf92f3577b34da6a3ce929d0e0e4736",
    "conversation.id": "67e55044-10b1-426f-9247-bb680e5fe0c8",
    "turn_id": "019f04f8-6ac2-78f1-8625-f04a6d35af18",
    "tool_name": "exec_command",
    "call_id": "call_7b8483",
    "tool_source": "direct",
    "execution_started": true,
    "dispatch_duration_ms": 12,
    "handler_duration_ms": 431,
    "total_duration_ms": 443
  },
  "target": "codex_core::tools::parallel"
}
```

If execution never starts, `execution_started` is `false`,
`handler_duration_ms` is `0`, and `dispatch_duration_ms` covers the full
observed lifetime.

If a duration cannot be represented as an unsigned 64-bit millisecond
value, all three duration fields are omitted rather than populated with
a sentinel that could corrupt downstream calculations.

## Test plan

- `just test -p codex-core
tool_call_timing_guard_ignores_code_mode_source`
- `just test -p codex-core
cancellation_before_dispatch_admission_logs_dispatch_only_timing`
- `just test -p codex-app-server
app_server_emits_structured_tool_call_timing_event`

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/30334).
* __->__ #30334
2026-07-02 13:53:56 -07:00