openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-06 15:29:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix argument comment lint in approval tests

Browse Source
This commit is contained in:
Chris Bookholt
2026-07-02 20:49:38 -07:00
parent 76e663de9b
commit 458fc093c4
2 changed files with 35 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
codex-rs/analytics/src/reducer.rs
View File

@@ -2874,17 +2874,27 @@ mod tests {
command_execution_review_trigger(
Some("retry-id"),
Some("sandbox denied"),
false,
false
/*requested_additional_permissions*/ false,
/*requested_network_access*/ false,
),
ReviewTrigger::SandboxDenial
));
assert!(matches!(
command_execution_review_trigger(Some("execve-id"), None, false, false),
command_execution_review_trigger(
Some("execve-id"),
/*reason*/ None,
/*requested_additional_permissions*/ false,
/*requested_network_access*/ false,
),
ReviewTrigger::ExecveIntercept
));
assert!(matches!(
command_execution_review_trigger(None, Some("initial justification"), false, false),
command_execution_review_trigger(
/*approval_id*/ None,
Some("initial justification"),
/*requested_additional_permissions*/ false,
/*requested_network_access*/ false,
),
ReviewTrigger::Initial
));
}
@@ -2895,21 +2905,34 @@ mod tests {
command_execution_review_trigger(
Some("network-id"),
Some("network denied"),
true,
true,
/*requested_additional_permissions*/ true,
/*requested_network_access*/ true,
),
ReviewTrigger::NetworkPolicyDenial
));
assert!(matches!(
command_execution_review_trigger(Some("permissions-id"), None, true, false),
command_execution_review_trigger(
Some("permissions-id"),
/*reason*/ None,
/*requested_additional_permissions*/ true,
/*requested_network_access*/ false,
),
ReviewTrigger::ExecveIntercept
));
assert!(matches!(
command_execution_review_trigger(None, None, true, false),
command_execution_review_trigger(
/*approval_id*/ None, /*reason*/ None,
/*requested_additional_permissions*/ true,
/*requested_network_access*/ false,
),
ReviewTrigger::SandboxDenial
));
assert!(matches!(
command_execution_review_trigger(None, None, false, false),
command_execution_review_trigger(
/*approval_id*/ None, /*reason*/ None,
/*requested_additional_permissions*/ false,
/*requested_network_access*/ false,
),
ReviewTrigger::Initial
));
}

4
codex-rs/tui/src/app/pending_interactive_replay.rs
View File

@@ -772,7 +772,9 @@ mod tests {
#[test]
fn thread_event_snapshot_keeps_retry_callback_after_initial_item_approval() {
let mut store = ThreadEventStore::new(/*capacity*/ 8);
store.push_request(exec_approval_request("call-1", None, "turn-1"));
store.push_request(exec_approval_request(
"call-1", /*approval_id*/ None, "turn-1",
));
store.note_outbound_op(&Op::ExecApproval {
id: "call-1".to_string(),
turn_id: Some("turn-1".to_string()),