From 458fc093c401cb18cdc6b1d31332d705aff0c076 Mon Sep 17 00:00:00 2001
From: Chris Bookholt <bookholt@openai.com>
Date: Thu, 2 Jul 2026 20:49:38 -0700
Subject: [PATCH] Fix argument comment lint in approval tests

---
 codex-rs/analytics/src/reducer.rs             | 41 +++++++++++++++----
 .../tui/src/app/pending_interactive_replay.rs |  4 +-
 2 files changed, 35 insertions(+), 10 deletions(-)

diff --git a/codex-rs/analytics/src/reducer.rs b/codex-rs/analytics/src/reducer.rs
index a076a37c3d..9ff74dd210 100644
--- a/codex-rs/analytics/src/reducer.rs
+++ b/codex-rs/analytics/src/reducer.rs
@@ -2874,17 +2874,27 @@ mod tests {
             command_execution_review_trigger(
                 Some("retry-id"),
                 Some("sandbox denied"),
-                false,
-                false
+                /*requested_additional_permissions*/ false,
+                /*requested_network_access*/ false,
             ),
             ReviewTrigger::SandboxDenial
         ));
         assert!(matches!(
-            command_execution_review_trigger(Some("execve-id"), None, false, false),
+            command_execution_review_trigger(
+                Some("execve-id"),
+                /*reason*/ None,
+                /*requested_additional_permissions*/ false,
+                /*requested_network_access*/ false,
+            ),
             ReviewTrigger::ExecveIntercept
         ));
         assert!(matches!(
-            command_execution_review_trigger(None, Some("initial justification"), false, false),
+            command_execution_review_trigger(
+                /*approval_id*/ None,
+                Some("initial justification"),
+                /*requested_additional_permissions*/ false,
+                /*requested_network_access*/ false,
+            ),
             ReviewTrigger::Initial
         ));
     }
@@ -2895,21 +2905,34 @@ mod tests {
             command_execution_review_trigger(
                 Some("network-id"),
                 Some("network denied"),
-                true,
-                true,
+                /*requested_additional_permissions*/ true,
+                /*requested_network_access*/ true,
             ),
             ReviewTrigger::NetworkPolicyDenial
         ));
         assert!(matches!(
-            command_execution_review_trigger(Some("permissions-id"), None, true, false),
+            command_execution_review_trigger(
+                Some("permissions-id"),
+                /*reason*/ None,
+                /*requested_additional_permissions*/ true,
+                /*requested_network_access*/ false,
+            ),
             ReviewTrigger::ExecveIntercept
         ));
         assert!(matches!(
-            command_execution_review_trigger(None, None, true, false),
+            command_execution_review_trigger(
+                /*approval_id*/ None, /*reason*/ None,
+                /*requested_additional_permissions*/ true,
+                /*requested_network_access*/ false,
+            ),
             ReviewTrigger::SandboxDenial
         ));
         assert!(matches!(
-            command_execution_review_trigger(None, None, false, false),
+            command_execution_review_trigger(
+                /*approval_id*/ None, /*reason*/ None,
+                /*requested_additional_permissions*/ false,
+                /*requested_network_access*/ false,
+            ),
             ReviewTrigger::Initial
         ));
     }
diff --git a/codex-rs/tui/src/app/pending_interactive_replay.rs b/codex-rs/tui/src/app/pending_interactive_replay.rs
index bf1c004165..39f97ce39e 100644
--- a/codex-rs/tui/src/app/pending_interactive_replay.rs
+++ b/codex-rs/tui/src/app/pending_interactive_replay.rs
@@ -772,7 +772,9 @@ mod tests {
     #[test]
     fn thread_event_snapshot_keeps_retry_callback_after_initial_item_approval() {
         let mut store = ThreadEventStore::new(/*capacity*/ 8);
-        store.push_request(exec_approval_request("call-1", None, "turn-1"));
+        store.push_request(exec_approval_request(
+            "call-1", /*approval_id*/ None, "turn-1",
+        ));
         store.note_outbound_op(&Op::ExecApproval {
             id: "call-1".to_string(),
             turn_id: Some("turn-1".to_string()),