Commit Graph
15598 Commits
Author SHA1 Message Date
Michael Bolin 292856b339 merge commit for archive created by Sapling 2026-05-14 12:45:43 -07:00
Michael Bolin 1230fb5107 tui/exec: show effective workspace roots in summaries 2026-05-14 12:33:16 -07:00
Michael Bolin fefc579cca app-server: use permission ids and runtime workspace roots 2026-05-14 12:33:16 -07:00
Michael Bolin d3b8dc8a62 permissions: resolve profile identity with constraints 2026-05-14 12:33:05 -07:00
Michael Bolin 5ee2cb6e5f Merge 2a7104fdb2 into sapling-pr-archive-bolinfest 2026-05-14 11:39:55 -07:00
Michael Bolin 2a7104fdb2 tui/exec: show effective workspace roots in summaries 2026-05-14 11:39:36 -07:00
Michael Bolin f42586d9aa app-server: use permission ids and runtime workspace roots 2026-05-14 11:39:36 -07:00
Michael Bolin 5e3f04da96 permissions: support workspace roots in profiles 2026-05-14 11:39:03 -07:00
Michael Bolin c5d441d842 merge commit for archive created by Sapling 2026-05-14 11:28:08 -07:00
Michael Bolin 5416bbd4e8 tui/exec: show effective workspace roots in summaries 2026-05-14 11:27:48 -07:00
Michael Bolin 842662a4be app-server: use permission ids and runtime workspace roots 2026-05-14 11:27:48 -07:00
Michael Bolin 6589c9131f permissions: support workspace roots in profiles 2026-05-14 11:27:25 -07:00
Michael Bolin 9006cc3073 merge commit for archive created by Sapling 2026-05-14 11:06:44 -07:00
Michael Bolin 5cba401114 tui/exec: show effective workspace roots in summaries 2026-05-14 10:59:45 -07:00
Michael Bolin 247bbdaf05 app-server: use permission ids and runtime workspace roots 2026-05-14 10:59:10 -07:00
Michael Bolin 2fbcb8554e permissions: support workspace roots in profiles 2026-05-14 10:58:07 -07:00
Michael Bolin afbea8ab82 Merge 5a5197bc0e into sapling-pr-archive-bolinfest 2026-05-14 10:24:29 -07:00
Michael Bolin 5a5197bc0e tui/exec: show effective workspace roots in summaries 2026-05-14 10:24:07 -07:00
Michael Bolin 8429c8955a app-server: use permission ids and runtime workspace roots 2026-05-14 10:24:07 -07:00
Michael Bolin 9ccddb30a7 permissions: support workspace roots in profiles 2026-05-14 10:24:07 -07:00
Michael Bolin f623d41222 Merge 4c8c508620 into sapling-pr-archive-bolinfest 2026-05-14 10:11:20 -07:00
Michael Bolin 96d85dc984 merge commit for archive created by Sapling 2026-05-14 10:11:05 -07:00
Michael Bolin 4c8c508620 tui/exec: show effective workspace roots in summaries 2026-05-14 10:10:39 -07:00
Michael Bolin 572a5c3ff7 app-server: use permission ids and runtime workspace roots 2026-05-14 10:10:39 -07:00
Michael Bolin d9c6a91058 permissions: support workspace roots in profiles 2026-05-14 10:09:50 -07:00
Michael Bolin 9ea1c57baa Merge f298b2d285 into sapling-pr-archive-bolinfest 2026-05-14 09:46:07 -07:00
Michael Bolin ccf09df586 merge commit for archive created by Sapling 2026-05-14 09:45:54 -07:00
Michael Bolin f298b2d285 tui/exec: show effective workspace roots in summaries 2026-05-14 09:45:35 -07:00
Michael Bolin cd12cc2ab9 app-server: use permission ids and runtime workspace roots 2026-05-14 09:45:35 -07:00
Michael Bolin 1158c52e8b Merge f86711efa8 into sapling-pr-archive-bolinfest 2026-05-14 09:41:32 -07:00
Michael Bolin c301e69150 Merge 5b6acbb6b5 into sapling-pr-archive-bolinfest 2026-05-14 09:41:15 -07:00
Michael Bolin deac94bc66 merge commit for archive created by Sapling 2026-05-14 09:40:56 -07:00
Michael Bolin f86711efa8 tui/exec: show effective workspace roots in summaries 2026-05-14 09:40:33 -07:00
Michael Bolin 5b6acbb6b5 app-server: use permission ids and runtime workspace roots 2026-05-14 09:40:33 -07:00
Michael Bolin 6803c35f38 permissions: support workspace roots in profiles 2026-05-14 09:40:32 -07:00
Michael Bolin 3a2406cc24 Merge a204e78e03 into sapling-pr-archive-bolinfest 2026-05-14 09:36:42 -07:00
Michael Bolin c1cb6422e4 Merge 86bb110674 into sapling-pr-archive-bolinfest 2026-05-14 09:36:16 -07:00
Michael Bolin a204e78e03 tui/exec: show effective workspace roots in summaries 2026-05-14 09:35:22 -07:00
Michael Bolin 86bb110674 app-server: use permission ids and runtime workspace roots 2026-05-14 09:35:22 -07:00
Michael Bolin b1a17b6185 Merge 559afb6a59 into sapling-pr-archive-bolinfest 2026-05-14 09:34:42 -07:00
Michael Bolin 559afb6a59 permissions: support workspace roots in profiles 2026-05-14 09:34:27 -07:00
Michael Bolin dd6d5ba02e merge commit for archive created by Sapling 2026-05-14 09:09:50 -07:00
Michael Bolin 99a5efaa3c permissions: support workspace roots in profiles 2026-05-14 09:08:55 -07:00
Michael Bolin dd27a756bb merge commit for archive created by Sapling 2026-05-14 09:00:00 -07:00
Michael Bolin 04fffb495e tui/exec: show effective workspace roots in summaries 2026-05-14 08:59:08 -07:00
Michael Bolin f38a05be73 app-server: use permission ids and runtime workspace roots 2026-05-14 08:59:08 -07:00
Michael Bolin d8553d10d2 permissions: support workspace roots in profiles 2026-05-14 08:46:50 -07:00
Michael Bolin 01d93fd9fc permissions: canonicalize workspace_roots and danger-full-access names (#22624)
## Why

This is a small precursor to the larger permissions-migration work. Both
the comparison stack in
[#22401](https://github.com/openai/codex/pull/22401) /
[#22402](https://github.com/openai/codex/pull/22402) and the alternate
stack in [#22610](https://github.com/openai/codex/pull/22610) /
[#22611](https://github.com/openai/codex/pull/22611) /
[#22612](https://github.com/openai/codex/pull/22612) are easier to
review if the terminology is already settled underneath them.

Because `:project_roots` and `:danger-no-sandbox` have not shipped as
stable user-facing surface area, carrying them forward as aliases would
just add more migration logic to the later stacks. This PR removes that
ambiguity now so the follow-on work can rely on one spelling for each
built-in concept.

## What Changed

- renamed the config-facing special filesystem key from `:project_roots`
to `:workspace_roots`
- dropped unpublished `:project_roots` parsing support in
`core/src/config/permissions.rs`, so new config only recognizes
`:workspace_roots`
- renamed the built-in full-access permission profile id from
`:danger-no-sandbox` to `:danger-full-access`
- dropped unpublished `:danger-no-sandbox` support entirely, including
the old active-profile canonicalization path, and added explicit
rejection coverage for the legacy id
- introduced shared built-in permission-profile id constants in
`codex-rs/protocol/src/models.rs`
- updated `core`, `app-server`, and `tui` call sites that special-case
built-in profiles to use the shared constants and canonical ids
- updated tests and the Linux sandbox README to use `:workspace_roots` /
`:danger-full-access`

## Verification

I focused verification on the three places this rename can regress:
config parsing, active-profile identity surfaced back out of `core`, and
user/server call sites that special-case built-in profiles.

Targeted checks:

-
`config::tests::default_permissions_can_select_builtin_profile_without_permissions_table`
-
`config::tests::default_permissions_read_only_applies_additional_writable_roots_as_modifications`
-
`config::tests::default_permissions_can_select_builtin_full_access_profile`
- `config::tests::legacy_danger_no_sandbox_is_rejected`
- `workspace_root` filtered `codex-core` tests
-
`request_processors::thread_processor::thread_processor_tests::thread_processor_behavior_tests::requested_permissions_trust_project_uses_permission_profile_intent`
-
`suite::v2::turn_start::turn_start_rejects_invalid_permission_selection_before_starting_turn`
- `status::tests::status_snapshot_shows_auto_review_permissions`
-
`status::tests::status_permissions_full_disk_managed_with_network_is_danger_full_access`
-
`app_server_session::tests::embedded_turn_permissions_use_active_profile_selection`
2026-05-14 08:45:54 -07:00
jif-oai 12bfb57139 Fix turn extension data task plumbing (#22646)
## Summary
- carry the per-turn extension data through RunningTask so abort
handling can rebuild SessionTaskContext
- update stale test ExtensionData::new() callsites to pass the turn id

## Testing
- Not run after PR branch creation; CI will cover.
2026-05-14 16:00:06 +02:00
Chris Bookholt 9ea38136b0 [codex] treat PowerShell stop-parsing forms as unsupported (#22643)
## Summary
- Treat PowerShell stop-parsing token forms as unsupported in the
AST-backed command flattener.
- Add focused regressions at the parser layer and Windows command-safety
layer.

## Why
The command-safety parser lowers PowerShell AST elements into argv-like
words. Stop-parsing syntax preserves a native-command argument shape
that this lowering does not model, so these forms should stay on the
conservative unsupported path.

## Validation
- `cargo fmt --manifest-path codex-rs/Cargo.toml --all --check`
- `cargo test --manifest-path codex-rs/Cargo.toml -p
codex-shell-command`
2026-05-14 06:28:34 -07:00