openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-11-02 19:43:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update Windows process-tree tests for inherited FDs (#34640)

Browse Source 
## Why

The PTY and pipe spawn helpers now require callers to specify which file
descriptors should be inherited, following
https://github.com/openai/codex/pull/13644.

## What changed

Pass empty inherited-FD slices from the Windows process-tree tests, which do
not need to preserve any file descriptors.

GitOrigin-RevId: 5e578df34e195251490608a163f8aaee0a6e681c
This commit is contained in:
Michael Bolin
2026-07-21 23:29:03 +00:00
committed by copyberry
parent 81de4f251c
commit bdd3118c71
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/utils/pty/src/windows_tests.rs
+4 -2
View File
@@ -79,7 +79,7 @@ async fn assert_terminate_kills_descendant(
);
let args = vec!["-u".to_string(), "-c".to_string(), code];
let spawned = if backend == "pipe" {
spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None).await?
spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None, &[]).await?
} else {
spawn_pty_process(
python,
@@ -88,6 +88,7 @@ async fn assert_terminate_kills_descendant(
env,
/*arg0*/ &None,
TerminalSize::default(),
&[],
)
.await?
};
@@ -134,7 +135,7 @@ async fn assert_normal_exit_preserves_descendant(
);
let args = vec!["-u".to_string(), "-c".to_string(), code];
let spawned = if backend == "pipe" {
spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None).await?
spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None, &[]).await?
} else {
spawn_pty_process(
python,
@@ -143,6 +144,7 @@ async fn assert_normal_exit_preserves_descendant(
env,
/*arg0*/ &None,
TerminalSize::default(),
&[],
)
.await?
};