From bdd3118c71a29f26b9df3a47f91efea38a0d58bd Mon Sep 17 00:00:00 2001 From: Michael Bolin Date: Tue, 21 Jul 2026 23:23:54 +0000 Subject: [PATCH] Update Windows process-tree tests for inherited FDs (#34640) ## Why The PTY and pipe spawn helpers now require callers to specify which file descriptors should be inherited, following https://github.com/openai/codex/pull/13644. ## What changed Pass empty inherited-FD slices from the Windows process-tree tests, which do not need to preserve any file descriptors. GitOrigin-RevId: 5e578df34e195251490608a163f8aaee0a6e681c --- codex-rs/utils/pty/src/windows_tests.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/codex-rs/utils/pty/src/windows_tests.rs b/codex-rs/utils/pty/src/windows_tests.rs index 06e7fd0a51..0dc095752c 100644 --- a/codex-rs/utils/pty/src/windows_tests.rs +++ b/codex-rs/utils/pty/src/windows_tests.rs @@ -79,7 +79,7 @@ async fn assert_terminate_kills_descendant( ); let args = vec!["-u".to_string(), "-c".to_string(), code]; let spawned = if backend == "pipe" { - spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None).await? + spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None, &[]).await? } else { spawn_pty_process( python, @@ -88,6 +88,7 @@ async fn assert_terminate_kills_descendant( env, /*arg0*/ &None, TerminalSize::default(), + &[], ) .await? }; @@ -134,7 +135,7 @@ async fn assert_normal_exit_preserves_descendant( ); let args = vec!["-u".to_string(), "-c".to_string(), code]; let spawned = if backend == "pipe" { - spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None).await? + spawn_pipe_process_no_stdin(python, &args, Path::new("."), env, /*arg0*/ &None, &[]).await? } else { spawn_pty_process( python, @@ -143,6 +144,7 @@ async fn assert_normal_exit_preserves_descendant( env, /*arg0*/ &None, TerminalSize::default(), + &[], ) .await? };