openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-09 15:58:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

codex: address PR review feedback (#17178)

Browse Source 
Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
Ahmed Ibrahim
2026-04-08 19:49:56 -07:00
parent 4b1cc3ba5b
commit 8a1f01313f
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
codex-rs/core/src/realtime_conversation.rs
View File

@@ -619,6 +619,10 @@ fn default_realtime_voice(version: RealtimeWsVersion) -> RealtimeVoice {
}
}
fn realtime_base_url_pins_model(base_url: &str) -> bool {
Url::parse(base_url).is_ok_and(|url| url.query_pairs().any(|(key, _)| key == "model"))
}
fn validate_realtime_voice(version: RealtimeWsVersion, voice: RealtimeVoice) -> CodexResult<()> {
let voices = RealtimeVoicesList::builtin();
let allowed = match version {

10
codex-rs/core/tests/suite/realtime_conversation.rs
View File

@@ -395,7 +395,7 @@ async fn conversation_start_defaults_to_v2_and_gpt_realtime_1_5() -> Result<()>
test.codex
.submit(Op::RealtimeConversationStart(ConversationStartParams {
prompt: "backend prompt".to_string(),
prompt: Some(Some("backend prompt".to_string())),
session_id: None,
transport: None,
}))
@@ -478,7 +478,7 @@ async fn conversation_start_v1_without_model_override_preserves_provider_default
test.codex
.submit(Op::RealtimeConversationStart(ConversationStartParams {
prompt: "backend prompt".to_string(),
prompt: Some(Some("backend prompt".to_string())),
session_id: None,
transport: None,
}))
@@ -564,7 +564,7 @@ async fn conversation_start_v2_with_provider_model_preserves_provider_default()
test.codex
.submit(Op::RealtimeConversationStart(ConversationStartParams {
prompt: "backend prompt".to_string(),
prompt: Some(Some("backend prompt".to_string())),
session_id: None,
transport: None,
}))
@@ -647,7 +647,7 @@ async fn conversation_start_v2_with_base_url_model_preserves_provider_default()
test.codex
.submit(Op::RealtimeConversationStart(ConversationStartParams {
prompt: "backend prompt".to_string(),
prompt: Some(Some("backend prompt".to_string())),
session_id: None,
transport: None,
}))
@@ -881,7 +881,7 @@ async fn conversation_webrtc_start_defaults_to_gpt_realtime_1_5() -> Result<()>
test.codex
.submit(Op::RealtimeConversationStart(ConversationStartParams {
prompt: "backend prompt".to_string(),
prompt: Some(Some("backend prompt".to_string())),
session_id: None,
transport: Some(ConversationStartTransport::Webrtc {
sdp: "v=offer\r\n".to_string(),