From 8a1f01313fa5c674cafc80bd4fc752b0b65a76d7 Mon Sep 17 00:00:00 2001 From: Ahmed Ibrahim Date: Wed, 8 Apr 2026 19:49:56 -0700 Subject: [PATCH] codex: address PR review feedback (#17178) Co-authored-by: Codex --- codex-rs/core/src/realtime_conversation.rs | 4 ++++ codex-rs/core/tests/suite/realtime_conversation.rs | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/codex-rs/core/src/realtime_conversation.rs b/codex-rs/core/src/realtime_conversation.rs index 37a050be3f..32e7b1c8b0 100644 --- a/codex-rs/core/src/realtime_conversation.rs +++ b/codex-rs/core/src/realtime_conversation.rs @@ -619,6 +619,10 @@ fn default_realtime_voice(version: RealtimeWsVersion) -> RealtimeVoice { } } +fn realtime_base_url_pins_model(base_url: &str) -> bool { + Url::parse(base_url).is_ok_and(|url| url.query_pairs().any(|(key, _)| key == "model")) +} + fn validate_realtime_voice(version: RealtimeWsVersion, voice: RealtimeVoice) -> CodexResult<()> { let voices = RealtimeVoicesList::builtin(); let allowed = match version { diff --git a/codex-rs/core/tests/suite/realtime_conversation.rs b/codex-rs/core/tests/suite/realtime_conversation.rs index c70ce3b7a7..3fa3c3a676 100644 --- a/codex-rs/core/tests/suite/realtime_conversation.rs +++ b/codex-rs/core/tests/suite/realtime_conversation.rs @@ -395,7 +395,7 @@ async fn conversation_start_defaults_to_v2_and_gpt_realtime_1_5() -> Result<()> test.codex .submit(Op::RealtimeConversationStart(ConversationStartParams { - prompt: "backend prompt".to_string(), + prompt: Some(Some("backend prompt".to_string())), session_id: None, transport: None, })) @@ -478,7 +478,7 @@ async fn conversation_start_v1_without_model_override_preserves_provider_default test.codex .submit(Op::RealtimeConversationStart(ConversationStartParams { - prompt: "backend prompt".to_string(), + prompt: Some(Some("backend prompt".to_string())), session_id: None, transport: None, })) @@ -564,7 +564,7 @@ async fn conversation_start_v2_with_provider_model_preserves_provider_default() test.codex .submit(Op::RealtimeConversationStart(ConversationStartParams { - prompt: "backend prompt".to_string(), + prompt: Some(Some("backend prompt".to_string())), session_id: None, transport: None, })) @@ -647,7 +647,7 @@ async fn conversation_start_v2_with_base_url_model_preserves_provider_default() test.codex .submit(Op::RealtimeConversationStart(ConversationStartParams { - prompt: "backend prompt".to_string(), + prompt: Some(Some("backend prompt".to_string())), session_id: None, transport: None, })) @@ -881,7 +881,7 @@ async fn conversation_webrtc_start_defaults_to_gpt_realtime_1_5() -> Result<()> test.codex .submit(Op::RealtimeConversationStart(ConversationStartParams { - prompt: "backend prompt".to_string(), + prompt: Some(Some("backend prompt".to_string())), session_id: None, transport: Some(ConversationStartTransport::Webrtc { sdp: "v=offer\r\n".to_string(),