This commit is contained in:
Daniel Edrisian
2025-09-19 20:50:06 -07:00
parent 5d66eb2a1c
commit 4217f624df
2 changed files with 11 additions and 11 deletions
@@ -28,7 +28,7 @@ pub(crate) struct SelectionItem {
pub description: Option<String>,
pub is_current: bool,
pub actions: Vec<SelectionAction>,
pub close_on_select: bool,
pub dimiss_on_select: bool,
pub search_value: Option<String>,
}
@@ -178,7 +178,7 @@ impl ListSelectionView {
for act in &item.actions {
act(&self.app_event_tx);
}
if item.close_on_select {
if item.dimiss_on_select {
self.complete = true;
}
} else {
@@ -424,7 +424,7 @@ mod tests {
description: Some("Codex can read files".to_string()),
is_current: true,
actions: vec![],
close_on_select: true,
dimiss_on_select: true,
search_value: None,
},
SelectionItem {
@@ -432,7 +432,7 @@ mod tests {
description: Some("Codex can edit files".to_string()),
is_current: false,
actions: vec![],
close_on_select: true,
dimiss_on_select: true,
search_value: None,
},
];
@@ -496,7 +496,7 @@ mod tests {
description: Some("Codex can read files".to_string()),
is_current: false,
actions: vec![],
close_on_select: true,
dimiss_on_select: true,
search_value: None,
}];
let mut view = ListSelectionView::new(
+6 -6
View File
@@ -1343,7 +1343,7 @@ impl ChatWidget {
description,
is_current,
actions,
close_on_select: true,
dimiss_on_select: true,
search_value: None,
});
}
@@ -1389,7 +1389,7 @@ impl ChatWidget {
description,
is_current,
actions,
close_on_select: true,
dimiss_on_select: true,
search_value: None,
});
}
@@ -1528,7 +1528,7 @@ impl ChatWidget {
}));
},
)],
close_on_select: true,
dimiss_on_select: true,
search_value: None,
});
@@ -1542,7 +1542,7 @@ impl ChatWidget {
tx.send(AppEvent::OpenReviewBranchPicker(cwd.clone()));
}
})],
close_on_select: false,
dimiss_on_select: false,
search_value: None,
});
@@ -1553,7 +1553,7 @@ impl ChatWidget {
actions: vec![Box::new(move |tx| {
tx.send(AppEvent::OpenReviewCustomPrompt);
})],
close_on_select: false,
dimiss_on_select: false,
search_value: None,
});
@@ -1590,7 +1590,7 @@ impl ChatWidget {
},
}));
})],
close_on_select: true,
dimiss_on_select: true,
search_value: Some(option),
});
}