From 4217f624dffa22820f692ea948081b17a9d6f97c Mon Sep 17 00:00:00 2001 From: Daniel Edrisian Date: Fri, 19 Sep 2025 20:50:06 -0700 Subject: [PATCH] Rename --- codex-rs/tui/src/bottom_pane/list_selection_view.rs | 10 +++++----- codex-rs/tui/src/chatwidget.rs | 12 ++++++------ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/codex-rs/tui/src/bottom_pane/list_selection_view.rs b/codex-rs/tui/src/bottom_pane/list_selection_view.rs index eb1a146fe5..160de768e0 100644 --- a/codex-rs/tui/src/bottom_pane/list_selection_view.rs +++ b/codex-rs/tui/src/bottom_pane/list_selection_view.rs @@ -28,7 +28,7 @@ pub(crate) struct SelectionItem { pub description: Option, pub is_current: bool, pub actions: Vec, - pub close_on_select: bool, + pub dimiss_on_select: bool, pub search_value: Option, } @@ -178,7 +178,7 @@ impl ListSelectionView { for act in &item.actions { act(&self.app_event_tx); } - if item.close_on_select { + if item.dimiss_on_select { self.complete = true; } } else { @@ -424,7 +424,7 @@ mod tests { description: Some("Codex can read files".to_string()), is_current: true, actions: vec![], - close_on_select: true, + dimiss_on_select: true, search_value: None, }, SelectionItem { @@ -432,7 +432,7 @@ mod tests { description: Some("Codex can edit files".to_string()), is_current: false, actions: vec![], - close_on_select: true, + dimiss_on_select: true, search_value: None, }, ]; @@ -496,7 +496,7 @@ mod tests { description: Some("Codex can read files".to_string()), is_current: false, actions: vec![], - close_on_select: true, + dimiss_on_select: true, search_value: None, }]; let mut view = ListSelectionView::new( diff --git a/codex-rs/tui/src/chatwidget.rs b/codex-rs/tui/src/chatwidget.rs index d020e3d43c..01b036bad5 100644 --- a/codex-rs/tui/src/chatwidget.rs +++ b/codex-rs/tui/src/chatwidget.rs @@ -1343,7 +1343,7 @@ impl ChatWidget { description, is_current, actions, - close_on_select: true, + dimiss_on_select: true, search_value: None, }); } @@ -1389,7 +1389,7 @@ impl ChatWidget { description, is_current, actions, - close_on_select: true, + dimiss_on_select: true, search_value: None, }); } @@ -1528,7 +1528,7 @@ impl ChatWidget { })); }, )], - close_on_select: true, + dimiss_on_select: true, search_value: None, }); @@ -1542,7 +1542,7 @@ impl ChatWidget { tx.send(AppEvent::OpenReviewBranchPicker(cwd.clone())); } })], - close_on_select: false, + dimiss_on_select: false, search_value: None, }); @@ -1553,7 +1553,7 @@ impl ChatWidget { actions: vec![Box::new(move |tx| { tx.send(AppEvent::OpenReviewCustomPrompt); })], - close_on_select: false, + dimiss_on_select: false, search_value: None, }); @@ -1590,7 +1590,7 @@ impl ChatWidget { }, })); })], - close_on_select: true, + dimiss_on_select: true, search_value: Some(option), }); }