openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-09 15:58:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

codex: address PR review feedback (#17178)

Browse Source 
Co-authored-by: Codex <noreply@openai.com>
This commit is contained in:
Ahmed Ibrahim
2026-04-08 20:46:37 -07:00
parent 73da395dd1
commit 3aaaed3c48
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
codex-rs/core/src/realtime_conversation.rs
View File

@@ -647,9 +647,7 @@ fn validate_realtime_voice(version: RealtimeWsVersion, voice: RealtimeVoice) ->
voice.wire_name()
)))
}
fn realtime_base_url_pins_model(base_url: &str) -> bool {
Url::parse(base_url).is_ok_and(|url| url.query_pairs().any(|(key, _)| key == "model"))
}
async fn handle_start_inner(
sess: &Arc<Session>,
sub_id: &str,

5
codex-rs/core/tests/suite/realtime_conversation.rs
View File

@@ -432,6 +432,7 @@ async fn conversation_start_defaults_to_v2_and_gpt_realtime_1_5() -> Result<()>
session_id: started.session_id.clone(),
event_parser: RealtimeEventParser::RealtimeV2,
session_mode: RealtimeSessionMode::Conversational,
voice: RealtimeVoice::Marin,
})?
});
assert_eq!(connections[1][0].body_json(), expected_session_update);
@@ -515,6 +516,7 @@ async fn conversation_start_v1_without_model_override_preserves_provider_default
session_id: started.session_id.clone(),
event_parser: RealtimeEventParser::V1,
session_mode: RealtimeSessionMode::Conversational,
voice: RealtimeVoice::Cove,
})?
});
assert_eq!(connections[1][0].body_json(), expected_session_update);
@@ -601,6 +603,7 @@ async fn conversation_start_v2_with_provider_model_preserves_provider_default()
session_id: started.session_id.clone(),
event_parser: RealtimeEventParser::RealtimeV2,
session_mode: RealtimeSessionMode::Conversational,
voice: RealtimeVoice::Marin,
})?
});
assert_eq!(connections[1][0].body_json(), expected_session_update);
@@ -684,6 +687,7 @@ async fn conversation_start_v2_with_base_url_model_preserves_provider_default()
session_id: started.session_id.clone(),
event_parser: RealtimeEventParser::RealtimeV2,
session_mode: RealtimeSessionMode::Conversational,
voice: RealtimeVoice::Marin,
})?
});
assert_eq!(connections[1][0].body_json(), expected_session_update);
@@ -913,6 +917,7 @@ async fn conversation_webrtc_start_defaults_to_gpt_realtime_1_5() -> Result<()>
session_id: Some("ignored".to_string()),
event_parser: RealtimeEventParser::RealtimeV2,
session_mode: RealtimeSessionMode::Conversational,
voice: RealtimeVoice::Marin,
})?;
session
.as_object_mut()