From 3aaaed3c48286ad393f4a2887d0b63ae1fa99b8d Mon Sep 17 00:00:00 2001 From: Ahmed Ibrahim Date: Wed, 8 Apr 2026 20:46:37 -0700 Subject: [PATCH] codex: address PR review feedback (#17178) Co-authored-by: Codex --- codex-rs/core/src/realtime_conversation.rs | 4 +--- codex-rs/core/tests/suite/realtime_conversation.rs | 5 +++++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/codex-rs/core/src/realtime_conversation.rs b/codex-rs/core/src/realtime_conversation.rs index 32e7b1c8b0..c4308b6157 100644 --- a/codex-rs/core/src/realtime_conversation.rs +++ b/codex-rs/core/src/realtime_conversation.rs @@ -647,9 +647,7 @@ fn validate_realtime_voice(version: RealtimeWsVersion, voice: RealtimeVoice) -> voice.wire_name() ))) } -fn realtime_base_url_pins_model(base_url: &str) -> bool { - Url::parse(base_url).is_ok_and(|url| url.query_pairs().any(|(key, _)| key == "model")) -} + async fn handle_start_inner( sess: &Arc, sub_id: &str, diff --git a/codex-rs/core/tests/suite/realtime_conversation.rs b/codex-rs/core/tests/suite/realtime_conversation.rs index cd69ccc331..f21369541d 100644 --- a/codex-rs/core/tests/suite/realtime_conversation.rs +++ b/codex-rs/core/tests/suite/realtime_conversation.rs @@ -432,6 +432,7 @@ async fn conversation_start_defaults_to_v2_and_gpt_realtime_1_5() -> Result<()> session_id: started.session_id.clone(), event_parser: RealtimeEventParser::RealtimeV2, session_mode: RealtimeSessionMode::Conversational, + voice: RealtimeVoice::Marin, })? }); assert_eq!(connections[1][0].body_json(), expected_session_update); @@ -515,6 +516,7 @@ async fn conversation_start_v1_without_model_override_preserves_provider_default session_id: started.session_id.clone(), event_parser: RealtimeEventParser::V1, session_mode: RealtimeSessionMode::Conversational, + voice: RealtimeVoice::Cove, })? }); assert_eq!(connections[1][0].body_json(), expected_session_update); @@ -601,6 +603,7 @@ async fn conversation_start_v2_with_provider_model_preserves_provider_default() session_id: started.session_id.clone(), event_parser: RealtimeEventParser::RealtimeV2, session_mode: RealtimeSessionMode::Conversational, + voice: RealtimeVoice::Marin, })? }); assert_eq!(connections[1][0].body_json(), expected_session_update); @@ -684,6 +687,7 @@ async fn conversation_start_v2_with_base_url_model_preserves_provider_default() session_id: started.session_id.clone(), event_parser: RealtimeEventParser::RealtimeV2, session_mode: RealtimeSessionMode::Conversational, + voice: RealtimeVoice::Marin, })? }); assert_eq!(connections[1][0].body_json(), expected_session_update); @@ -913,6 +917,7 @@ async fn conversation_webrtc_start_defaults_to_gpt_realtime_1_5() -> Result<()> session_id: Some("ignored".to_string()), event_parser: RealtimeEventParser::RealtimeV2, session_mode: RealtimeSessionMode::Conversational, + voice: RealtimeVoice::Marin, })?; session .as_object_mut()