mirror of
https://github.com/openai/codex.git
synced 2026-11-16 22:00:36 +00:00
avoid cloning server response payloads
This commit is contained in:
@@ -689,12 +689,13 @@ macro_rules! server_request_definitions {
|
||||
|
||||
pub fn response_from_result(
|
||||
&self,
|
||||
result: crate::Result,
|
||||
result: &crate::Result,
|
||||
) -> serde_json::Result<ServerResponse> {
|
||||
match self {
|
||||
$(
|
||||
Self::$variant { request_id, .. } => {
|
||||
let response = serde_json::from_value::<$response>(result)?;
|
||||
let response =
|
||||
<$response as serde::Deserialize>::deserialize(result)?;
|
||||
Ok(ServerResponse::$variant {
|
||||
request_id: request_id.clone(),
|
||||
response,
|
||||
|
||||
@@ -409,7 +409,7 @@ impl OutgoingMessageSender {
|
||||
self.analytics_events_client
|
||||
.track_server_request(connection_id.0, entry.request.clone());
|
||||
}
|
||||
if let Ok(response) = entry.request.response_from_result(result.clone()) {
|
||||
if let Ok(response) = entry.request.response_from_result(&result) {
|
||||
self.analytics_events_client
|
||||
.track_server_response(connection_id.0, response);
|
||||
}
|
||||
@@ -939,7 +939,7 @@ mod tests {
|
||||
};
|
||||
|
||||
let response = request
|
||||
.response_from_result(json!({
|
||||
.response_from_result(&json!({
|
||||
"decision": "acceptForSession",
|
||||
}))
|
||||
.expect("decode typed server response");
|
||||
|
||||
Reference in New Issue
Block a user