From 34733b87234f6248f27048eb5b96927ee96dc82c Mon Sep 17 00:00:00 2001 From: Roy Han Date: Thu, 23 Apr 2026 17:03:26 -0400 Subject: [PATCH] avoid cloning server response payloads --- codex-rs/app-server-protocol/src/protocol/common.rs | 5 +++-- codex-rs/app-server/src/outgoing_message.rs | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/codex-rs/app-server-protocol/src/protocol/common.rs b/codex-rs/app-server-protocol/src/protocol/common.rs index 1fc8646fb4..d55aa79ed1 100644 --- a/codex-rs/app-server-protocol/src/protocol/common.rs +++ b/codex-rs/app-server-protocol/src/protocol/common.rs @@ -689,12 +689,13 @@ macro_rules! server_request_definitions { pub fn response_from_result( &self, - result: crate::Result, + result: &crate::Result, ) -> serde_json::Result { match self { $( Self::$variant { request_id, .. } => { - let response = serde_json::from_value::<$response>(result)?; + let response = + <$response as serde::Deserialize>::deserialize(result)?; Ok(ServerResponse::$variant { request_id: request_id.clone(), response, diff --git a/codex-rs/app-server/src/outgoing_message.rs b/codex-rs/app-server/src/outgoing_message.rs index 3f1d4f78e4..4b14a2a6c2 100644 --- a/codex-rs/app-server/src/outgoing_message.rs +++ b/codex-rs/app-server/src/outgoing_message.rs @@ -409,7 +409,7 @@ impl OutgoingMessageSender { self.analytics_events_client .track_server_request(connection_id.0, entry.request.clone()); } - if let Ok(response) = entry.request.response_from_result(result.clone()) { + if let Ok(response) = entry.request.response_from_result(&result) { self.analytics_events_client .track_server_response(connection_id.0, response); } @@ -939,7 +939,7 @@ mod tests { }; let response = request - .response_from_result(json!({ + .response_from_result(&json!({ "decision": "acceptForSession", })) .expect("decode typed server response");