Show logger.debug in NODE_ENV=test (#88)

This commit is contained in:
Jaco Greeff
2018-02-14 09:19:14 +01:00
committed by GitHub
parent 36827add3c
commit 037da5a666
2 changed files with 27 additions and 3 deletions
+3 -3
View File
@@ -27,10 +27,10 @@ module.exports = function logger (_type: string): Logger {
let isDebug;
try {
// $FlowFixMe this can fail (undefined/null) - hence the try/catch
const debugList = process.env.DEBUG.split(',');
const isTest = process.env.NODE_ENV === 'test';
const debugList = (process.env.DEBUG || '').split(',');
isDebug = !!debugList.find((entry) => _type.indexOf(entry) === 0);
isDebug = isTest || !!debugList.find((entry) => _type.indexOf(entry) === 0);
} catch (error) {
isDebug = false;
}
+24
View File
@@ -10,8 +10,12 @@ describe('logger', () => {
let l;
let ln;
let spy;
let oldEnv;
beforeEach(() => {
oldEnv = process.env;
process.env.NODE_ENV = 'development';
ln = logger('notDebug');
process.env.DEBUG = 'test';
@@ -30,6 +34,7 @@ describe('logger', () => {
});
afterEach(() => {
process.env = oldEnv;
jest.restoreAllMocks();
});
@@ -105,6 +110,25 @@ describe('logger', () => {
expect(spy.log).not.toHaveBeenCalled();
});
it('does debug log when NODE_ENV=test specified', () => {
process.env.DEBUG = 'blah';
process.env.NODE_ENV = 'test';
l = logger('test');
l.debug('test');
expect(spy.log).toHaveBeenCalled();
});
it('does not debug log when no process.env', () => {
process.env = void 0;
l = logger('test');
l.debug('test');
expect(spy.log).not.toHaveBeenCalled();
});
it('does not debug log when no DEBUG specified', () => {
ln.debug('test');