mirror of
https://github.com/openai/codex.git
synced 2026-11-15 21:50:46 +00:00
## Why `thread/list` can filter direct children with `parentThreadId`, but clients cannot request an entire spawned subtree. Discovering every descendant requires repeated client-side requests and gives up the database's existing filtering and pagination path. ## What changed Experimental clients can use `ancestorThreadId` to return strict descendants at any depth while `parentThreadId` retains its direct-child meaning. The filters are mutually exclusive, the ancestor is excluded, and every result preserves its immediate `parentThreadId` so callers can reconstruct the tree. ## How it works - **Explicit relationship:** Internal list parameters distinguish direct children from transitive descendants without changing the meaning of `parentThreadId`. - **Existing graph:** Persisted parent-child spawn edges remain the source of truth, so descendant lookup needs no schema migration or ancestry cache. - **Indexed traversal:** A recursive SQLite query starts from the parent-edge index, walks each generation, and applies thread filters, sorting, and cursor pagination in the same database request. - **Reconstructable results:** The response stays flat and normally ordered while carrying each descendant's immediate parent. ## Verification Ran 550 tests across the protocol, state, rollout, and thread-store crates, then reran the four focused state, store, and app-server descendant-listing tests after the final diff reduction. Scoped Clippy and formatting checks passed. Stable and experimental schema generation was checked; the stable fixtures remain unchanged while the experimental schema includes the new field.
114 lines
4.2 KiB
Rust
114 lines
4.2 KiB
Rust
//! SQLite-backed state for rollout metadata.
|
|
//!
|
|
//! This crate is intentionally small and focused: it extracts rollout metadata
|
|
//! from JSONL rollouts and mirrors it into a local SQLite database. Backfill
|
|
//! orchestration and rollout scanning live in `codex-core`.
|
|
|
|
const _: () = assert!(
|
|
libsqlite3_sys::SQLITE_VERSION_NUMBER >= 3_051_003,
|
|
"bundled SQLite must include the WAL-reset corruption fix",
|
|
);
|
|
|
|
mod audit;
|
|
mod extract;
|
|
pub mod log_db;
|
|
mod migrations;
|
|
mod model;
|
|
mod paths;
|
|
mod runtime;
|
|
mod telemetry;
|
|
|
|
pub use model::LogEntry;
|
|
pub use model::LogQuery;
|
|
pub use model::LogRow;
|
|
pub use model::Phase2JobClaimOutcome;
|
|
/// Preferred entrypoint: owns configuration and metrics.
|
|
pub use runtime::StateRuntime;
|
|
|
|
pub use audit::ThreadStateAuditRow;
|
|
pub use audit::read_thread_state_audit_rows;
|
|
/// Low-level storage engine: useful for focused tests.
|
|
///
|
|
/// Most consumers should prefer [`StateRuntime`].
|
|
pub use extract::apply_rollout_item;
|
|
pub use extract::rollout_item_affects_thread_metadata;
|
|
pub use model::AgentJob;
|
|
pub use model::AgentJobCreateParams;
|
|
pub use model::AgentJobItem;
|
|
pub use model::AgentJobItemCreateParams;
|
|
pub use model::AgentJobItemStatus;
|
|
pub use model::AgentJobProgress;
|
|
pub use model::AgentJobStatus;
|
|
pub use model::Anchor;
|
|
pub use model::BackfillState;
|
|
pub use model::BackfillStats;
|
|
pub use model::BackfillStatus;
|
|
pub use model::DirectionalThreadSpawnEdgeStatus;
|
|
pub use model::ExtractionOutcome;
|
|
pub use model::SortDirection;
|
|
pub use model::SortKey;
|
|
pub use model::Stage1JobClaim;
|
|
pub use model::Stage1JobClaimOutcome;
|
|
pub use model::Stage1Output;
|
|
pub use model::Stage1StartupClaimParams;
|
|
pub use model::ThreadGoal;
|
|
pub use model::ThreadGoalStatus;
|
|
pub use model::ThreadMetadata;
|
|
pub use model::ThreadMetadataBuilder;
|
|
pub use model::ThreadRelationFilter;
|
|
pub use model::ThreadsPage;
|
|
pub use runtime::ExternalAgentConfigImportDetailsRecord;
|
|
pub use runtime::ExternalAgentConfigImportFailureRecord;
|
|
pub use runtime::ExternalAgentConfigImportHistoryRecord;
|
|
pub use runtime::ExternalAgentConfigImportSuccessRecord;
|
|
pub use runtime::GoalAccountingMode;
|
|
pub use runtime::GoalAccountingOutcome;
|
|
pub use runtime::GoalStore;
|
|
pub use runtime::GoalUpdate;
|
|
pub use runtime::MemoryStore;
|
|
pub use runtime::RemoteControlEnrollmentRecord;
|
|
pub use runtime::RuntimeDbBackup;
|
|
pub use runtime::RuntimeDbPath;
|
|
pub use runtime::ThreadFilterOptions;
|
|
pub use runtime::backup_runtime_db_for_fresh_start;
|
|
pub use runtime::goals_db_filename;
|
|
pub use runtime::goals_db_path;
|
|
pub use runtime::is_sqlite_corruption_error;
|
|
pub use runtime::logs_db_filename;
|
|
pub use runtime::logs_db_path;
|
|
pub use runtime::memories_db_filename;
|
|
pub use runtime::memories_db_path;
|
|
pub use runtime::runtime_db_path_for_corruption_error;
|
|
pub use runtime::runtime_db_paths;
|
|
pub use runtime::sqlite_error_detail_is_corruption;
|
|
pub use runtime::sqlite_error_detail_is_lock;
|
|
pub use runtime::sqlite_integrity_check;
|
|
pub use runtime::state_db_filename;
|
|
pub use runtime::state_db_path;
|
|
pub use telemetry::DbTelemetry;
|
|
pub use telemetry::DbTelemetryHandle;
|
|
pub use telemetry::install_process_db_telemetry;
|
|
pub use telemetry::record_backfill_gate;
|
|
pub use telemetry::record_fallback;
|
|
|
|
/// Environment variable for overriding the SQLite state database home directory.
|
|
pub const SQLITE_HOME_ENV: &str = "CODEX_SQLITE_HOME";
|
|
|
|
pub const LOGS_DB_FILENAME: &str = "logs_2.sqlite";
|
|
pub const GOALS_DB_FILENAME: &str = "goals_1.sqlite";
|
|
pub const MEMORIES_DB_FILENAME: &str = "memories_1.sqlite";
|
|
pub const STATE_DB_FILENAME: &str = "state_5.sqlite";
|
|
|
|
/// Errors encountered during DB operations. Tags: [stage]
|
|
pub const DB_ERROR_METRIC: &str = "codex.db.error";
|
|
/// Metrics on backfill process. Tags: [status]
|
|
pub const DB_METRIC_BACKFILL: &str = "codex.db.backfill";
|
|
/// Metrics on backfill duration. Tags: [status]
|
|
pub const DB_METRIC_BACKFILL_DURATION_MS: &str = "codex.db.backfill.duration_ms";
|
|
/// SQLite initialization attempts. Tags: [status, phase, db, error]
|
|
pub const DB_INIT_METRIC: &str = "codex.sqlite.init.count";
|
|
/// SQLite initialization latency. Tags: [status, phase, db, error]
|
|
pub const DB_INIT_DURATION_METRIC: &str = "codex.sqlite.init.duration_ms";
|
|
/// Rollout fallback attempts. Tags: [caller, reason]
|
|
pub const DB_FALLBACK_METRIC: &str = "codex.sqlite.fallback.count";
|