Files
codex/codex-rs/app-server-client/src/cloud_backend/thread_title_tests.rs
T
Benjamin Carlsson b016cd1847 Enable automatic titles for Cloud conversations (#61600)
## Why

Cloud conversations previously skipped TUI title generation, leaving them without automatically saved names.

## What changed

- Generate structured titles using the selected Cloud account and its backend routing, without agent tools or a temporary conversation.
- Read and save names outside the conversation command queue without replacing the active attachment. Preserve an existing name if it no longer matches the expected value.
- Fall back to the first-message title when generation is unavailable, and allow up to three seconds for pending saves during shutdown.
- Report a retryable error when a manual rename encounters an automatic save in progress, keeping the UI responsive.

## Testing

Add coverage for selected-account title generation, saved-name reads without attachment, first-message fallback persistence, and manual rename retries after automatic saves.

GitOrigin-RevId: 48030cc0b75e790a2004af018f54e5751665b760
2026-11-15 03:17:50 +00:00

103 lines
4.0 KiB
Rust

#![cfg(test)]
use super::CloudTitleClient;
use codex_http_client::HttpClientFactory;
use codex_http_client::OutboundProxyPolicy;
use codex_model_provider::BearerAuthProvider;
use codex_protocol::openai_models::ReasoningEffort;
use pretty_assertions::assert_eq;
use serde_json::json;
use std::sync::Arc;
use wiremock::Mock;
use wiremock::MockServer;
use wiremock::ResponseTemplate;
use wiremock::matchers::body_json;
use wiremock::matchers::header;
use wiremock::matchers::method;
use wiremock::matchers::path;
#[tokio::test]
async fn generates_a_structured_title_using_the_selected_cloud_account() -> color_eyre::Result<()> {
let server = MockServer::start().await;
// Inject an already validated bootstrap so the test can use a loopback server.
let client = CloudTitleClient {
factory: HttpClientFactory::new(OutboundProxyPolicy::ReqwestDefault),
auth: Arc::new(BearerAuthProvider::for_test(
Some("token"),
Some("cloud-account"),
)),
account_id: "cloud-account".to_owned(),
bootstrap: format!("{}/backend-api", server.uri()).parse()?,
require_origin_match: false,
};
Mock::given(method("GET"))
.and(path("/backend-api/wham/accounts/check"))
.and(header("authorization", "Bearer token"))
.and(header("chatgpt-account-id", "cloud-account"))
.respond_with(ResponseTemplate::new(200).set_body_json(json!({"accounts": [
{"id": "other-account", "workspace_backend_origin": "https://other.chatgpt.com", "account_routing_override": "us"},
{"id": "cloud-account", "workspace_backend_origin": "NO_CONSTRAINT", "account_routing_override": "us_cr"}
]})))
.expect(1)
.mount(&server)
.await;
let schema = json!({
"type": "object",
"properties": {"title": {"type": "string"}},
"required": ["title"],
"additionalProperties": false,
});
let title = r#"{"title":"Login timeout"}"#;
let sse = [
json!({"type": "response.output_item.done", "item": {
"type": "message", "role": "assistant", "phase": "commentary",
"content": [{"type": "output_text", "text": "Considering a title"}]
}}),
json!({"type": "response.output_item.done", "item": {
"type": "message", "role": "assistant", "phase": "final_answer",
"content": [{"type": "output_text", "text": title}]
}}),
json!({"type": "response.completed", "response": {"id": "response-1"}}),
]
.into_iter()
.map(|event| format!("data: {event}\n\n"))
.collect::<String>();
Mock::given(method("POST"))
.and(path("/backend-api/codex/responses"))
.and(header("authorization", "Bearer token"))
.and(header("chatgpt-account-id", "cloud-account"))
.and(header("x-openai-account-routing-override", "us_cr"))
.and(body_json(json!({
"model": "title-model",
"instructions": "Generate a thread title from the user prompt.",
"input": [{"type": "message", "role": "user", "content": [{"type": "input_text", "text": "Fix the login timeout"}]}],
"store": false,
"stream": true,
"tools": [],
"tool_choice": "none",
"parallel_tool_calls": false,
"include": [],
"client_metadata": {"x-codex-turn-metadata": r#"{"thread_source":"thread_title"}"#},
"text": {"format": {"type": "json_schema", "strict": true, "schema": schema, "name": "codex_output_schema"}},
"reasoning": {"effort": "low"},
})))
.respond_with(ResponseTemplate::new(200).set_body_raw(sse, "text/event-stream"))
.expect(1)
.mount(&server)
.await;
assert_eq!(
client
.generate(
"title-model",
Some(ReasoningEffort::Low),
"Fix the login timeout".to_owned(),
schema,
)
.await?,
title
);
Ok(())
}