codex

mirror of https://github.com/openai/codex.git synced 2026-10-30 19:18:49 +00:00

Files

T

swastik-oai a4b4082b5f Apply PreToolUse hooks before direct Guardian review policy checks (#58368 )

## Why

Direct Guardian review checked recorded `exec_command` calls without applying `PreToolUse` hooks, so approval decisions could miss hook rewrites or denials.

## What changed

Run the shared `PreToolUse` hook handling before evaluating approval requirements. Use the rewritten arguments for policy checks and the Guardian approval request, and return an error when a hook blocks the call, even if policy would otherwise skip review.

## Testing

Add regression tests covering rewritten commands that require approval and hook denials for policy-allowed commands. Verify the rewritten approval request, hook events and recorded denial context, and that reviewed commands are not executed.

GitOrigin-RevId: 3ec7700f695e422ac59c903c285acc0cf633b915

2026-10-30 15:28:20 +00:00

agent

Preserve model metadata origin through runtime resolution (#58361 )

2026-10-30 15:11:02 +00:00

apps

Support typed content in contextual prompt fragments (#54776 )

2026-10-17 04:02:21 +00:00

config

Allow Apps catalog discovery before the initial tool inventory completes (#58352 )

2026-10-30 14:47:56 +00:00

context

Preserve realtime V3 transcripts in conversation history (#58221 )

2026-10-30 02:43:02 +00:00

context_manager

Preserve reasoning token accounting across resume and fork (#57839 )

2026-10-28 21:22:06 +00:00

exec_policy

Avoid false URL-launch detections in literal PowerShell commands (#54076 )

2026-10-14 19:47:50 +00:00

guardian

Apply PreToolUse hooks before direct Guardian review policy checks (#58368 )

2026-10-30 15:28:20 +00:00

hook_runtime

Enable executor cleanup hooks with V2 capability discovery (#56044 )

2026-10-22 01:42:11 +00:00

mcp_tool_call

Preserve specific MCP failure codes in metrics and spans (#54094 )

2026-10-14 20:53:59 +00:00

plugins

Add opt-in concise hints for explicitly selected plugins (#57317 )

2026-10-27 00:52:31 +00:00

realtime_conversation

Preserve realtime V3 transcripts in conversation history (#58221 )

2026-10-30 02:43:02 +00:00

realtime_history

…

sandboxing

Run sandbox integrity checks before commands and filesystem operations (#51843 )

2026-10-07 21:52:43 +00:00

session

Preserve model metadata origin through runtime resolution (#58361 )

2026-10-30 15:11:02 +00:00

state

Resolve network approval prompts when their requests end (#58350 )

2026-10-30 14:40:32 +00:00

tasks

Preserve reasoning token accounting across resume and fork (#57839 )

2026-10-28 21:22:06 +00:00

thread_manager

Distinguish retryable thread-store errors from unknown write outcomes (#54664 )

2026-10-16 17:31:47 +00:00

tools

Apply PreToolUse hooks before direct Guardian review policy checks (#58368 )

2026-10-30 15:28:20 +00:00

turn_timing

Report turn critical-path timing in analytics (#57209 )

2026-10-26 19:35:31 +00:00

unified_exec

Preserve model metadata origin through runtime resolution (#58361 )

2026-10-30 15:11:02 +00:00

utils

…

agent_communication.rs

Refactor agent spawning, startup, and communication helpers (#57278 )

2026-10-26 21:48:19 +00:00

agent_message_board.rs

Add storage namespaces for local message boards (#55971 )

2026-10-21 19:36:20 +00:00

agents_md_manager.rs

Roll back stale Guardian reviews before reusing reviewer history (#51683 )

2026-10-07 13:05:06 +00:00

agents_md_tests.rs

Add hook configuration to environment attachments (#56302 )

2026-10-23 00:02:29 +00:00

agents_md.rs

Reject paths in project documentation fallback filenames (#45865 )

2026-09-16 04:59:23 +00:00

apply_patch_tests.rs

Separate apply_patch request preparation from execution (#57261 )

2026-10-26 21:15:23 +00:00

apply_patch.rs

Separate apply_patch request preparation from execution (#57261 )

2026-10-26 21:15:23 +00:00

attestation.rs

…

client_common_tests.rs

Add opt-in output token replay for OpenAI requests (#52742 )

2026-10-10 01:25:00 +00:00

client_common.rs

Preserve parent routing affinity for Guardian reviews (#57710 )

2026-10-28 11:48:00 +00:00

client_runtime_auth_tests.rs

Preserve parent routing affinity for Guardian reviews (#57710 )

2026-10-28 11:48:00 +00:00

client_tests.rs

Preserve native tool-call evidence through Guardian review (#58040 )

2026-10-29 11:15:52 +00:00

client_tool_metadata_tests.rs

Send base instructions as Responses input messages (#51156 )

2026-10-05 18:52:51 +00:00

client_tool_metadata.rs

Bound tool-call observations to the outgoing Responses message budget (#47957 )

2026-09-24 22:54:29 +00:00

client.rs

Centralize provider request preparation auth checks (#58121 )

2026-10-29 16:39:38 +00:00

code_mode_host_lifecycle_tests.rs

Add optional process metrics sampling for code-mode hosts (#57841 )

2026-10-28 21:34:25 +00:00

code_mode_host_tests.rs

Add optional process metrics sampling for code-mode hosts (#57841 )

2026-10-28 21:34:25 +00:00

code_mode_host.rs

Add a feature flag for code-mode host output truncation (#58159 )

2026-10-29 19:29:05 +00:00

codex_delegate_tests.rs

Refactor agent spawning, startup, and communication helpers (#57278 )

2026-10-26 21:48:19 +00:00

codex_delegate.rs

Add experimental attached thread forks (#56351 )

2026-10-23 04:52:47 +00:00

codex_thread.rs

Add direct Guardian review of recorded exec calls (#58028 )

2026-10-29 09:48:55 +00:00

command_canonicalization_tests.rs

…

command_canonicalization.rs

…

compact_model_fallback.rs

Treat incomplete responses as terminal errors (#53451 )

2026-10-12 18:53:49 +00:00

compact_remote_history_tests.rs

…

compact_remote_history.rs

Prepare compaction helpers for background requests (#53606 )

2026-10-13 08:13:34 +00:00

compact_remote_v2_attempt.rs

Preserve model metadata origin through runtime resolution (#58361 )

2026-10-30 15:11:02 +00:00

compact_remote_v2_image_budget_tests.rs

Add opt-in output token replay for OpenAI requests (#52742 )

2026-10-10 01:25:00 +00:00

compact_remote_v2_images.rs

Add opt-in output token replay for OpenAI requests (#52742 )

2026-10-10 01:25:00 +00:00

compact_remote_v2_installation_tests.rs

Wire background compaction into the turn lifecycle (#53800 )

2026-10-13 23:51:47 +00:00

compact_remote_v2_installation.rs

Wire background compaction into the turn lifecycle (#53800 )

2026-10-13 23:51:47 +00:00

compact_remote_v2.rs

Preserve parent routing affinity for Guardian reviews (#57710 )

2026-10-28 11:48:00 +00:00

compact_retained_tool_outputs.rs

Retain client-marked tool outputs across compaction (#52937 )

2026-10-10 17:30:25 +00:00

compact_tests.rs

Preserve native tool-call evidence through Guardian review (#58040 )

2026-10-29 11:15:52 +00:00

compact_token_budget.rs

Install full context in compaction replacement history (#51117 )

2026-10-05 16:10:27 +00:00

compact.rs

Preserve reasoning token accounting across resume and fork (#57839 )

2026-10-28 21:22:06 +00:00

connectors_tests.rs

…

connectors.rs

Avoid unnecessary connector directory work for tool suggestions (#57257 )

2026-10-26 21:08:15 +00:00

current_time.rs

…

cyber_access_program.rs

Allow providers to opt into Cyber access programs (#58190 )

2026-10-29 23:24:52 +00:00

elicitation_tests.rs

…

elicitation.rs

…

environment_connection_tests.rs

Defer environment disconnect notifications until recovery fails (#55401 )

2026-10-19 22:55:42 +00:00

environment_selection_snapshot_tests.rs

Add configured thread environment inheritance for subagents (#55375 )

2026-10-19 20:30:44 +00:00

environment_selection.rs

Retry transient environment startup failures on the next turn (#57866 )

2026-10-29 00:42:21 +00:00

event_mapping_tests.rs

Support catalog headings for saved command-prefix notices (#57599 )

2026-10-27 23:53:34 +00:00

event_mapping.rs

Support catalog headings for saved command-prefix notices (#57599 )

2026-10-27 23:53:34 +00:00

exec_env_tests.rs

Make apply_patch preserve line endings unconditionally (#51203 )

2026-10-05 23:52:06 +00:00

exec_env.rs

Expose originating tool call metadata in command environments (#52119 )

2026-10-08 13:45:19 +00:00

exec_policy_tests.rs

Add managed command checkpoints requiring fresh human approval (#58045 )

2026-10-29 11:23:51 +00:00

exec_policy_windows_tests.rs

Avoid false URL-launch detections in literal PowerShell commands (#54076 )

2026-10-14 19:47:50 +00:00

exec_policy.rs

Add managed command checkpoints requiring fresh human approval (#58045 )

2026-10-29 11:23:51 +00:00

exec_tests.rs

Stabilize cancellation and tracing tests (#58171 )

2026-10-29 20:39:04 +00:00

exec.rs

Run sandbox integrity checks before commands and filesystem operations (#51843 )

2026-10-07 21:52:43 +00:00

feedback_config_tests.rs

Add configuration and feature diagnostics to report metadata (#46501 )

2026-09-18 23:07:36 +00:00

feedback_config.rs

Add configuration and feature diagnostics to report metadata (#46501 )

2026-09-18 23:07:36 +00:00

function_tool.rs

Complete dynamic tool lifecycles on cancellation (#51556 )

2026-10-07 03:07:51 +00:00

git_info_tests.rs

Use descriptor-safe helpers for executable test fixtures (#50018 )

2026-10-01 15:57:03 +00:00

guardian_review.rs

Add direct Guardian review of recorded exec calls (#58028 )

2026-10-29 09:48:55 +00:00

hook_environment_executor.rs

Run environment hooks on their owning executors (#56343 )

2026-10-23 04:01:39 +00:00

hook_mcp_executor.rs

Start dormant MCP servers for hook calls (#55263 )

2026-10-19 11:40:15 +00:00

hook_runtime.rs

Release sampling prompts after stream setup (#57618 )

2026-10-28 02:00:30 +00:00

image_preparation_tests.rs

Replace unavailable image references in model requests (#57585 )

2026-10-27 22:59:22 +00:00

image_preparation.rs

Replace unavailable image references in model requests (#57585 )

2026-10-27 22:59:22 +00:00

installation_id.rs

…

lib.rs

Use serving assessments for adaptive Guardian review (#58075 )

2026-10-29 12:54:39 +00:00

mcp_openai_file.rs

Bind permission grants to the originating turn (#49880 )

2026-10-01 05:33:36 +00:00

mcp_skill_dependencies.rs

Add configurable default plugin activation policy (#52220 )

2026-10-08 18:42:58 +00:00

mcp_tool_approval_templates.rs

…

mcp_tool_call_tests.rs

Include tool names and annotation hints in MCP approval metadata (#58161 )

2026-10-29 19:34:46 +00:00

mcp_tool_call.rs

Include tool names and annotation hints in MCP approval metadata (#58161 )

2026-10-29 19:34:46 +00:00

mcp_tool_exposure_test.rs

Share prepared MCP tool definitions across sessions (#55724 )

2026-10-21 01:55:56 +00:00

mcp_tool_exposure.rs

Share prepared MCP tool definitions across sessions (#55724 )

2026-10-21 01:55:56 +00:00

mcp.rs

Share eligible local stdio MCP connections across chats (#57211 )

2026-10-26 19:37:32 +00:00

memory_usage.rs

Tag memory usage telemetry with the memory version (#45960 )

2026-09-16 15:17:41 +00:00

mention_syntax.rs

…

model_request_tests.rs

Preserve parent routing affinity for Guardian reviews (#57710 )

2026-10-28 11:48:00 +00:00

model_request.rs

Add extension hooks for model requests and response streams (#47679 )

2026-09-23 22:10:04 +00:00

network_policy_decision_tests.rs

…

network_policy_decision.rs

…

original_image_detail.rs

…

otel_init.rs

Redact OTEL exporter headers in app-server config responses (#57654 )

2026-10-28 05:46:04 +00:00

prompt_debug.rs

Replace unavailable image references in model requests (#57585 )

2026-10-27 22:59:22 +00:00

realtime_context_tests.rs

Add opt-in output token replay for OpenAI requests (#52742 )

2026-10-10 01:25:00 +00:00

realtime_context.rs

…

realtime_conversation_tests.rs

Preserve realtime V3 transcripts in conversation history (#58221 )

2026-10-30 02:43:02 +00:00

realtime_conversation.rs

Preserve realtime V3 transcripts in conversation history (#58221 )

2026-10-30 02:43:02 +00:00

realtime_history_tests.rs

Record resolved model and reasoning effort in sub-agent activity (#51463 )

2026-10-06 19:29:40 +00:00

realtime_history.rs

…

realtime_prompt.rs

…

responses_headers.rs

Preserve Guardian request metadata with custom OpenAI base URLs (#57439 )

2026-10-27 12:17:14 +00:00

responses_metadata.rs

Preserve parent routing affinity for Guardian reviews (#57710 )

2026-10-28 11:48:00 +00:00

responses_retry_tests.rs

Move content-filter guidance into the shared Responses retry handler (#49130 )

2026-09-29 02:05:56 +00:00

responses_retry.rs

Add trace instrumentation for turn startup and response streaming (#56515 )

2026-10-23 16:09:06 +00:00

rollout_budget.rs

Allow advisory rollout budgets with optional limit enforcement (#57187 )

2026-10-26 18:31:49 +00:00

rollout.rs

…

safety_tests.rs

Fix macOS system-alias matching in patch permission checks (#47879 )

2026-09-24 16:36:57 +00:00

safety.rs

Fix macOS system-alias matching in patch permission checks (#47879 )

2026-09-24 16:36:57 +00:00

sandbox_tags_tests.rs

…

sandbox_tags.rs

Enable MXC selection through Windows sandbox configuration (#46271 )

2026-09-17 18:20:28 +00:00

session_prefix_tests.rs

Notify parent agents when Guardian stops a subagent (#49312 )

2026-09-29 16:53:11 +00:00

session_prefix.rs

Support typed content in contextual prompt fragments (#54776 )

2026-10-17 04:02:21 +00:00

session_rollout_init_error_tests.rs

Distinguish retryable thread-store errors from unknown write outcomes (#54664 )

2026-10-16 17:31:47 +00:00

session_rollout_init_error.rs

Distinguish retryable thread-store errors from unknown write outcomes (#54664 )

2026-10-16 17:31:47 +00:00

shell_snapshot_sandbox_tests.rs

Preserve sandbox overrides across execution requests (#51786 )

2026-10-07 17:59:22 +00:00

shell_snapshot_sandbox.rs

Run sandbox integrity checks before commands and filesystem operations (#51843 )

2026-10-07 21:52:43 +00:00

shell_snapshot_tests.rs

Add hook configuration to environment attachments (#56302 )

2026-10-23 00:02:29 +00:00

shell_snapshot.rs

Expose originating tool call metadata in command environments (#52119 )

2026-10-08 13:45:19 +00:00

shell_tests.rs

Restore executor tool paths after login shell startup (#49467 )

2026-09-30 03:22:55 +00:00

shell.rs

Restore executor tool paths after login shell startup (#49467 )

2026-09-30 03:22:55 +00:00

skills.rs

Integrate discovery V2 with step-scoped skill catalogs (#55322 )

2026-10-19 17:02:20 +00:00

spawn.rs

Remove the patched zsh shell execution backend (#52160 )

2026-10-08 16:19:09 +00:00

state_db_bridge.rs

…

stream_events_utils_tests.rs

Allow replacing dynamic tools between model steps (#57553 )

2026-10-27 19:50:41 +00:00

stream_events_utils.rs

Preserve native tool-call evidence through Guardian review (#58040 )

2026-10-29 11:15:52 +00:00

test_support.rs

Preserve model metadata origin through runtime resolution (#58361 )

2026-10-30 15:11:02 +00:00

thread_manager_tests.rs

Add a feature flag for code-mode host output truncation (#58159 )

2026-10-29 19:29:05 +00:00

thread_manager.rs

Add a feature flag for code-mode host output truncation (#58159 )

2026-10-29 19:29:05 +00:00

thread_rollout_truncation_tests.rs

Add opt-in output token replay for OpenAI requests (#52742 )

2026-10-10 01:25:00 +00:00

thread_rollout_truncation.rs

Remove partial-history subagent forks (#51329 )

2026-10-06 10:39:16 +00:00

thread_spawn.rs

Add host-reserved V2 child creation APIs (#57586 )

2026-10-27 23:02:27 +00:00

thread_startup_metadata.rs

Remove initial messages from session configuration events (#50360 )

2026-10-02 16:55:41 +00:00

turn_diff_tracker_tests.rs

…

turn_diff_tracker.rs

…

turn_extension_data.rs

Capture host-supplied extension data for each turn (#49846 )

2026-10-01 03:31:48 +00:00

turn_metadata_tests.rs

Preserve parent routing affinity for Guardian reviews (#57710 )

2026-10-28 11:48:00 +00:00

turn_metadata.rs

Forward turn metadata to image generation and edit requests (#54058 )

2026-10-14 18:01:54 +00:00

turn_timing_tests.rs

Report turn critical-path timing in analytics (#57209 )

2026-10-26 19:35:31 +00:00

turn_timing.rs

Expose Guardian assessments in response streams (#57757 )

2026-10-28 15:04:29 +00:00

user_shell_command_tests.rs

…

user_shell_command.rs

Support typed content in contextual prompt fragments (#54776 )

2026-10-17 04:02:21 +00:00

util_tests.rs

…

util.rs

Move retry backoff into codex-async-utils (#46330 )

2026-09-18 00:25:37 +00:00

web_search.rs

…

windows_sandbox_read_grants_tests.rs

…

windows_sandbox_read_grants.rs

…

windows_sandbox_tests.rs

Always use private desktops for legacy Windows sandboxes (#46554 )

2026-09-19 01:21:32 +00:00

windows_sandbox.rs

Log Windows sandbox availability and backend selection (#51974 )

2026-10-08 06:31:56 +00:00

windows_system_config.rs

…

worktree_trust_tests.rs

Add portable project trust lookup APIs (#47620 )

2026-09-23 18:40:12 +00:00