swastik-oai 75424f87ca Refactor MCP tool argument parsing and approval preparation (#59474) ...

## What changed

Extract argument parsing and approval policy selection into helpers. Separate
approval requirement evaluation and action construction from requesting approval,
with explicit states for approvals that are unnecessary, remembered, or required.

GitOrigin-RevId: 822cda972f9e0d12286ec833dfbe11b47b4c0ec8

2026-11-04 19:12:26 +00:00

..

agent

Share context window ID allocation through the agent runtime (#59354)

2026-11-04 08:13:41 +00:00

apps

Support typed content in contextual prompt fragments (#54776)

2026-10-17 04:02:21 +00:00

config

Restore the daemon auto-start feature flag (#59447)

2026-11-04 16:46:21 +00:00

context

Introduce a dedicated context window ID type (#59328)

2026-11-04 06:05:16 +00:00

context_manager

Add opt-in elastic budgeting for synchronous Guardian reviews (#59444)

2026-11-04 16:33:22 +00:00

environment_selection

Tie executor attachments to environment selection lifetimes (#59043)

2026-11-03 02:37:20 +00:00

exec_policy

Add host-inherited thread instructions and execution policies (#58406)

2026-10-30 18:20:57 +00:00

guardian

Add opt-in elastic budgeting for synchronous Guardian reviews (#59444)

2026-11-04 16:33:22 +00:00

hook_runtime

Enable executor cleanup hooks with V2 capability discovery (#56044)

2026-10-22 01:42:11 +00:00

mcp_tool_call

Preserve specific MCP failure codes in metrics and spans (#54094)

2026-10-14 20:53:59 +00:00

plugins

Preserve filesystem authority when loading skills (#59279)

2026-11-04 01:13:54 +00:00

realtime_conversation

Expose assistant content token counts in completion notifications (#59041)

2026-11-03 02:26:29 +00:00

realtime_history

…

sandboxing

Run sandbox integrity checks before commands and filesystem operations (#51843)

2026-10-07 21:52:43 +00:00

session

Carry per-input extension data to user message completion callbacks (#59455)

2026-11-04 17:13:00 +00:00

state

Share context window ID allocation through the agent runtime (#59354)

2026-11-04 08:13:41 +00:00

tasks

Route response item IDs through a shared generator (#59312)

2026-11-04 04:02:00 +00:00

thread_manager

Wire shared runtime authentication through threads and API clients (#59177)

2026-11-03 15:02:57 +00:00

tools

Route response item IDs through a shared generator (#59312)

2026-11-04 04:02:00 +00:00

turn_timing

Report auto-review overhead in turn critical-path analytics (#59260)

2026-11-03 23:49:01 +00:00

unified_exec

Tie executor attachments to environment selection lifetimes (#59043)

2026-11-03 02:37:20 +00:00

utils

…

agent_communication.rs

Refactor agent spawning, startup, and communication helpers (#57278)

2026-10-26 21:48:19 +00:00

agents_md_manager.rs

Warn when project instructions exceed the configured byte budget (#59445)

2026-11-04 16:34:49 +00:00

agents_md_tests.rs

Warn when project instructions exceed the configured byte budget (#59445)

2026-11-04 16:34:49 +00:00

agents_md.rs

Warn when project instructions exceed the configured byte budget (#59445)

2026-11-04 16:34:49 +00:00

apply_patch_tests.rs

Separate apply_patch request preparation from execution (#57261)

2026-10-26 21:15:23 +00:00

apply_patch.rs

Separate apply_patch request preparation from execution (#57261)

2026-10-26 21:15:23 +00:00

attestation.rs

…

client_common_tests.rs

Add opt-in output token replay for OpenAI requests (#52742)

2026-10-10 01:25:00 +00:00

client_common.rs

Preserve parent routing affinity for Guardian reviews (#57710)

2026-10-28 11:48:00 +00:00

client_runtime_auth_tests.rs

Wire shared runtime authentication through threads and API clients (#59177)

2026-11-03 15:02:57 +00:00

client_tests.rs

Route response item IDs through a shared generator (#59312)

2026-11-04 04:02:00 +00:00

client_tool_metadata_tests.rs

Send base instructions as Responses input messages (#51156)

2026-10-05 18:52:51 +00:00

client_tool_metadata.rs

Bound tool-call observations to the outgoing Responses message budget (#47957)

2026-09-24 22:54:29 +00:00

client.rs

Route response item IDs through a shared generator (#59312)

2026-11-04 04:02:00 +00:00

code_mode_host_lifecycle_tests.rs

Add optional process metrics sampling for code-mode hosts (#57841)

2026-10-28 21:34:25 +00:00

code_mode_host_tests.rs

Add optional process metrics sampling for code-mode hosts (#57841)

2026-10-28 21:34:25 +00:00

code_mode_host.rs

Add a feature flag for code-mode host output truncation (#58159)

2026-10-29 19:29:05 +00:00

codex_delegate_tests.rs

Refactor agent spawning, startup, and communication helpers (#57278)

2026-10-26 21:48:19 +00:00

codex_delegate.rs

Wire shared runtime authentication through threads and API clients (#59177)

2026-11-03 15:02:57 +00:00

codex_thread.rs

Route response item IDs through a shared generator (#59312)

2026-11-04 04:02:00 +00:00

command_canonicalization_tests.rs

…

command_canonicalization.rs

…

compact_model_fallback.rs

Treat incomplete responses as terminal errors (#53451)

2026-10-12 18:53:49 +00:00

compact_pending_input.rs

Preserve pending agent messages across compaction (#59404)

2026-11-04 13:03:01 +00:00

compact_remote_history_tests.rs

Remove the unused legacy remote compaction implementation (#44273)

2026-09-09 18:40:53 +00:00

compact_remote_history.rs

Use measured durations to budget uploaded audio (#59268)

2026-11-04 00:19:12 +00:00

compact_remote_v2_attempt.rs

Introduce a dedicated context window ID type (#59328)

2026-11-04 06:05:16 +00:00

compact_remote_v2_installation_tests.rs

Enable uploaded audio with durable rejection recovery (#59234)

2026-11-03 21:24:16 +00:00

compact_remote_v2_installation.rs

Use measured durations to budget uploaded audio (#59268)

2026-11-04 00:19:12 +00:00

compact_remote_v2_media_budget_tests.rs

Use measured durations to budget uploaded audio (#59268)

2026-11-04 00:19:12 +00:00

compact_remote_v2_media.rs

Use measured durations to budget uploaded audio (#59268)

2026-11-04 00:19:12 +00:00

compact_remote_v2.rs

Preserve pending agent messages across compaction (#59404)

2026-11-04 13:03:01 +00:00

compact_retained_tool_outputs.rs

Retain client-marked tool outputs across compaction (#52937)

2026-10-10 17:30:25 +00:00

compact_tests.rs

Preserve native tool-call evidence through Guardian review (#58040)

2026-10-29 11:15:52 +00:00

compact_token_budget.rs

Install full context in compaction replacement history (#51117)

2026-10-05 16:10:27 +00:00

compact.rs

Preserve pending agent messages across compaction (#59404)

2026-11-04 13:03:01 +00:00

connectors_tests.rs

…

connectors.rs

Avoid unnecessary connector directory work for tool suggestions (#57257)

2026-10-26 21:08:15 +00:00

current_time.rs

…

cyber_access_program.rs

Allow providers to opt into Cyber access programs (#58190)

2026-10-29 23:24:52 +00:00

elicitation_tests.rs

…

elicitation.rs

…

environment_connection_tests.rs

Stabilize cross-platform tests and directory-change fork permissions (#59369)

2026-11-04 09:51:28 +00:00

environment_selection_snapshot_tests.rs

Tie executor attachments to environment selection lifetimes (#59043)

2026-11-03 02:37:20 +00:00

environment_selection.rs

Tie executor attachments to environment selection lifetimes (#59043)

2026-11-03 02:37:20 +00:00

event_mapping_tests.rs

Route response item IDs through a shared generator (#59312)

2026-11-04 04:02:00 +00:00

event_mapping.rs

Budget retained file audio during remote compaction (#59237)

2026-11-03 21:53:26 +00:00

exec_env_tests.rs

Make apply_patch preserve line endings unconditionally (#51203)

2026-10-05 23:52:06 +00:00

exec_env.rs

Expose originating tool call metadata in command environments (#52119)

2026-10-08 13:45:19 +00:00

exec_policy_tests.rs

Allow dangerous-command review when sandbox approvals are disabled (#59120)

2026-11-03 11:14:59 +00:00

exec_policy_windows_tests.rs

Avoid false URL-launch detections in literal PowerShell commands (#54076)

2026-10-14 19:47:50 +00:00

exec_policy.rs

Allow dangerous-command review when sandbox approvals are disabled (#59120)

2026-11-03 11:14:59 +00:00

exec_tests.rs

Stabilize cancellation and tracing tests (#58171)

2026-10-29 20:39:04 +00:00

exec.rs

Run sandbox integrity checks before commands and filesystem operations (#51843)

2026-10-07 21:52:43 +00:00

feedback_config_tests.rs

Add configuration and feature diagnostics to report metadata (#46501)

2026-09-18 23:07:36 +00:00

feedback_config.rs

Add configuration and feature diagnostics to report metadata (#46501)

2026-09-18 23:07:36 +00:00

function_tool.rs

Complete dynamic tool lifecycles on cancellation (#51556)

2026-10-07 03:07:51 +00:00

git_info_tests.rs

Use descriptor-safe helpers for executable test fixtures (#50018)

2026-10-01 15:57:03 +00:00

guardian_review.rs

Add direct Guardian review of recorded exec calls (#58028)

2026-10-29 09:48:55 +00:00

hook_environment_executor.rs

Tie executor attachments to environment selection lifetimes (#59043)

2026-11-03 02:37:20 +00:00

hook_mcp_executor.rs

Start dormant MCP servers for hook calls (#55263)

2026-10-19 11:40:15 +00:00

hook_runtime.rs

Enable uploaded audio with durable rejection recovery (#59234)

2026-11-03 21:24:16 +00:00

image_preparation_tests.rs

Replace unavailable image references in model requests (#57585)

2026-10-27 22:59:22 +00:00

image_preparation.rs

Replace unavailable image references in model requests (#57585)

2026-10-27 22:59:22 +00:00

installation_id.rs

Allow concurrent readers of the installation ID (#59021)

2026-11-03 01:18:58 +00:00

lib.rs

Preserve pending agent messages across compaction (#59404)

2026-11-04 13:03:01 +00:00

mcp_openai_file.rs

Tie executor attachments to environment selection lifetimes (#59043)

2026-11-03 02:37:20 +00:00

mcp_skill_dependencies.rs

Add configurable default plugin activation policy (#52220)

2026-10-08 18:42:58 +00:00

mcp_tool_approval_templates.rs

…

mcp_tool_call_tests.rs

Tie executor attachments to environment selection lifetimes (#59043)

2026-11-03 02:37:20 +00:00

mcp_tool_call.rs

Refactor MCP tool argument parsing and approval preparation (#59474)

2026-11-04 19:12:26 +00:00

mcp_tool_exposure_test.rs

Share prepared MCP tool definitions across sessions (#55724)

2026-10-21 01:55:56 +00:00

mcp_tool_exposure.rs

Resolve model-selected search providers with policy-aware fallback (#59036)

2026-11-03 02:08:56 +00:00

mcp.rs

Share eligible local stdio MCP connections across chats (#57211)

2026-10-26 19:37:32 +00:00

memory_usage.rs

Tag memory usage telemetry with the memory version (#45960)

2026-09-16 15:17:41 +00:00

mention_syntax.rs

…

model_request_tests.rs

Preserve parent routing affinity for Guardian reviews (#57710)

2026-10-28 11:48:00 +00:00

model_request.rs

Add extension hooks for model requests and response streams (#47679)

2026-09-23 22:10:04 +00:00

model_search.rs

Resolve model-selected search providers with policy-aware fallback (#59036)

2026-11-03 02:08:56 +00:00

network_policy_decision_tests.rs

…

network_policy_decision.rs

…

original_image_detail.rs

…

otel_init.rs

Redact OTEL exporter headers in app-server config responses (#57654)

2026-10-28 05:46:04 +00:00

prompt_debug.rs

Wire shared runtime authentication through threads and API clients (#59177)

2026-11-03 15:02:57 +00:00

realtime_context_tests.rs

Add a feature-gated account check for CLI thread resume (#58890)

2026-11-02 13:51:49 +00:00

realtime_context.rs

…

realtime_conversation_tests.rs

Preserve realtime V3 transcripts in conversation history (#58221)

2026-10-30 02:43:02 +00:00

realtime_conversation.rs

Enable uploaded audio with durable rejection recovery (#59234)

2026-11-03 21:24:16 +00:00

realtime_history_tests.rs

Expose assistant content token counts in completion notifications (#59041)

2026-11-03 02:26:29 +00:00

realtime_history.rs

…

realtime_prompt.rs

…

responses_headers.rs

Preserve Guardian request metadata with custom OpenAI base URLs (#57439)

2026-10-27 12:17:14 +00:00

responses_metadata.rs

Introduce a dedicated context window ID type (#59328)

2026-11-04 06:05:16 +00:00

responses_retry_tests.rs

Move content-filter guidance into the shared Responses retry handler (#49130)

2026-09-29 02:05:56 +00:00

responses_retry.rs

Keep HTTP fallback active for the rest of the session (#58989)

2026-11-02 21:37:17 +00:00

rollout_budget.rs

Allow advisory rollout budgets with optional limit enforcement (#57187)

2026-10-26 18:31:49 +00:00

rollout.rs

…

runtime_auth.rs

Wire shared runtime authentication through threads and API clients (#59177)

2026-11-03 15:02:57 +00:00

safety_tests.rs

Fix macOS system-alias matching in patch permission checks (#47879)

2026-09-24 16:36:57 +00:00

safety.rs

Fix macOS system-alias matching in patch permission checks (#47879)

2026-09-24 16:36:57 +00:00

sandbox_tags_tests.rs

…

sandbox_tags.rs

Enable MXC selection through Windows sandbox configuration (#46271)

2026-09-17 18:20:28 +00:00

session_prefix_tests.rs

Notify parent agents when Guardian stops a subagent (#49312)

2026-09-29 16:53:11 +00:00

session_prefix.rs

Support typed content in contextual prompt fragments (#54776)

2026-10-17 04:02:21 +00:00

session_rollout_init_error_tests.rs

Distinguish retryable thread-store errors from unknown write outcomes (#54664)

2026-10-16 17:31:47 +00:00

session_rollout_init_error.rs

Distinguish retryable thread-store errors from unknown write outcomes (#54664)

2026-10-16 17:31:47 +00:00

shell_snapshot_sandbox_tests.rs

Preserve sandbox overrides across execution requests (#51786)

2026-10-07 17:59:22 +00:00

shell_snapshot_sandbox.rs

Run sandbox integrity checks before commands and filesystem operations (#51843)

2026-10-07 21:52:43 +00:00

shell_snapshot_tests.rs

Tie executor attachments to environment selection lifetimes (#59043)

2026-11-03 02:37:20 +00:00

shell_snapshot.rs

Expose originating tool call metadata in command environments (#52119)

2026-10-08 13:45:19 +00:00

shell_tests.rs

Restore executor tool paths after login shell startup (#49467)

2026-09-30 03:22:55 +00:00

shell.rs

Restore executor tool paths after login shell startup (#49467)

2026-09-30 03:22:55 +00:00

skills.rs

Respect filesystem permissions when discovering repository skills (#59280)

2026-11-04 01:15:38 +00:00

spawn.rs

Remove the patched zsh shell execution backend (#52160)

2026-10-08 16:19:09 +00:00

state_db_bridge.rs

…

stream_events_utils_tests.rs

Expose assistant content token counts in completion notifications (#59041)

2026-11-03 02:26:29 +00:00

stream_events_utils.rs

Carry per-input extension data to user message completion callbacks (#59455)

2026-11-04 17:13:00 +00:00

test_support.rs

Expand per-turn critical path capture and split inference timing (#59245)

2026-11-03 22:29:33 +00:00

thread_input.rs

Expose non-consuming input activity waits to hosts (#58411)

2026-10-30 18:34:10 +00:00

thread_manager_tests.rs

Wire shared runtime authentication through threads and API clients (#59177)

2026-11-03 15:02:57 +00:00

thread_manager.rs

Wire shared runtime authentication through threads and API clients (#59177)

2026-11-03 15:02:57 +00:00

thread_rollout_truncation_tests.rs

Add opt-in output token replay for OpenAI requests (#52742)

2026-10-10 01:25:00 +00:00

thread_rollout_truncation.rs

Remove partial-history subagent forks (#51329)

2026-10-06 10:39:16 +00:00

thread_spawn.rs

Add host-reserved V2 child creation APIs (#57586)

2026-10-27 23:02:27 +00:00

thread_startup_metadata.rs

Remove initial messages from session configuration events (#50360)

2026-10-02 16:55:41 +00:00

thread_store_builder.rs

Move agent message board cleanup into the app server (#59167)

2026-11-03 14:15:56 +00:00

turn_diff_tracker_tests.rs

…

turn_diff_tracker.rs

…

turn_extension_data.rs

Capture host-supplied extension data for each turn (#49846)

2026-10-01 03:31:48 +00:00

turn_metadata_tests.rs

Preserve parent routing affinity for Guardian reviews (#57710)

2026-10-28 11:48:00 +00:00

turn_metadata.rs

Forward turn metadata to image generation and edit requests (#54058)

2026-10-14 18:01:54 +00:00

turn_timing_tests.rs

Report auto-review overhead in turn critical-path analytics (#59260)

2026-11-03 23:49:01 +00:00

turn_timing.rs

Report auto-review overhead in turn critical-path analytics (#59260)

2026-11-03 23:49:01 +00:00

user_shell_command_tests.rs

…

user_shell_command.rs

Support typed content in contextual prompt fragments (#54776)

2026-10-17 04:02:21 +00:00

util_tests.rs

…

util.rs

Move retry backoff into codex-async-utils (#46330)

2026-09-18 00:25:37 +00:00

web_search.rs

…

windows_sandbox_read_grants_tests.rs

…

windows_sandbox_read_grants.rs

…

windows_sandbox_tests.rs

Always use private desktops for legacy Windows sandboxes (#46554)

2026-09-19 01:21:32 +00:00

windows_sandbox.rs

Log Windows sandbox availability and backend selection (#51974)

2026-10-08 06:31:56 +00:00

windows_system_config.rs

Add telemetry for the Windows system config namespace (#44284)

2026-09-09 19:31:12 +00:00

worktree_trust_tests.rs

Add portable project trust lookup APIs (#47620)

2026-09-23 18:40:12 +00:00