mirror of
https://github.com/openai/codex.git
synced 2026-09-13 11:47:17 +00:00
## Why Windows sandbox setup reconciles persistent deny ACLs against the paths supplied for a session. The `codex sandbox --permission-profile` path supplied an empty list, which could discard the profile's deny-read restrictions. ## What changed Resolve deny-read paths from the selected permission profile and workspace roots before starting a Windows sandbox session, and pass them through to setup. ## Testing Add a Windows CLI integration test that launches the same managed-deny profile twice and verifies that denied file reads and DLL loads remain blocked while allowed access still works. GitOrigin-RevId: 6ec8b6a13a33b862d7b152eadbbdde3146de4b7d
681 lines
25 KiB
Rust
681 lines
25 KiB
Rust
use anyhow::Context;
|
|
use codex_core::exec::ExecCapturePolicy;
|
|
use codex_core::exec::ExecParams;
|
|
use codex_core::exec::process_exec_tool_call;
|
|
use codex_core::sandboxing::SandboxPermissions;
|
|
use codex_core::windows_sandbox::sandbox_setup_is_complete;
|
|
use codex_features::Feature;
|
|
use codex_protocol::config_types::WindowsSandboxLevel;
|
|
use codex_protocol::exec_output::ExecToolCallOutput;
|
|
use codex_protocol::models::PermissionProfile;
|
|
use codex_protocol::permissions::FileSystemAccessMode;
|
|
use codex_protocol::permissions::FileSystemPath;
|
|
use codex_protocol::permissions::FileSystemSandboxEntry;
|
|
use codex_protocol::permissions::FileSystemSandboxPolicy;
|
|
use codex_protocol::permissions::FileSystemSpecialPath;
|
|
use codex_protocol::permissions::NetworkSandboxPolicy;
|
|
use core_test_support::PathExt;
|
|
use core_test_support::responses::ev_assistant_message;
|
|
use core_test_support::responses::ev_completed;
|
|
use core_test_support::responses::ev_function_call;
|
|
use core_test_support::responses::ev_response_created;
|
|
use core_test_support::responses::mount_sse_sequence;
|
|
use core_test_support::responses::sse;
|
|
use core_test_support::test_codex::TestCodexHarness;
|
|
use core_test_support::test_codex::test_codex;
|
|
use pretty_assertions::assert_eq;
|
|
use serde_json::json;
|
|
use serial_test::serial;
|
|
use std::collections::HashMap;
|
|
use std::ffi::OsString;
|
|
use std::path::Path;
|
|
use std::path::PathBuf;
|
|
use std::process::Command;
|
|
use tempfile::TempDir;
|
|
|
|
struct EnvVarGuard {
|
|
key: &'static str,
|
|
original: Option<OsString>,
|
|
}
|
|
|
|
impl EnvVarGuard {
|
|
fn set(key: &'static str, value: &std::ffi::OsStr) -> Self {
|
|
let original = std::env::var_os(key);
|
|
unsafe {
|
|
std::env::set_var(key, value);
|
|
}
|
|
Self { key, original }
|
|
}
|
|
}
|
|
|
|
impl Drop for EnvVarGuard {
|
|
fn drop(&mut self) {
|
|
unsafe {
|
|
match &self.original {
|
|
Some(value) => std::env::set_var(self.key, value),
|
|
None => std::env::remove_var(self.key),
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
enum TestCodexHome {
|
|
Persistent(PathBuf),
|
|
Temporary(TempDir),
|
|
}
|
|
|
|
impl TestCodexHome {
|
|
fn path(&self) -> &Path {
|
|
match self {
|
|
Self::Persistent(path) => path.as_path(),
|
|
Self::Temporary(temp_dir) => temp_dir.path(),
|
|
}
|
|
}
|
|
}
|
|
|
|
fn codex_home_for_windows_sandbox_test(name: &str) -> anyhow::Result<TestCodexHome> {
|
|
if let Some(test_tmpdir) = std::env::var_os("TEST_TMPDIR") {
|
|
// The elevated backend provisions machine-local sandbox users. Bazel
|
|
// retries run in the same Windows VM, so keep CODEX_HOME stable within
|
|
// the test temp root and let setup reconcile its persisted ACL state.
|
|
let codex_home = PathBuf::from(test_tmpdir).join(name);
|
|
std::fs::create_dir_all(&codex_home)
|
|
.with_context(|| format!("create stable test CODEX_HOME {}", codex_home.display()))?;
|
|
return Ok(TestCodexHome::Persistent(codex_home));
|
|
}
|
|
|
|
Ok(TestCodexHome::Temporary(TempDir::new()?))
|
|
}
|
|
|
|
fn stage_windows_sandbox_helpers() -> anyhow::Result<()> {
|
|
let test_exe = std::env::current_exe().context("resolve current Windows test executable")?;
|
|
let test_exe_dir = test_exe
|
|
.parent()
|
|
.context("Windows test executable should have a parent directory")?;
|
|
let resources_dir = test_exe_dir.join("codex-resources");
|
|
match std::fs::create_dir_all(&resources_dir) {
|
|
Ok(()) => {}
|
|
Err(err)
|
|
if err.kind() == std::io::ErrorKind::PermissionDenied && resources_dir.is_dir() => {}
|
|
Err(err) => {
|
|
return Err(err)
|
|
.with_context(|| format!("create resources dir {}", resources_dir.display()));
|
|
}
|
|
}
|
|
for helper_name in ["codex-windows-sandbox-setup", "codex-command-runner"] {
|
|
let helper = codex_utils_cargo_bin::cargo_bin(helper_name)?;
|
|
let file_name = Path::new(helper_name).with_extension("exe");
|
|
let destination = resources_dir.join(file_name);
|
|
if let Err(err) = std::fs::copy(&helper, &destination) {
|
|
// A sandbox helper can briefly remain alive after the sandboxed
|
|
// command exits. Bazel may retry the test while that process still
|
|
// has the staged executable open, so keep the already-staged copy.
|
|
if err.kind() == std::io::ErrorKind::PermissionDenied && destination.exists() {
|
|
continue;
|
|
}
|
|
return Err(err).with_context(|| {
|
|
format!(
|
|
"stage Windows sandbox helper {} at {}",
|
|
helper.display(),
|
|
destination.display()
|
|
)
|
|
});
|
|
}
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
fn escape_toml_path(path: &Path) -> String {
|
|
path.display().to_string().replace('\\', "\\\\")
|
|
}
|
|
|
|
fn stage_windows_sandbox_cli(fixture_bin: &Path) -> anyhow::Result<(PathBuf, PathBuf)> {
|
|
std::fs::create_dir_all(fixture_bin)?;
|
|
let resources_dir = fixture_bin.join("codex-resources");
|
|
std::fs::create_dir_all(&resources_dir)?;
|
|
|
|
let codex_source = codex_utils_cargo_bin::cargo_bin("codex")?;
|
|
let codex = fixture_bin.join("codex.exe");
|
|
std::fs::copy(&codex_source, &codex)
|
|
.with_context(|| format!("copy {} to {}", codex_source.display(), codex.display()))?;
|
|
for helper_name in ["codex-windows-sandbox-setup", "codex-command-runner"] {
|
|
let helper = codex_utils_cargo_bin::cargo_bin(helper_name)?;
|
|
let destination = resources_dir.join(Path::new(helper_name).with_extension("exe"));
|
|
std::fs::copy(&helper, &destination)
|
|
.with_context(|| format!("copy {} to {}", helper.display(), destination.display()))?;
|
|
}
|
|
|
|
let probe_source = codex_utils_cargo_bin::cargo_bin("codex-windows-managed-deny-probe")?;
|
|
let probe = fixture_bin.join("managed-deny-probe.exe");
|
|
std::fs::copy(&probe_source, &probe)
|
|
.with_context(|| format!("copy {} to {}", probe_source.display(), probe.display()))?;
|
|
Ok((codex, probe))
|
|
}
|
|
|
|
fn assert_managed_deny_probe(output: &std::process::Output, launch: usize) -> anyhow::Result<()> {
|
|
let stdout = String::from_utf8_lossy(&output.stdout);
|
|
let stderr = String::from_utf8_lossy(&output.stderr);
|
|
assert!(
|
|
output.status.success(),
|
|
"managed deny probe launch {launch} failed: status={:?}; stdout={stdout}; stderr={stderr}",
|
|
output.status.code()
|
|
);
|
|
assert!(
|
|
stdout.contains("allowed-read:OK") && stdout.contains("allowed-import:OK"),
|
|
"managed deny probe launch {launch} lost allowed access: {stdout}"
|
|
);
|
|
assert!(
|
|
stdout.contains("denied-read:DENIED") && stdout.contains("denied-import:DENIED"),
|
|
"managed deny probe launch {launch} did not enforce denied access: {stdout}"
|
|
);
|
|
assert!(
|
|
!stdout.contains("UNEXPECTED_SUCCESS"),
|
|
"managed deny probe launch {launch} leaked denied content: {stdout}"
|
|
);
|
|
Ok(())
|
|
}
|
|
|
|
#[test]
|
|
#[serial(codex_home)]
|
|
fn windows_sandbox_cli_preserves_managed_deny_reads_across_launches() -> anyhow::Result<()> {
|
|
let codex_home =
|
|
codex_home_for_windows_sandbox_test("windows-cli-managed-deny-read-codex-home")?;
|
|
|
|
let fixture = TempDir::new()?;
|
|
let fixture_root = dunce::canonicalize(fixture.path())?;
|
|
let work = fixture_root.join("work");
|
|
let runtime = fixture_root.join("runtime");
|
|
let denied = runtime.join("denied");
|
|
let bin = fixture_root.join("bin");
|
|
std::fs::create_dir_all(&work)?;
|
|
std::fs::create_dir_all(&denied)?;
|
|
let (codex, probe) = stage_windows_sandbox_cli(&bin)?;
|
|
|
|
let allowed_text = runtime.join("allowed.txt");
|
|
let denied_text = denied.join("secret.txt");
|
|
let allowed_module = runtime.join("allowed.dll");
|
|
let denied_module = denied.join("secret.dll");
|
|
std::fs::write(&allowed_text, "ALLOW-CONTROL\n")?;
|
|
std::fs::write(&denied_text, "DENIED-CONTENT\n")?;
|
|
let system_root = std::env::var_os("SystemRoot").context("resolve SystemRoot")?;
|
|
let system_module = PathBuf::from(system_root)
|
|
.join("System32")
|
|
.join("version.dll");
|
|
std::fs::copy(&system_module, &allowed_module).with_context(|| {
|
|
format!(
|
|
"copy {} to {}",
|
|
system_module.display(),
|
|
allowed_module.display()
|
|
)
|
|
})?;
|
|
std::fs::copy(&system_module, &denied_module).with_context(|| {
|
|
format!(
|
|
"copy {} to {}",
|
|
system_module.display(),
|
|
denied_module.display()
|
|
)
|
|
})?;
|
|
|
|
std::fs::write(
|
|
codex_home.path().join("config.toml"),
|
|
format!(
|
|
"default_permissions = \"managed-deny-test\"\n\
|
|
\n\
|
|
[windows]\n\
|
|
sandbox = \"elevated\"\n\
|
|
\n\
|
|
[shell_environment_policy]\n\
|
|
inherit = \"all\"\n\
|
|
\n\
|
|
[permissions.managed-deny-test.filesystem]\n\
|
|
\":minimal\" = \"read\"\n\
|
|
\"{}\" = \"read\"\n\
|
|
\"{}\" = \"write\"\n\
|
|
\"{}\" = \"deny\"\n\
|
|
\n\
|
|
[permissions.managed-deny-test.network]\n\
|
|
enabled = false\n",
|
|
escape_toml_path(&fixture_root),
|
|
escape_toml_path(&work),
|
|
escape_toml_path(&denied),
|
|
),
|
|
)?;
|
|
|
|
for launch in 1..=2 {
|
|
let output = Command::new(&codex)
|
|
.current_dir(&work)
|
|
.env("CODEX_HOME", codex_home.path())
|
|
.env("CODEX_WINDOWS_ALLOWED_TEXT", &allowed_text)
|
|
.env("CODEX_WINDOWS_DENIED_TEXT", &denied_text)
|
|
.env("CODEX_WINDOWS_ALLOWED_MODULE", &allowed_module)
|
|
.env("CODEX_WINDOWS_DENIED_MODULE", &denied_module)
|
|
.args(["sandbox", "--permission-profile"])
|
|
.arg("managed-deny-test")
|
|
.arg("--cd")
|
|
.arg(&work)
|
|
.arg("--")
|
|
.arg(&probe)
|
|
.output()?;
|
|
assert_managed_deny_probe(&output, launch)?;
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[tokio::test]
|
|
#[serial(codex_home)]
|
|
async fn windows_restricted_token_rejects_exact_and_glob_deny_read_policy() -> anyhow::Result<()> {
|
|
let codex_home =
|
|
codex_home_for_windows_sandbox_test("windows-restricted-token-deny-read-codex-home")?;
|
|
let _codex_home_guard = EnvVarGuard::set("CODEX_HOME", codex_home.path().as_os_str());
|
|
let workspace = TempDir::new()?;
|
|
let cwd = dunce::canonicalize(workspace.path())?.abs();
|
|
let secret = cwd.join("secret.env");
|
|
let future_secret = cwd.join("future.env");
|
|
let public = cwd.join("public.txt");
|
|
std::fs::write(&secret, "glob secret\n")?;
|
|
std::fs::write(&public, "public ok\n")?;
|
|
|
|
let file_system_sandbox_policy = FileSystemSandboxPolicy::restricted(vec![
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::Special {
|
|
value: FileSystemSpecialPath::Root,
|
|
},
|
|
access: FileSystemAccessMode::Read,
|
|
missing_path_behavior: None,
|
|
},
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::Special {
|
|
value: FileSystemSpecialPath::project_roots(/*subpath*/ None),
|
|
},
|
|
access: FileSystemAccessMode::Write,
|
|
missing_path_behavior: None,
|
|
},
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::GlobPattern {
|
|
pattern: "**/*.env".to_string(),
|
|
},
|
|
access: FileSystemAccessMode::Deny,
|
|
missing_path_behavior: None,
|
|
},
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::Path {
|
|
path: future_secret.into(),
|
|
},
|
|
access: FileSystemAccessMode::Deny,
|
|
missing_path_behavior: None,
|
|
},
|
|
]);
|
|
let permission_profile = PermissionProfile::from_runtime_permissions(
|
|
&file_system_sandbox_policy,
|
|
NetworkSandboxPolicy::Restricted,
|
|
);
|
|
|
|
let err = process_exec_tool_call(
|
|
ExecParams {
|
|
command: vec![
|
|
"cmd.exe".to_string(),
|
|
"/D".to_string(),
|
|
"/C".to_string(),
|
|
"type secret.env >NUL 2>NUL & echo exact secret 1>future.env 2>NUL & type future.env 2>NUL & type public.txt & exit /B 0"
|
|
.to_string(),
|
|
],
|
|
cwd: cwd.clone(),
|
|
expiration: 10_000.into(),
|
|
capture_policy: ExecCapturePolicy::ShellTool,
|
|
env: HashMap::new(),
|
|
network: None,
|
|
network_environment_id: None,
|
|
sandbox_permissions: SandboxPermissions::UseDefault,
|
|
windows_sandbox_level: WindowsSandboxLevel::RestrictedToken,
|
|
windows_sandbox_private_desktop: false,
|
|
justification: None,
|
|
arg0: None,
|
|
},
|
|
&permission_profile,
|
|
&cwd,
|
|
std::slice::from_ref(&cwd),
|
|
&None,
|
|
/*use_legacy_landlock*/ false,
|
|
/*stdout_stream*/ None,
|
|
)
|
|
.await
|
|
.expect_err("restricted-token sandbox should reject deny-read restrictions");
|
|
|
|
assert_eq!(
|
|
err.to_string(),
|
|
"unsupported operation: windows unelevated restricted-token sandbox cannot enforce deny-read restrictions directly; refusing to run unsandboxed"
|
|
);
|
|
Ok(())
|
|
}
|
|
|
|
#[tokio::test]
|
|
#[serial(codex_home)]
|
|
async fn windows_elevated_does_not_create_missing_workspace_metadata() -> anyhow::Result<()> {
|
|
let codex_home =
|
|
codex_home_for_windows_sandbox_test("windows-elevated-missing-metadata-codex-home")?;
|
|
let _codex_home_guard = EnvVarGuard::set("CODEX_HOME", codex_home.path().as_os_str());
|
|
stage_windows_sandbox_helpers()?;
|
|
let workspace = TempDir::new()?;
|
|
let cwd = dunce::canonicalize(workspace.path())?.abs();
|
|
let permission_profile = PermissionProfile::workspace_write()
|
|
.materialize_project_roots_with_workspace_roots(std::slice::from_ref(&cwd));
|
|
|
|
let output = process_exec_tool_call(
|
|
ExecParams {
|
|
command: vec![
|
|
"cmd.exe".to_string(),
|
|
"/D".to_string(),
|
|
"/C".to_string(),
|
|
"echo sandbox-ok".to_string(),
|
|
],
|
|
cwd: cwd.clone(),
|
|
expiration: 10_000.into(),
|
|
capture_policy: ExecCapturePolicy::ShellTool,
|
|
env: HashMap::new(),
|
|
network: None,
|
|
network_environment_id: None,
|
|
sandbox_permissions: SandboxPermissions::UseDefault,
|
|
windows_sandbox_level: WindowsSandboxLevel::Elevated,
|
|
windows_sandbox_private_desktop: false,
|
|
justification: None,
|
|
arg0: None,
|
|
},
|
|
&permission_profile,
|
|
&cwd,
|
|
std::slice::from_ref(&cwd),
|
|
&None,
|
|
/*use_legacy_landlock*/ false,
|
|
/*stdout_stream*/ None,
|
|
)
|
|
.await?;
|
|
|
|
assert_eq!(output.exit_code, 0, "sandboxed command should complete");
|
|
for name in codex_protocol::permissions::PROTECTED_METADATA_PATH_NAMES {
|
|
let path = cwd.join(name);
|
|
assert!(
|
|
!path.exists(),
|
|
"elevated setup should not create missing workspace metadata: {}",
|
|
path.display()
|
|
);
|
|
}
|
|
Ok(())
|
|
}
|
|
|
|
#[tokio::test]
|
|
#[serial(codex_home)]
|
|
async fn windows_elevated_enforces_deny_read_and_protects_setup_marker() -> anyhow::Result<()> {
|
|
let codex_home = codex_home_for_windows_sandbox_test("windows-elevated-deny-read-codex-home")?;
|
|
let _codex_home_guard = EnvVarGuard::set("CODEX_HOME", codex_home.path().as_os_str());
|
|
stage_windows_sandbox_helpers()?;
|
|
let workspace = TempDir::new()?;
|
|
let cwd = dunce::canonicalize(workspace.path())?.abs();
|
|
let glob_secret = cwd.join("secret.env");
|
|
let public = cwd.join("public.txt");
|
|
let user_profile = TempDir::new_in(dirs::home_dir().context("resolve user profile")?)?;
|
|
let _user_profile_guard = EnvVarGuard::set("USERPROFILE", user_profile.path().as_os_str());
|
|
let exact_secret = user_profile.path().join("exact-secret.txt");
|
|
std::fs::write(&exact_secret, "exact secret\n")?;
|
|
let bundled_skill_dir = user_profile.path().join(".codex/plugins/cache");
|
|
std::fs::create_dir_all(&bundled_skill_dir)?;
|
|
let bundled_skill = bundled_skill_dir.join("SKILL.md");
|
|
let setup_marker = codex_home.path().join(".sandbox").join("setup_marker.json");
|
|
std::fs::write(&glob_secret, "glob secret\n")?;
|
|
std::fs::write(&public, "public ok\n")?;
|
|
std::fs::write(&bundled_skill, "bundled skill ok\n")?;
|
|
|
|
let file_system_sandbox_policy = FileSystemSandboxPolicy::restricted(vec![
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::Special {
|
|
value: FileSystemSpecialPath::Root,
|
|
},
|
|
access: FileSystemAccessMode::Read,
|
|
missing_path_behavior: None,
|
|
},
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::Special {
|
|
value: FileSystemSpecialPath::project_roots(/*subpath*/ None),
|
|
},
|
|
access: FileSystemAccessMode::Write,
|
|
missing_path_behavior: None,
|
|
},
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::GlobPattern {
|
|
pattern: "**/*.env".to_string(),
|
|
},
|
|
access: FileSystemAccessMode::Deny,
|
|
missing_path_behavior: None,
|
|
},
|
|
FileSystemSandboxEntry {
|
|
path: exact_secret.clone().abs().into(),
|
|
access: FileSystemAccessMode::Deny,
|
|
missing_path_behavior: None,
|
|
},
|
|
]);
|
|
let permission_profile = PermissionProfile::from_runtime_permissions(
|
|
&file_system_sandbox_policy,
|
|
NetworkSandboxPolicy::Restricted,
|
|
);
|
|
|
|
let ExecToolCallOutput {
|
|
exit_code,
|
|
stdout,
|
|
..
|
|
} = process_exec_tool_call(
|
|
ExecParams {
|
|
command: vec![
|
|
"cmd.exe".to_string(),
|
|
"/D".to_string(),
|
|
"/C".to_string(),
|
|
"(type secret.env 1>NUL 2>NUL && echo GLOB-READ || echo GLOB-DENIED) & (type %SETUP_MARKER% 1>NUL 2>NUL && echo MARKER-READ-ALLOWED || echo MARKER-READ-DENIED) & (echo tampered > %SETUP_MARKER% 2>NUL && echo MARKER-WRITE-ALLOWED || echo MARKER-WRITE-DENIED) & type public.txt & type %BUNDLED_SKILL% & (type %EXACT_SECRET% 1>NUL 2>NUL && echo EXACT-READ || echo EXACT-DENIED)".to_string(),
|
|
],
|
|
cwd: cwd.clone(),
|
|
expiration: 10_000.into(),
|
|
capture_policy: ExecCapturePolicy::ShellTool,
|
|
env: [
|
|
("BUNDLED_SKILL", &bundled_skill),
|
|
("EXACT_SECRET", &exact_secret),
|
|
("SETUP_MARKER", &setup_marker),
|
|
]
|
|
.into_iter()
|
|
.map(|(name, path)| (name.to_string(), format!("\"{}\"", path.display())))
|
|
.collect(),
|
|
network: None,
|
|
network_environment_id: None,
|
|
sandbox_permissions: SandboxPermissions::UseDefault,
|
|
windows_sandbox_level: WindowsSandboxLevel::Elevated,
|
|
windows_sandbox_private_desktop: false,
|
|
justification: None,
|
|
arg0: None,
|
|
},
|
|
&permission_profile,
|
|
&cwd,
|
|
std::slice::from_ref(&cwd),
|
|
&None,
|
|
/*use_legacy_landlock*/ false,
|
|
/*stdout_stream*/ None,
|
|
)
|
|
.await?;
|
|
|
|
assert_eq!(exit_code, 0, "sandboxed command should complete");
|
|
assert!(
|
|
stdout.text.contains("GLOB-DENIED"),
|
|
"glob deny-read should block the secret: {stdout:?}"
|
|
);
|
|
assert!(
|
|
!stdout.text.contains("GLOB-READ"),
|
|
"glob deny-read should not allow the secret: {stdout:?}"
|
|
);
|
|
assert!(
|
|
stdout.text.contains("EXACT-DENIED"),
|
|
"exact deny-read should block the secret: {stdout:?}"
|
|
);
|
|
assert!(
|
|
!stdout.text.contains("EXACT-READ"),
|
|
"exact deny-read should not allow the secret: {stdout:?}"
|
|
);
|
|
assert!(
|
|
stdout.text.contains("public ok"),
|
|
"allowed reads should still work: {stdout:?}"
|
|
);
|
|
assert!(stdout.text.contains("bundled skill ok"));
|
|
assert!(
|
|
stdout.text.contains("MARKER-READ-DENIED"),
|
|
"sandboxed command should not read setup readiness: {stdout:?}"
|
|
);
|
|
assert!(
|
|
stdout.text.contains("MARKER-WRITE-DENIED"),
|
|
"sandboxed command should not modify setup readiness: {stdout:?}"
|
|
);
|
|
assert!(
|
|
!stdout.text.contains("MARKER-READ-ALLOWED"),
|
|
"sandboxed command must not read setup readiness: {stdout:?}"
|
|
);
|
|
assert!(
|
|
!stdout.text.contains("MARKER-WRITE-ALLOWED"),
|
|
"sandboxed command must not modify setup readiness: {stdout:?}"
|
|
);
|
|
assert!(
|
|
sandbox_setup_is_complete(codex_home.path()),
|
|
"setup should remain ready after the tamper attempt"
|
|
);
|
|
Ok(())
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
#[serial(codex_home)]
|
|
async fn windows_elevated_unified_exec_enforces_managed_deny_reads() -> anyhow::Result<()> {
|
|
let codex_home =
|
|
codex_home_for_windows_sandbox_test("windows-elevated-tool-runtime-deny-read-codex-home")?;
|
|
let _codex_home_guard = EnvVarGuard::set("CODEX_HOME", codex_home.path().as_os_str());
|
|
stage_windows_sandbox_helpers()?;
|
|
|
|
let configured_codex_home = dunce::canonicalize(codex_home.path())?.abs();
|
|
let builder = test_codex()
|
|
.with_windows_cmd_shell()
|
|
.with_config(move |config| {
|
|
config.codex_home = configured_codex_home;
|
|
config.set_windows_elevated_sandbox_enabled(true);
|
|
config
|
|
.features
|
|
.enable(Feature::UnifiedExec)
|
|
.expect("test config should allow unified exec");
|
|
|
|
let file_system_sandbox_policy = FileSystemSandboxPolicy::restricted(vec![
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::Special {
|
|
value: FileSystemSpecialPath::Root,
|
|
},
|
|
access: FileSystemAccessMode::Read,
|
|
missing_path_behavior: None,
|
|
},
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::Special {
|
|
value: FileSystemSpecialPath::project_roots(/*subpath*/ None),
|
|
},
|
|
access: FileSystemAccessMode::Write,
|
|
missing_path_behavior: None,
|
|
},
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::GlobPattern {
|
|
pattern: "**/*.env".to_string(),
|
|
},
|
|
access: FileSystemAccessMode::Deny,
|
|
missing_path_behavior: None,
|
|
},
|
|
FileSystemSandboxEntry {
|
|
path: FileSystemPath::Path {
|
|
path: config.cwd.join("exact-secret.txt").into(),
|
|
},
|
|
access: FileSystemAccessMode::Deny,
|
|
missing_path_behavior: None,
|
|
},
|
|
]);
|
|
config
|
|
.permissions
|
|
.set_permission_profile(PermissionProfile::from_runtime_permissions(
|
|
&file_system_sandbox_policy,
|
|
NetworkSandboxPolicy::Restricted,
|
|
))
|
|
.expect("set managed deny-read permission profile");
|
|
})
|
|
.with_workspace_setup(|cwd, _fs| async move {
|
|
std::fs::write(
|
|
cwd.join("secret.env"),
|
|
"glob secret should remain private\n",
|
|
)?;
|
|
std::fs::write(
|
|
cwd.join("exact-secret.txt"),
|
|
"exact secret should remain private\n",
|
|
)?;
|
|
std::fs::write(cwd.join("public.txt"), "public ok\n")?;
|
|
Ok(())
|
|
});
|
|
let harness = TestCodexHarness::with_builder(builder).await?;
|
|
|
|
let command = concat!(
|
|
"(type secret.env 1>NUL 2>NUL && echo GLOB-READ || echo GLOB-DENIED) & ",
|
|
"(type exact-secret.txt 1>NUL 2>NUL && echo EXACT-READ || echo EXACT-DENIED) & ",
|
|
"type public.txt"
|
|
);
|
|
let call_id = "windows-managed-deny-read-exec-command";
|
|
let unified_args = json!({
|
|
"cmd": command,
|
|
"yield_time_ms": 30_000,
|
|
"tty": false,
|
|
"login": false,
|
|
});
|
|
mount_sse_sequence(
|
|
harness.server(),
|
|
vec![
|
|
sse(vec![
|
|
ev_response_created("resp-windows-unified-deny-read"),
|
|
ev_function_call(
|
|
call_id,
|
|
"exec_command",
|
|
&serde_json::to_string(&unified_args)?,
|
|
),
|
|
ev_completed("resp-windows-unified-deny-read"),
|
|
]),
|
|
sse(vec![
|
|
ev_assistant_message("msg-windows-deny-read", "done"),
|
|
ev_completed("resp-windows-deny-read-complete"),
|
|
]),
|
|
],
|
|
)
|
|
.await;
|
|
|
|
let permission_profile = harness
|
|
.test()
|
|
.config
|
|
.permissions
|
|
.effective_permission_profile();
|
|
harness
|
|
.submit_with_permission_profile("read the sandbox fixtures", permission_profile)
|
|
.await?;
|
|
|
|
let output = harness.function_call_stdout(call_id).await;
|
|
assert!(
|
|
output.contains("GLOB-DENIED"),
|
|
"exec_command should reject glob-denied reads: {output:?}"
|
|
);
|
|
assert!(
|
|
output.contains("EXACT-DENIED"),
|
|
"exec_command should reject exact-path-denied reads: {output:?}"
|
|
);
|
|
assert!(
|
|
output.contains("public ok"),
|
|
"exec_command should preserve allowed reads: {output:?}"
|
|
);
|
|
assert!(
|
|
!output.contains("GLOB-READ") && !output.contains("glob secret"),
|
|
"exec_command leaked glob-denied file contents: {output:?}"
|
|
);
|
|
assert!(
|
|
!output.contains("EXACT-READ") && !output.contains("exact secret"),
|
|
"exec_command leaked exact-path-denied file contents: {output:?}"
|
|
);
|
|
|
|
Ok(())
|
|
}
|