codex

mirror of https://github.com/openai/codex.git synced 2026-10-26 18:38:47 +00:00

Files

T

Abhinav 6bb5be869f Use captured action settings for Guardian reviews (#44574 )

## Why

Model changes during a turn and catalog refreshes can leave Guardian reviews using settings or metadata that do not match the action being reviewed.

## What changed

- Use the action's captured model, reasoning effort, reasoning summary, and personality when configuring reviews.
- Preserve captured model metadata when falling back to the parent model, while resolving a separate reviewer against the current catalog on each attempt.
- Evaluate live managed review requirements against the action's model and use its metadata for computer-use review behavior.
- Include personality in the review session reuse key so personality changes invalidate cached sessions.

## Testing

Add regression coverage for delayed and new actions across model changes and catalog refreshes, required-review routing, and session reuse when policy or personality changes. Extend integration tests to cover reviewer reuse across parent model changes and verify that interrupted reviews cannot execute commands after a delayed approval arrives.

GitOrigin-RevId: 5b434568e113e44bf7177780f2ae13192b55e942

2026-09-10 16:17:25 +00:00

snapshots

Remove the unused legacy remote compaction implementation (#44273 )

2026-09-09 18:40:53 +00:00

abort_tasks.rs

Route rollout reads through the canonical JSON decoder (#42378 )

2026-09-02 22:45:19 +00:00

additional_context.rs

Update tests for default-enabled update_plan (#41630 )

2026-08-30 07:40:36 +00:00

agent_execution.rs

Honor environment-resolved workspace roots (#40912 )

2026-08-26 16:28:35 +00:00

agent_websocket.rs

Make the update_plan tool opt-in (#41744 )

2026-08-31 00:53:30 +00:00

agents_md.rs

Use StartThreadOptions across thread fork APIs (#44043 )

2026-09-09 04:07:40 +00:00

apply_patch_cli.rs

Standardize shell execution on unified exec (#39757 )

2026-08-20 17:46:05 +00:00

apply_patch_serialization.rs

Standardize shell execution on unified exec (#39757 )

2026-08-20 17:46:05 +00:00

approvals.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

audio_truncation.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

auto_review.rs

Route approvals through the extension decision API (#43432 )

2026-09-07 11:07:28 +00:00

catalog_permission_messages.rs

Source async user message descriptions from the model catalog (#41461 )

2026-08-29 03:44:01 +00:00

cli_stream.rs

Sanitize credentials from Git remote metadata (#40713 )

2026-08-25 21:34:05 +00:00

client_websockets.rs

Reset cached WebSocket state when auth ownership changes (#44489 )

2026-09-10 10:23:20 +00:00

client.rs

Remove the unused legacy remote compaction implementation (#44273 )

2026-09-09 18:40:53 +00:00

cloud_config.rs

Preserve target-native paths in command approvals (#42577 )

2026-09-03 16:21:10 +00:00

code_mode_elicitation.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

code_mode.rs

Harden Code Mode tool-call completeness tracking (#44472 )

2026-09-10 08:57:35 +00:00

codex_apps_protocol.rs

Give hosted Codex Apps an independent MCP protocol opt-in (#44318 )

2026-09-09 22:22:08 +00:00

codex_delegate.rs

Preserve MCP tool output as content items (#40737 )

2026-08-25 23:42:50 +00:00

collaboration_instructions.rs

Route rollout reads through the canonical JSON decoder (#42378 )

2026-09-02 22:45:19 +00:00

compact_remote_trimming.rs

Always use streamed remote compaction for supported providers (#44255 )

2026-09-09 18:04:04 +00:00

compact_remote.rs

Preserve incoming prompts when pre-turn compaction fails (#44487 )

2026-09-10 10:08:11 +00:00

compact_resume_fork.rs

Use StartThreadOptions across thread fork APIs (#44043 )

2026-09-09 04:07:40 +00:00

compact.rs

Remove the unused legacy remote compaction implementation (#44273 )

2026-09-09 18:40:53 +00:00

context_annotations.rs

Route approvals through the extension decision API (#43432 )

2026-09-07 11:07:28 +00:00

current_time_reminder.rs

Add configurable gating for the sleep tool (#41243 )

2026-08-28 02:09:07 +00:00

cyber_access_program.rs

Remove the unused legacy remote compaction implementation (#44273 )

2026-09-09 18:40:53 +00:00

cyber_exec_policy.rs

Standardize shell execution on unified exec (#39772 )

2026-08-20 18:29:35 +00:00

daybreak_access.rs

Attach verified access context to eligible plugin MCP calls (#41005 )

2026-08-27 00:02:26 +00:00

deprecation_notice.rs

Standardize shell execution on unified exec (#39772 )

2026-08-20 18:29:35 +00:00

exec_policy.rs

Honor environment-resolved workspace roots (#40912 )

2026-08-26 16:28:35 +00:00

exec.rs

Add network environment ID plumbing (#28766 )

2026-06-18 14:09:38 +02:00

extension_sandbox.rs

Expand extension permission regression coverage (#41946 )

2026-09-01 00:42:19 +00:00

external_auth.rs

Add AWS credential export commands for Amazon Bedrock (#44028 )

2026-09-09 03:17:48 +00:00

fork_thread.rs

Use StartThreadOptions across thread fork APIs (#44043 )

2026-09-09 04:07:40 +00:00

git_enrichment.rs

Establish root turn identity for independent tasks and memory requests (#42900 )

2026-09-05 01:04:12 +00:00

guardian_authorization.rs

Keep Guardian review evidence consistent and reject stale approvals (#43442 )

2026-09-07 11:51:20 +00:00

guardian_context_budget.rs

Preserve Guardian authorization evidence until request budgeting (#44570 )

2026-09-10 16:02:36 +00:00

guardian_history.rs

Use StartThreadOptions across thread fork APIs (#44043 )

2026-09-09 04:07:40 +00:00

guardian_mcp_elicitation.rs

Bound MCP descriptions separately from Guardian action JSON (#44493 )

2026-09-10 10:38:10 +00:00

guardian_retained_context.rs

Use StartThreadOptions across thread fork APIs (#44043 )

2026-09-09 04:07:40 +00:00

guardian_retry.rs

Improve Guardian retries and review failure reporting (#44482 )

2026-09-10 09:50:59 +00:00

guardian_review_cancellation.rs

Cancel Guardian reviews with their tool calls (#40021 )

2026-08-21 21:51:12 +00:00

guardian_review.rs

Use captured action settings for Guardian reviews (#44574 )

2026-09-10 16:17:25 +00:00

guardian_subagent_authorization.rs

Retain inherited Guardian instructions in standalone forks (#43478 )

2026-09-07 13:58:57 +00:00

hooks_executor.rs

Support app targets in executor plugin hooks (#41456 )

2026-08-29 03:14:35 +00:00

hooks_mcp.rs

Set working directories for environment MCP tests (#41683 )

2026-08-30 14:04:06 +00:00

hooks.rs

Update the forked-thread hook test to use StartThreadOptions (#44377 )

2026-09-10 02:23:36 +00:00

image_rollout.rs

Route rollout reads through the canonical JSON decoder (#42378 )

2026-09-02 22:45:19 +00:00

injected_models_cache.rs

Scope model catalog caches to the current provider and auth identity (#43906 )

2026-09-08 20:37:30 +00:00

interrupt_hooks.rs

Add hooks for interrupted turns (#40511 )

2026-08-25 01:27:18 +00:00

items.rs

Route rollout reads through the canonical JSON decoder (#42378 )

2026-09-02 22:45:19 +00:00

json_result.rs

Remove redundant test coverage (#42069 )

2026-09-01 15:04:11 +00:00

live_cli.rs

[codex] Use expect in integration tests (#28441 )

2026-06-15 21:53:47 -07:00

mcp_auth_elicitation.rs

Preserve MCP tool output as content items (#40737 )

2026-08-25 23:42:50 +00:00

mcp_auth_refresh.rs

Attach verified access context to eligible plugin MCP calls (#41005 )

2026-08-27 00:02:26 +00:00

mcp_extension_protocol.rs

Allow extensions to select MCP protocol mode per HTTP server (#44571 )

2026-09-10 16:02:59 +00:00

mcp_oauth_refresh_tests.rs

Preserve MCP authentication challenges on tool calls (#42552 )

2026-09-03 15:12:02 +00:00

mcp_optional_startup_grace.rs

Make the optional MCP startup grace configurable (#41199 )

2026-08-27 20:31:40 +00:00

mcp_refresh_cleanup.rs

Negotiate MCP extensions per app-server session (#36910 )

2026-08-04 15:23:43 +00:00

mcp_startup_refresh_http_proxy.rs

Honor environment-resolved workspace roots (#40912 )

2026-08-26 16:28:35 +00:00

mcp_tool_cache.rs

Reuse MCP bindings while cached servers remain dormant (#44121 )

2026-09-09 10:51:24 +00:00

mcp_tool_exposure.rs

Add MIME-filtered resource listing for Codex Apps (#44548 )

2026-09-10 14:22:21 +00:00

mcp_turn_metadata.rs

Bound MCP descriptions separately from Guardian action JSON (#44493 )

2026-09-10 10:38:10 +00:00

mcp_user_verification.rs

Restrict MCP user verification and add workspace-scoped identity (#43524 )

2026-09-07 17:26:10 +00:00

mod.rs

Allow extensions to select MCP protocol mode per HTTP server (#44571 )

2026-09-10 16:02:59 +00:00

model_overrides.rs

[5 of 7] Replace OverrideTurnContext with ThreadSettings (#22508 )

2026-05-18 21:03:51 -07:00

model_runtime_selectors.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

model_switching.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

model_visible_layout.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

models_cache_auth.rs

Add opt-in model discovery for OpenAI API keys (#44392 )

2026-09-10 03:18:28 +00:00

models_cache_ttl.rs

Scope model catalog caches to the current provider and auth identity (#43906 )

2026-09-08 20:37:30 +00:00

models_etag_responses.rs

Standardize shell execution on unified exec (#39757 )

2026-08-20 17:46:05 +00:00

multi_agent_mode.rs

Source proactive multi-agent instructions from the model catalog (#41457 )

2026-08-29 03:28:19 +00:00

multi_agent_resume.rs

Include unloaded children in multi-agent v2 environment context (#43491 )

2026-09-07 15:10:37 +00:00

multi_exec_server_sandbox.rs

Attach verified access context to eligible plugin MCP calls (#41005 )

2026-08-27 00:02:26 +00:00

network_approval_completion.rs

Handle pending network reviews after process completion (#42746 )

2026-09-04 12:08:02 +00:00

network_approval.rs

Close active network proxy connections on teardown (#43884 )

2026-09-08 18:40:17 +00:00

openai_file_mcp.rs

Preserve MCP tool output as content items (#40737 )

2026-08-25 23:42:50 +00:00

otel.rs

Remove selected core test cases (#42066 )

2026-09-01 14:43:27 +00:00

override_updates.rs

Pair thread environment settings (#26687 )

2026-06-08 13:55:15 -07:00

pending_input.rs

Remove the unused legacy remote compaction implementation (#44273 )

2026-09-09 18:40:53 +00:00

permissions_messages.rs

Use StartThreadOptions across thread fork APIs (#44043 )

2026-09-09 04:07:40 +00:00

personality.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

plugins.rs

Prefer remote Sites over the bundled plugin (#42100 )

2026-09-01 16:58:54 +00:00

prompt_cache_key.rs

Use session IDs for prompt cache keys (#33035 )

2026-07-14 10:37:23 +00:00

prompt_caching.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

prompt_debug_tests.rs

Enable git attribution across Codex entry points (#34819 )

2026-07-22 20:23:35 +00:00

quota_exceeded.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

realtime_conversation.rs

Record realtime conversation history in Core (#41924 )

2026-08-31 22:38:23 +00:00

realtime_initial_items.rs

Add a realtime delegation acknowledgement control (#36413 )

2026-08-01 01:17:26 +00:00

realtime_misalignment.rs

Add live WebRTC voice conversations to the TUI (#43581 )

2026-09-07 20:25:30 +00:00

realtime_sideband_endpoint.rs

Allow per-call sideband endpoints for existing realtime calls (#41923 )

2026-08-31 22:29:40 +00:00

reasoning_effort_override.rs

Preserve prewarmed reasoning effort across replay and early rollback (#44285 )

2026-09-09 19:38:24 +00:00

remote_env_failure_tests.rs

Surface environment startup failure reasons to the model (#44277 )

2026-09-09 18:50:32 +00:00

remote_env.rs

Surface environment startup failure reasons to the model (#44277 )

2026-09-09 18:50:32 +00:00

remote_models.rs

Add opt-in model discovery for OpenAI API keys (#44392 )

2026-09-10 03:18:28 +00:00

request_compression.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

request_permissions_tool.rs

Make permission transforms aware of executor path context (#41909 )

2026-08-31 20:50:44 +00:00

request_permissions.rs

Make permission transforms aware of executor path context (#41909 )

2026-08-31 20:50:44 +00:00

request_plugin_install.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

request_user_input_async.rs

Add free-form asynchronous user messages (#42354 )

2026-09-02 20:41:14 +00:00

request_user_input.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

responses_api_proxy_headers.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

responses_lite.rs

Always use streamed remote compaction for supported providers (#44255 )

2026-09-09 18:04:04 +00:00

responses_system_proxy.rs

Add opt-in model discovery for OpenAI API keys (#44392 )

2026-09-10 03:18:28 +00:00

resume_warning.rs

Persist disabled plugin IDs in thread settings (#44332 )

2026-09-09 23:23:59 +00:00

resume.rs

Use turn environment settings for sandbox execution (#40771 )

2026-08-26 03:28:57 +00:00

retry_after.rs

Add opt-in model discovery for OpenAI API keys (#44392 )

2026-09-10 03:18:28 +00:00

review.rs

Route rollout reads through the canonical JSON decoder (#42378 )

2026-09-02 22:45:19 +00:00

rmcp_client.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

rollout_budget.rs

Remove the unused legacy remote compaction implementation (#44273 )

2026-09-09 18:40:53 +00:00

rollout_compression.rs

Use StartThreadOptions across thread fork APIs (#44043 )

2026-09-09 04:07:40 +00:00

rollout_list_find.rs

Honor the configured SQLite home across state consumers (#34994 )

2026-07-23 19:19:35 +00:00

safety_buffering.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

safety_check_downgrade.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

search_tool.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

settings_commits.rs

Persist disabled plugin IDs in thread settings (#44332 )

2026-09-09 23:23:59 +00:00

settings_constraints.rs

Validate step settings against proposed permissions (#40647 )

2026-08-25 17:27:04 +00:00

shell_snapshot.rs

Protect shell snapshots when credential brokerage is enabled (#43909 )

2026-09-08 20:59:50 +00:00

skill_approval.rs

Standardize shell execution on unified exec (#39757 )

2026-08-20 17:46:05 +00:00

skills_extension.rs

Use captured step model settings for extension context (#44202 )

2026-09-09 16:48:49 +00:00

skills.rs

Reduce skill catalog prompts with path aliases (#41011 )

2026-08-27 01:22:23 +00:00

spawn_agent_description.rs

Gate experimental context by model capability at session startup (#43147 )

2026-09-06 02:28:38 +00:00

sqlite_state.rs

Preserve runtime workspace roots across thread resume (#43848 )

2026-09-08 16:24:38 +00:00

startup_cancellation.rs

Release persistent writers when session startup is cancelled (#44183 )

2026-09-09 15:54:07 +00:00

step_settings_compaction.rs

Always use streamed remote compaction for supported providers (#44255 )

2026-09-09 18:04:04 +00:00

step_settings_snapshots.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

step_settings.rs

Remove retired model entries while preserving migration prompts (#44250 )

2026-09-09 17:56:33 +00:00

stream_error_allows_next_turn.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

stream_no_completed.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

subagent_notifications.rs

Distinguish forked sessions in session-start hooks (#44349 )

2026-09-10 00:26:30 +00:00

subagent_service_tier.rs

Make subagents follow the root service tier (#41308 )

2026-08-28 09:48:13 +00:00

token_budget.rs

Always use streamed remote compaction for supported providers (#44255 )

2026-09-09 18:04:04 +00:00

token_usage_rollout.rs

Route rollout reads through the canonical JSON decoder (#42378 )

2026-09-02 22:45:19 +00:00

tool_harness.rs

Update tests for default-enabled update_plan (#41630 )

2026-08-30 07:40:36 +00:00

tool_lifecycle.rs

Set working directories for environment MCP tests (#41683 )

2026-08-30 14:04:06 +00:00

tool_parallelism.rs

Standardize shell execution on unified exec (#39757 )

2026-08-20 17:46:05 +00:00

tools.rs

Update tests for default-enabled update_plan (#41630 )

2026-08-30 07:40:36 +00:00

truncation.rs

Set working directories for environment MCP tests (#41683 )

2026-08-30 14:04:06 +00:00

turn_input_submission.rs

Gate new turn submissions on host shutdown admission (#43943 )

2026-09-08 23:45:10 +00:00

turn_state.rs

Preserve Markdown formatting when copying TUI responses (#42847 )

2026-09-04 20:38:08 +00:00

unified_exec_process_events.rs

Handle pending network reviews after process completion (#42746 )

2026-09-04 12:08:02 +00:00

unified_exec_stdin_approval.rs

Discount an approval's own code-mode wrapper from Guardian score lag (#43527 )

2026-09-07 17:35:23 +00:00

unified_exec_stdin_review_size.rs

Reject NUL bytes in reviewed terminal input (#41354 )

2026-08-28 15:44:48 +00:00

unified_exec_zsh_fork_approvals.rs

Discount an approval's own code-mode wrapper from Guardian score lag (#43527 )

2026-09-07 17:35:23 +00:00

unified_exec.rs

Stabilize subagent and unified exec test fixtures (#43936 )

2026-09-08 22:31:49 +00:00

unstable_features_warning.rs

Extract persisted history types into a dedicated crate (#37871 )

2026-08-10 19:26:52 +00:00

user_notification.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

user_shell_cmd.rs

Support configurable timeouts for thread shell commands (#41384 )

2026-08-28 18:07:40 +00:00

view_image.rs

Gate experimental context by model capability at session startup (#43147 )

2026-09-06 02:28:38 +00:00

web_search.rs

Add an Amazon Bedrock Runtime provider (#38470 )

2026-08-14 01:23:59 +00:00

websocket_fallback.rs

Unify turn input submission and routing (#38275 )

2026-08-13 00:00:16 +00:00

window_headers.rs

Use StartThreadOptions across thread fork APIs (#44043 )

2026-09-09 04:07:40 +00:00

windows_sandbox.rs

Prevent filesystem-root read denies in the Windows sandbox (#44327 )

2026-09-09 22:50:03 +00:00

workspace_roots.rs

Authorize apply_patch in the executor path context (#42391 )

2026-09-02 23:58:24 +00:00

worktree_trust.rs

Validate linked worktrees before inheriting project trust (#39616 )

2026-08-20 06:29:32 +00:00