Nick Felt 8452164c76 Mark finished empty Code Mode tool inventories as complete (#46081) ...

## Why

Code Mode cells that finish without invoking tools omit completeness metadata, leaving a verified empty inventory indistinguishable from an unverified one.

## What changed

- Retain completed, losslessly recorded cells even when they contain no tool calls.
- Always include `executed_tool_calls` when setting `tool_calls_complete`, using `[]` for empty inventories or terminal waits with no new calls.
- Preserve completeness across request retries while revalidating history and rejecting late calls or ambiguous output mappings.

## Testing

Add regression coverage for empty tool discovery, errors, termination, feature gating, retries, and fresh-session requirements for waits. Update protocol assertions to require an explicit empty call list with completeness metadata.

GitOrigin-RevId: 24affe47f46068b6559d04a0103958ae83a00b92

2026-09-17 02:18:05 +00:00

..

snapshots

Keep MCP user interaction on the root thread (#46066)

2026-09-17 01:18:37 +00:00

step_settings

Use captured step settings when spawning subagents (#46075)

2026-09-17 01:51:14 +00:00

abort_tasks.rs

Route rollout reads through the canonical JSON decoder (#42378)

2026-09-02 22:45:19 +00:00

additional_context.rs

Unify context snapshots and group requests into windows (#44932)

2026-09-11 22:55:38 +00:00

agent_execution.rs

Preserve root turn attribution in turn-start events (#44611)

2026-09-10 18:24:13 +00:00

agent_websocket.rs

Expose session analytics state in Responses turn metadata (#44628)

2026-09-10 19:41:14 +00:00

agents_md_refresh.rs

Add a provider for thread-scoped instructions (#44701)

2026-09-11 01:57:54 +00:00

agents_md.rs

Reject paths in project documentation fallback filenames (#45865)

2026-09-16 04:59:23 +00:00

app_tool_exposure.rs

Add per-app tool exposure configuration (#46035)

2026-09-16 21:50:07 +00:00

apply_patch_cli.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

apply_patch_serialization.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

approvals.rs

Remove retired model entries while preserving migration prompts (#44250)

2026-09-09 17:56:33 +00:00

audio_truncation.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

auto_review.rs

Expose available access programs in model discovery (#44893)

2026-09-11 19:13:04 +00:00

canonical_plugin_connectors.rs

Honor canonical plugin disables for shared connectors (#45755)

2026-09-15 18:23:08 +00:00

catalog_permission_messages.rs

Source async user message descriptions from the model catalog (#41461)

2026-08-29 03:44:01 +00:00

cli_stream.rs

Sanitize credentials from Git remote metadata (#40713)

2026-08-25 21:34:05 +00:00

client_websockets.rs

Track WebSocket continuation modes and full-input send reasons (#46051)

2026-09-16 22:43:57 +00:00

client.rs

Add workspace routing support for Responses requests (#45812)

2026-09-16 00:20:40 +00:00

cloud_config.rs

Preserve target-native paths in command approvals (#42577)

2026-09-03 16:21:10 +00:00

code_mode_elicitation.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

code_mode.rs

Mark finished empty Code Mode tool inventories as complete (#46081)

2026-09-17 02:18:05 +00:00

codex_apps_protocol.rs

Share Apps tool catalogs without retaining unused snapshots (#45440)

2026-09-14 15:06:28 +00:00

codex_delegate.rs

Preserve MCP tool output as content items (#40737)

2026-08-25 23:42:50 +00:00

collaboration_instructions.rs

Restore collaboration mode when resuming threads (#45519)

2026-09-14 21:33:45 +00:00

compact_remote_trimming.rs

Estimate history tokens from content instead of serialized envelopes (#45094)

2026-09-12 18:41:47 +00:00

compact_remote.rs

Account for file images in context budgets and Guardian reviews (#46072)

2026-09-17 01:38:13 +00:00

compact_resume_fork.rs

Remove the deprecated thread/rollback API (#44915)

2026-09-11 21:32:04 +00:00

compact.rs

Support image references by file ID in inputs and tool outputs (#45794)

2026-09-15 21:19:08 +00:00

context_annotations.rs

Support image references by file ID in inputs and tool outputs (#45794)

2026-09-15 21:19:08 +00:00

current_time_reminder.rs

Report clock failures again after recovery (#46006)

2026-09-16 18:54:45 +00:00

cyber_access_program.rs

Remove the unused legacy remote compaction implementation (#44273)

2026-09-09 18:40:53 +00:00

cyber_exec_policy.rs

Standardize shell execution on unified exec (#39772)

2026-08-20 18:29:35 +00:00

daybreak_access.rs

Attach verified access context to eligible plugin MCP calls (#41005)

2026-08-27 00:02:26 +00:00

deprecation_notice.rs

Standardize shell execution on unified exec (#39772)

2026-08-20 18:29:35 +00:00

direct_tool_metadata.rs

Bind direct tool-call metadata to invocation outputs (#45185)

2026-09-13 06:53:20 +00:00

exec_policy.rs

Honor environment-resolved workspace roots (#40912)

2026-08-26 16:28:35 +00:00

exec.rs

Wire the Windows MXC sandbox into command execution (#45176)

2026-09-13 06:07:03 +00:00

extension_sandbox.rs

Expand extension permission regression coverage (#41946)

2026-09-01 00:42:19 +00:00

external_auth.rs

Add AWS credential export commands for Amazon Bedrock (#44028)

2026-09-09 03:17:48 +00:00

fork_thread.rs

Expose disabled plugin settings in the app-server API (#44905)

2026-09-11 20:27:37 +00:00

git_enrichment.rs

Establish root turn identity for independent tasks and memory requests (#42900)

2026-09-05 01:04:12 +00:00

guardian_authorization.rs

Support image references by file ID in inputs and tool outputs (#45794)

2026-09-15 21:19:08 +00:00

guardian_checkpoint_migration_tests.rs

Centralize compaction checkpoint selection and validation (#46009)

2026-09-16 19:25:50 +00:00

guardian_context_budget.rs

Account for file images in context budgets and Guardian reviews (#46072)

2026-09-17 01:38:13 +00:00

guardian_history.rs

Support image references by file ID in inputs and tool outputs (#45794)

2026-09-15 21:19:08 +00:00

guardian_mcp_elicitation.rs

Preserve originating context for yielded code-mode tool calls (#44866)

2026-09-11 17:01:17 +00:00

guardian_retained_context.rs

Remove the deprecated thread/rollback API (#44915)

2026-09-11 21:32:04 +00:00

guardian_retry.rs

Improve Guardian retries and review failure reporting (#44482)

2026-09-10 09:50:59 +00:00

guardian_review_cancellation.rs

Tighten request handling in Guardian approval tests (#46041)

2026-09-16 22:25:29 +00:00

guardian_review.rs

Centralize model-message resolution and rendering in codex-prompts (#46026)

2026-09-16 21:01:13 +00:00

guardian_subagent_authorization.rs

Preserve Guardian evidence during checkpoint migration (#45789)

2026-09-15 20:41:39 +00:00

hooks_executor.rs

Allow browser app cleanup hooks on interrupt (#46029)

2026-09-16 21:15:09 +00:00

hooks_mcp.rs

Set working directories for environment MCP tests (#41683)

2026-08-30 14:04:06 +00:00

hooks.rs

Use captured step settings for request metadata and tool hooks (#45248)

2026-09-13 15:47:59 +00:00

image_rollout.rs

Account for file images in context budgets and Guardian reviews (#46072)

2026-09-17 01:38:13 +00:00

injected_models_cache.rs

Scope model catalog caches to the current provider and auth identity (#43906)

2026-09-08 20:37:30 +00:00

interrupt_hooks.rs

Add hooks for interrupted turns (#40511)

2026-08-25 01:27:18 +00:00

items.rs

Support image references by file ID in inputs and tool outputs (#45794)

2026-09-15 21:19:08 +00:00

json_result.rs

Remove redundant test coverage (#42069)

2026-09-01 15:04:11 +00:00

live_cli.rs

…

managed_threads_tests.rs

Add startup tool allowlists for threads (#45711)

2026-09-15 14:45:35 +00:00

mcp_auth_elicitation.rs

Keep MCP user interaction on the root thread (#46066)

2026-09-17 01:18:37 +00:00

mcp_auth_refresh.rs

Keep MCP user interaction on the root thread (#46066)

2026-09-17 01:18:37 +00:00

mcp_ema_config.rs

Resolve enterprise-managed MCP registrations in the catalog (#45459)

2026-09-14 16:30:00 +00:00

mcp_extension_protocol.rs

Allow hosted Apps MCP contributions to override the protocol mode (#46019)

2026-09-16 20:32:52 +00:00

mcp_oauth_refresh_tests.rs

Preserve MCP authentication challenges on tool calls (#42552)

2026-09-03 15:12:02 +00:00

mcp_optional_startup_grace.rs

Make the optional MCP startup grace configurable (#41199)

2026-08-27 20:31:40 +00:00

mcp_refresh_cleanup.rs

Negotiate MCP extensions per app-server session (#36910)

2026-08-04 15:23:43 +00:00

mcp_startup_refresh_http_proxy.rs

Add trusted enterprise MCP auth configuration (#44832)

2026-09-11 14:25:56 +00:00

mcp_subagent_elicitation.rs

Keep MCP user interaction on the root thread (#46066)

2026-09-17 01:18:37 +00:00

mcp_tool_cache.rs

Allow hosted Apps MCP contributions to override the protocol mode (#46019)

2026-09-16 20:32:52 +00:00

mcp_tool_exposure.rs

Allow hosted Apps MCP contributions to override the protocol mode (#46019)

2026-09-16 20:32:52 +00:00

mcp_turn_metadata.rs

Preserve MCP App UI metadata in tool-call events and history (#45805)

2026-09-15 22:52:56 +00:00

mcp_user_verification.rs

Restrict MCP user verification and add workspace-scoped identity (#43524)

2026-09-07 17:26:10 +00:00

mod.rs

Keep MCP user interaction on the root thread (#46066)

2026-09-17 01:18:37 +00:00

model_overrides.rs

…

model_provider_requirements_tests.rs

Add workspace routing support for Responses requests (#45812)

2026-09-16 00:20:40 +00:00

model_runtime_selectors.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

model_switching.rs

Centralize model-message resolution and rendering in codex-prompts (#46026)

2026-09-16 21:01:13 +00:00

model_visible_layout.rs

Retire the personality feature flag and document deprecated settings (#45809)

2026-09-15 23:39:40 +00:00

models_cache_auth.rs

Add opt-in model discovery for OpenAI API keys (#44392)

2026-09-10 03:18:28 +00:00

models_cache_ttl.rs

Avoid redundant model catalog lookups in reused Guardian reviewers (#45933)

2026-09-16 12:09:50 +00:00

models_etag_responses.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

multi_agent_mode.rs

Source proactive multi-agent instructions from the model catalog (#41457)

2026-08-29 03:28:19 +00:00

multi_agent_resume.rs

Include unloaded children in multi-agent v2 environment context (#43491)

2026-09-07 15:10:37 +00:00

multi_exec_server_sandbox.rs

Attach verified access context to eligible plugin MCP calls (#41005)

2026-08-27 00:02:26 +00:00

network_approval_completion.rs

Handle pending network reviews after process completion (#42746)

2026-09-04 12:08:02 +00:00

network_approval.rs

Tighten request handling in Guardian approval tests (#46041)

2026-09-16 22:25:29 +00:00

openai_file_mcp.rs

Preserve MCP tool output as content items (#40737)

2026-08-25 23:42:50 +00:00

otel.rs

Remove selected core test cases (#42066)

2026-09-01 14:43:27 +00:00

override_updates.rs

…

pending_input_persistence.rs

Allow background persistence for steered user input (#45506)

2026-09-14 19:39:31 +00:00

pending_input.rs

Unify context snapshots and group requests into windows (#44932)

2026-09-11 22:55:38 +00:00

permissions_messages.rs

Centralize model-message resolution and rendering in codex-prompts (#46026)

2026-09-16 21:01:13 +00:00

personality.rs

Retire the personality feature flag and document deprecated settings (#45809)

2026-09-15 23:39:40 +00:00

plugins.rs

Honor thread-level plugin exclusions across runtime capabilities (#44655)

2026-09-10 21:51:34 +00:00

prompt_cache_key.rs

Preserve parent cache affinity for ephemeral forks (#44862)

2026-09-11 16:41:56 +00:00

prompt_caching.rs

Centralize model-message resolution and rendering in codex-prompts (#46026)

2026-09-16 21:01:13 +00:00

prompt_debug_tests.rs

Enable git attribution across Codex entry points (#34819)

2026-07-22 20:23:35 +00:00

quota_exceeded.rs

Fix retry classification for throttling and quota errors (#45602)

2026-09-15 04:20:38 +00:00

realtime_conversation.rs

Record realtime conversation history in Core (#41924)

2026-08-31 22:38:23 +00:00

realtime_initial_items.rs

Add a realtime delegation acknowledgement control (#36413)

2026-08-01 01:17:26 +00:00

realtime_misalignment.rs

Add live WebRTC voice conversations to the TUI (#43581)

2026-09-07 20:25:30 +00:00

realtime_sideband_endpoint.rs

Allow per-call sideband endpoints for existing realtime calls (#41923)

2026-08-31 22:29:40 +00:00

reasoning_effort_override.rs

Remove the deprecated thread/rollback API (#44915)

2026-09-11 21:32:04 +00:00

remote_env_failure_tests.rs

Surface environment startup failure reasons to the model (#44277)

2026-09-09 18:50:32 +00:00

remote_env.rs

Preserve attachment Unix socket grants when controller policy is omitted (#46004)

2026-09-16 18:21:22 +00:00

remote_models.rs

Centralize model-message resolution and rendering in codex-prompts (#46026)

2026-09-16 21:01:13 +00:00

request_compression.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

request_permissions_tool.rs

Make permission transforms aware of executor path context (#41909)

2026-08-31 20:50:44 +00:00

request_permissions.rs

Make permission transforms aware of executor path context (#41909)

2026-08-31 20:50:44 +00:00

request_plugin_install.rs

Restrict plugin install requests to the root thread (#45806)

2026-09-15 23:00:48 +00:00

request_user_input_async.rs

Add a feature flag for asynchronous user messages (#45124)

2026-09-12 22:28:41 +00:00

request_user_input.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

responses_api_proxy_headers.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

responses_lite.rs

Support image references by file ID in inputs and tool outputs (#45794)

2026-09-15 21:19:08 +00:00

responses_system_proxy.rs

Add opt-in model discovery for OpenAI API keys (#44392)

2026-09-10 03:18:28 +00:00

resume_warning.rs

Preserve root turn attribution in turn-start events (#44611)

2026-09-10 18:24:13 +00:00

resume.rs

Use turn environment settings for sandbox execution (#40771)

2026-08-26 03:28:57 +00:00

retry_after.rs

Fix retry classification for throttling and quota errors (#45602)

2026-09-15 04:20:38 +00:00

review.rs

Route rollout reads through the canonical JSON decoder (#42378)

2026-09-02 22:45:19 +00:00

rmcp_client.rs

Preserve MCP App UI metadata in tool-call events and history (#45805)

2026-09-15 22:52:56 +00:00

rollout_budget.rs

Remove the deprecated thread/rollback API (#44915)

2026-09-11 21:32:04 +00:00

rollout_compression.rs

Use StartThreadOptions across thread fork APIs (#44043)

2026-09-09 04:07:40 +00:00

rollout_list_find.rs

Honor the configured SQLite home across state consumers (#34994)

2026-07-23 19:19:35 +00:00

safety_buffering.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

safety_check_downgrade.rs

Remove retired model entries while preserving migration prompts (#44250)

2026-09-09 17:56:33 +00:00

scenarios_read_only_mcp.rs

Add read-only policy support to MCP tool requests (#46042)

2026-09-16 22:25:54 +00:00

scenarios.rs

Keep MCP user interaction on the root thread (#46066)

2026-09-17 01:18:37 +00:00

search_tool.rs

Remove retired model entries while preserving migration prompts (#44250)

2026-09-09 17:56:33 +00:00

settings_commits.rs

Persist disabled plugin IDs in thread settings (#44332)

2026-09-09 23:23:59 +00:00

settings_constraints.rs

Validate step settings against proposed permissions (#40647)

2026-08-25 17:27:04 +00:00

shell_snapshot.rs

Protect shell snapshots when credential brokerage is enabled (#43909)

2026-09-08 20:59:50 +00:00

skill_approval.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

skills_extension.rs

Suppress warnings when skill descriptions are shortened (#46070)

2026-09-17 01:28:24 +00:00

skills.rs

Reduce skill catalog prompts with path aliases (#41011)

2026-08-27 01:22:23 +00:00

spawn_agent_description.rs

Expose available access programs in model discovery (#44893)

2026-09-11 19:13:04 +00:00

sqlite_state.rs

Preserve runtime workspace roots across thread resume (#43848)

2026-09-08 16:24:38 +00:00

startup_cancellation.rs

Release persistent writers when session startup is cancelled (#44183)

2026-09-09 15:54:07 +00:00

step_settings_compaction.rs

Always use streamed remote compaction for supported providers (#44255)

2026-09-09 18:04:04 +00:00

step_settings_snapshots.rs

Remove retired model entries while preserving migration prompts (#44250)

2026-09-09 17:56:33 +00:00

step_settings.rs

Use captured step settings when spawning subagents (#46075)

2026-09-17 01:51:14 +00:00

stream_error_allows_next_turn.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

stream_no_completed.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

subagent_notifications.rs

Use captured step settings when spawning subagents (#46075)

2026-09-17 01:51:14 +00:00

subagent_service_tier.rs

Make subagents follow the root service tier (#41308)

2026-08-28 09:48:13 +00:00

token_budget.rs

Unify context snapshots and group requests into windows (#44932)

2026-09-11 22:55:38 +00:00

token_usage_rollout.rs

Route rollout reads through the canonical JSON decoder (#42378)

2026-09-02 22:45:19 +00:00

tool_harness.rs

Update tests for default-enabled update_plan (#41630)

2026-08-30 07:40:36 +00:00

tool_lifecycle.rs

Set working directories for environment MCP tests (#41683)

2026-08-30 14:04:06 +00:00

tool_parallelism.rs

Standardize shell execution on unified exec (#39757)

2026-08-20 17:46:05 +00:00

tools.rs

Bind direct tool-call metadata to invocation outputs (#45185)

2026-09-13 06:53:20 +00:00

truncation.rs

Set working directories for environment MCP tests (#41683)

2026-08-30 14:04:06 +00:00

turn_input_submission.rs

Continue interrupted work after managed daemon restarts (#45820)

2026-09-16 00:54:58 +00:00

turn_state.rs

Preserve Markdown formatting when copying TUI responses (#42847)

2026-09-04 20:38:08 +00:00

unified_exec_process_events.rs

Handle pending network reviews after process completion (#42746)

2026-09-04 12:08:02 +00:00

unified_exec_stdin_approval.rs

Discount an approval's own code-mode wrapper from Guardian score lag (#43527)

2026-09-07 17:35:23 +00:00

unified_exec_stdin_review_size.rs

Reject NUL bytes in reviewed terminal input (#41354)

2026-08-28 15:44:48 +00:00

unified_exec_zsh_fork_approvals.rs

Discount an approval's own code-mode wrapper from Guardian score lag (#43527)

2026-09-07 17:35:23 +00:00

unified_exec.rs

Stabilize subagent and unified exec test fixtures (#43936)

2026-09-08 22:31:49 +00:00

unstable_features_warning.rs

Extract persisted history types into a dedicated crate (#37871)

2026-08-10 19:26:52 +00:00

user_notification.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

user_shell_cmd.rs

Support configurable timeouts for thread shell commands (#41384)

2026-08-28 18:07:40 +00:00

view_image.rs

Expose available access programs in model discovery (#44893)

2026-09-11 19:13:04 +00:00

web_search.rs

Add an Amazon Bedrock Runtime provider (#38470)

2026-08-14 01:23:59 +00:00

websocket_fallback.rs

Unify turn input submission and routing (#38275)

2026-08-13 00:00:16 +00:00

window_headers.rs

Use StartThreadOptions across thread fork APIs (#44043)

2026-09-09 04:07:40 +00:00

windows_sandbox.rs

Wire the Windows MXC sandbox into command execution (#45176)

2026-09-13 06:07:03 +00:00

workspace_roots.rs

Authorize apply_patch in the executor path context (#42391)

2026-09-02 23:58:24 +00:00

worktree_trust.rs

Validate linked worktrees before inheriting project trust (#39616)

2026-08-20 06:29:32 +00:00