mirror of
https://github.com/openai/codex.git
synced 2026-10-15 16:48:52 +00:00
Anil KarakaandMichael Bolin
76a979007e
This Pull Request addresses an issue where the output of commands executed in the raw-exec utility was being truncated due to restrictive limits on the number of lines and bytes collected. The truncation caused the message [Output truncated: too many lines or bytes] to appear when processing large outputs, which could hinder the functionality of the CLI. Changes Made Increased the maximum output limits in the [createTruncatingCollector](https://github.com/openai/codex/pull/575) utility: Bytes: Increased from 10 KB to 100 KB. Lines: Increased from 256 lines to 1024 lines. Installed the @types/node package to resolve missing type definitions for [NodeJS](https://github.com/openai/codex/pull/575) and [Buffer](https://github.com/openai/codex/pull/575). Verified and fixed any related errors in the [createTruncatingCollector](https://github.com/openai/codex/pull/575) implementation. Issue Solved: This PR ensures that larger outputs can be processed without truncation, improving the usability of the CLI for commands that generate extensive output. https://github.com/openai/codex/issues/509 --------- Co-authored-by: Michael Bolin <bolinfest@gmail.com>
69 lines
2.4 KiB
TypeScript
69 lines
2.4 KiB
TypeScript
import { describe, it, expect, vi } from "vitest";
|
||
|
||
// ---------------------------------------------------------------------------
|
||
// Low‑level rawExec test ------------------------------------------------------
|
||
// ---------------------------------------------------------------------------
|
||
|
||
import { exec as rawExec } from "../src/utils/agent/sandbox/raw-exec.js";
|
||
import type { AppConfig } from "../src/utils/config.js";
|
||
describe("rawExec – invalid command handling", () => {
|
||
it("resolves with non‑zero exit code when executable is missing", async () => {
|
||
const cmd = ["definitely-not-a-command-1234567890"];
|
||
const config = { model: "any", instructions: "" } as AppConfig;
|
||
const result = await rawExec(cmd, {}, config);
|
||
|
||
expect(result.exitCode).not.toBe(0);
|
||
expect(result.stderr.length).toBeGreaterThan(0);
|
||
});
|
||
});
|
||
|
||
// ---------------------------------------------------------------------------
|
||
// Higher‑level handleExecCommand test ----------------------------------------
|
||
// ---------------------------------------------------------------------------
|
||
|
||
// Mock approvals and logging helpers so the test focuses on execution flow.
|
||
vi.mock("../src/approvals.js", () => {
|
||
return {
|
||
__esModule: true,
|
||
canAutoApprove: () =>
|
||
({ type: "auto-approve", runInSandbox: false }) as any,
|
||
isSafeCommand: () => null,
|
||
};
|
||
});
|
||
|
||
vi.mock("../src/format-command.js", () => {
|
||
return {
|
||
__esModule: true,
|
||
formatCommandForDisplay: (cmd: Array<string>) => cmd.join(" "),
|
||
};
|
||
});
|
||
|
||
vi.mock("../src/utils/agent/log.js", () => ({
|
||
__esModule: true,
|
||
log: () => {},
|
||
isLoggingEnabled: () => false,
|
||
}));
|
||
|
||
import { handleExecCommand } from "../src/utils/agent/handle-exec-command.js";
|
||
|
||
describe("handleExecCommand – invalid executable", () => {
|
||
it("returns non‑zero exit code for 'git show' as a single argv element", async () => {
|
||
const execInput = { cmd: ["git show"] } as any;
|
||
const config = { model: "any", instructions: "" } as any;
|
||
const policy = { mode: "auto" } as any;
|
||
const getConfirmation = async () => ({ review: "yes" }) as any;
|
||
|
||
const additionalWritableRoots: Array<string> = [];
|
||
const { outputText, metadata } = await handleExecCommand(
|
||
execInput,
|
||
config,
|
||
policy,
|
||
additionalWritableRoots,
|
||
getConfirmation,
|
||
);
|
||
|
||
expect(metadata["exit_code"]).not.toBe(0);
|
||
expect(String(outputText).length).toBeGreaterThan(0);
|
||
});
|
||
});
|