Commit Graph
15416 Commits
Author SHA1 Message Date
Michael Bolin e6f85386fa merge commit for archive created by Sapling 2026-05-12 23:51:49 -07:00
Michael Bolin eef356e238 app-server: select permission profiles by id 2026-05-12 23:51:37 -07:00
Michael Bolin e7b1a2d5f7 merge commit for archive created by Sapling 2026-05-12 23:31:25 -07:00
Michael Bolin 44e22e8ea2 permissions: move workspace roots onto thread state 2026-05-12 23:31:09 -07:00
Michael Bolin f95c19c33b app-server: select permission profiles by id 2026-05-12 23:31:09 -07:00
Michael Bolin f640c430b5 merge commit for archive created by Sapling 2026-05-12 23:23:12 -07:00
Michael Bolin 2585b32f0c app-server: select permission profiles by id 2026-05-12 23:22:56 -07:00
Michael Bolin 8a76af2354 permissions: move workspace roots onto thread state 2026-05-12 23:22:56 -07:00
Michael Bolin b23295ee53 merge commit for archive created by Sapling 2026-05-12 23:19:43 -07:00
Michael Bolin 188df1b0be app-server: select permission profiles by id 2026-05-12 23:19:28 -07:00
Michael Bolin 11ecd131a5 Merge aa3919e2f2 into sapling-pr-archive-bolinfest 2026-05-12 23:12:03 -07:00
Michael Bolin aa3919e2f2 app-server: select permission profiles by id 2026-05-12 23:11:55 -07:00
Michael Bolin 2456f219aa merge commit for archive created by Sapling 2026-05-12 23:06:18 -07:00
Michael Bolin 61a87ea47e app-server: select permission profiles by id 2026-05-12 23:06:09 -07:00
Michael Bolin acb6480b99 merge commit for archive created by Sapling 2026-05-12 22:56:23 -07:00
Michael Bolin e184006ac1 permissions: move workspace roots onto thread state 2026-05-12 22:56:05 -07:00
Michael Bolin f16281d88f app-server: select permission profiles by id 2026-05-12 22:56:05 -07:00
Michael Bolin ab840548be merge commit for archive created by Sapling 2026-05-12 22:31:14 -07:00
Michael Bolin 8ce7db8f24 app-server: select permission profiles by id 2026-05-12 22:30:12 -07:00
Michael Bolin c8fdaaf27a permissions: move workspace roots onto thread state 2026-05-12 22:30:12 -07:00
Michael Bolin ad02aba15d merge commit for archive created by Sapling 2026-05-12 22:24:46 -07:00
Michael Bolin 802324c6c3 app-server: select permission profiles by id 2026-05-12 22:24:29 -07:00
Michael Bolin d3c1ea7c8d permissions: move workspace roots onto thread state 2026-05-12 22:24:29 -07:00
Michael Bolin 5cf1e7475f merge commit for archive created by Sapling 2026-05-12 22:14:33 -07:00
Michael Bolin 0d1bfb2fd0 app-server: select permission profiles by id 2026-05-12 22:14:13 -07:00
Michael Bolin 7aa7447a22 permissions: move workspace roots onto thread state 2026-05-12 21:53:10 -07:00
Michael Bolin 81b67c2010 Merge 1bb4cb8c3e into sapling-pr-archive-bolinfest 2026-05-12 20:52:44 -07:00
Michael Bolin 1bb4cb8c3e app-server: select permission profiles by id 2026-05-12 20:52:33 -07:00
Michael Bolin b9f3284154 permissions: move workspace roots onto thread state 2026-05-12 20:52:33 -07:00
Michael Bolin 64eb789b69 Merge f965330129 into sapling-pr-archive-bolinfest 2026-05-12 20:49:05 -07:00
Michael Bolin 574c05092e merge commit for archive created by Sapling 2026-05-12 20:44:12 -07:00
Michael Bolin f965330129 app-server: select permission profiles by id 2026-05-12 20:43:36 -07:00
Michael Bolin bb7678219f permissions: move workspace roots onto thread state 2026-05-12 20:43:36 -07:00
Michael Bolin e724623361 Merge 24f01e177a into sapling-pr-archive-bolinfest 2026-05-12 20:23:59 -07:00
Michael Bolin 24f01e177a app-server: select permission profiles by id 2026-05-12 20:23:47 -07:00
Michael Bolin 7336736f44 permissions: move workspace roots onto thread state 2026-05-12 20:15:26 -07:00
Michael Bolin 71ad17cbba Merge 03e72f10d8 into sapling-pr-archive-bolinfest 2026-05-12 20:03:20 -07:00
Michael Bolin 82e4981273 merge commit for archive created by Sapling 2026-05-12 20:02:52 -07:00
Michael Bolin 03e72f10d8 app-server: select permission profiles by id 2026-05-12 20:02:33 -07:00
Michael Bolin e929d21081 permissions: move workspace roots onto thread state 2026-05-12 20:01:38 -07:00
Michael Bolin b0134794d8 Merge 73d36f01e9 into sapling-pr-archive-bolinfest 2026-05-12 19:27:10 -07:00
Michael Bolin 38c1741025 merge commit for archive created by Sapling 2026-05-12 19:26:42 -07:00
Michael Bolin 73d36f01e9 app-server: select permission profiles by id 2026-05-12 19:26:18 -07:00
Michael Bolin 42689ffc1e permissions: move workspace roots onto thread state 2026-05-12 19:24:18 -07:00
Andrei Eternal fbfbfe5fc5 hooks: use new session IDs instead of thread IDs for hooks, apply parent's session ID to subagents' hooks (#22268)
## Why

hook semantics treat `session_id` as shared across a root session and
its subagents. Codex hooks were still emitting the current thread ID,
which made spawned agents look like independent sessions and made it
harder for hook integrations to correlate work across a root thread and
its spawned helpers

This change makes hooks use Codex's existing shared session identity so
hook `session_id` matches the root-thread session across spawned
subagents.

## What Changed

- switch hook payloads to use the existing shared session identity from
core instead of the current thread ID
- cover all hook surfaces that expose `session_id`, including
`SessionStart`, tool hooks, compact hooks, prompt-submit hooks, stop
hooks, and legacy after-agent dispatch
2026-05-12 19:05:10 -07:00
Celia Chen e2eb7c30fe feat: route guardian review model selection through providers (#22258)
## Why

Guardian review selection was hard-coded in `core`, which worked for the
default OpenAI path but did not give provider implementations a way to
choose backend-specific reviewer model IDs. That matters for Amazon
Bedrock: guardian review should run through the Bedrock/Mantle provider
using Bedrock's `openai.gpt-5.4` model ID, instead of accidentally
selecting a reviewer model that implies the OpenAI backend.

## What Changed

- Added provider-owned approval review model selection via
`ModelProvider::approval_review_model_selection`.
- Moved the existing default selection policy into the provider
abstraction: prefer the requested reviewer model when it is available,
otherwise fall back to the active turn model, preferring `Low` reasoning
when supported.
- Added an Amazon Bedrock override that pins guardian review to
`openai.gpt-5.4` with `Low` reasoning.
2026-05-13 01:55:46 +00:00
Eric Traut 51bfb5f3b1 Restore app-server websocket listener with auth guard (#22404)
## Why
PR #21843 removed the TCP websocket app-server listener, but that also
removed functionality that still needs to exist. Restoring it as-is
would reopen the old remote exposure problem, so this keeps the restored
listener while making remote and non-loopback usage require explicit
auth.

## What Changed
- Mostly reverts #21843 and reapplies the small merge-conflict
resolutions needed on top of current main.
- Restores ws://IP:PORT parsing, the app-server TCP websocket acceptor,
websocket auth CLI flags, and the associated tests.
- The only intentional behavior change from the restored code is that
non-loopback websocket listeners now fail startup unless --ws-auth
capability-token or --ws-auth signed-bearer-token is configured.
Loopback listeners remain available for local and SSH-forwarding
workflows.

## Reviewer Focus
Please focus review on the small auth-enforcement delta layered on top
of the revert:

- codex-rs/app-server-transport/src/transport/websocket.rs:
start_websocket_acceptor now rejects unauthenticated non-loopback
websocket binds before accepting connections.
- codex-rs/app-server-transport/src/transport/auth.rs: helper logic
classifies unauthenticated non-loopback listeners.
- codex-rs/app-server/tests/suite/v2/connection_handling_websocket.rs:
tests cover unauthenticated ws://0.0.0.0 startup rejection and
authenticated non-loopback capability-token startup.

Everything else is intended to be revert/merge-conflict restoration
rather than new product behavior.

## Verification

- Manually verified that TUI remoting is restored and that auth is
enforced for non-localhost urls.
2026-05-12 18:40:53 -07:00
Michael Bolin 8a75001bfb merge commit for archive created by Sapling 2026-05-12 18:28:43 -07:00
Michael Bolin 4d1ad0b7f9 config: add strict config parsing 2026-05-12 18:28:35 -07:00
Michael Bolin 2dcae67ab3 merge commit for archive created by Sapling 2026-05-12 18:06:50 -07:00