Commit Graph

8167 Commits

Author SHA1 Message Date
Michael Bolin
de87bc8a42 merge commit for archive created by Sapling 2026-02-23 00:25:44 -08:00
Michael Bolin
056ddb789b feat: split core business logic from exec-server to shell-escalation 2026-02-23 00:06:00 -08:00
Michael Bolin
2b9d728e90 merge commit for archive created by Sapling 2026-02-22 23:48:41 -08:00
Michael Bolin
7cbc2e024a feat: split core business logic from exec-server to shell-escalation 2026-02-22 23:48:36 -08:00
Michael Bolin
ab26c80df3 merge commit for archive created by Sapling 2026-02-22 23:40:02 -08:00
Michael Bolin
a8b8c82787 feat: split core business logic from exec-server to shell-escalation 2026-02-22 23:39:49 -08:00
Michael Bolin
ef0dbe3a48 Merge 50b74d84eb into sapling-pr-archive-bolinfest 2026-02-22 23:17:51 -08:00
Michael Bolin
50b74d84eb feat: refactor logic in exec-server for general use 2026-02-22 23:17:37 -08:00
Michael Bolin
d1e6aba028 merge commit for archive created by Sapling 2026-02-22 20:01:11 -08:00
Michael Bolin
4cfc116d7f refactor: unify zsh fork shell tool with fd-based bridge 2026-02-22 20:01:03 -08:00
Michael Bolin
e8949f4507 test: vendor zsh fork via DotSlash and stabilize zsh-fork tests (#12518)
## Why

The zsh integration tests were still brittle in two ways:

- they relied on `CODEX_TEST_ZSH_PATH` / environment-specific setup, so
they often did not exercise the patched zsh fork that `shell-tool-mcp`
ships
- once the tests consistently used the vendored zsh fork, they exposed
real Linux-specific zsh-fork issues in CI

In particular, the Linux failures were not just test noise:

- the zsh-fork launch path was dropping `ExecRequest.arg0`, so Linux
`codex-linux-sandbox` arg0 dispatch did not run and zsh wrapper-mode
could receive malformed arguments
- the
`turn_start_shell_zsh_fork_subcommand_decline_marks_parent_declined_v2`
test uses the zsh exec bridge (which talks to the parent over a Unix
socket), but Linux restricted sandbox seccomp denies `connect(2)`,
causing timeouts on `ubuntu-24.04` x86/arm

This PR makes the zsh tests consistently run against the intended
vendored zsh fork and fixes/hardens the zsh-fork path so the Linux CI
signal is meaningful.

## What Changed

- Added a single shared test-only DotSlash file for the patched zsh fork
at `codex-rs/exec-server/tests/suite/zsh` (analogous to the existing
`bash` test resource).
- Updated both app-server and exec-server zsh tests to use that shared
DotSlash zsh (no duplicate zsh DotSlash file, no `CODEX_TEST_ZSH_PATH`
dependency).
- Updated the app-server zsh-fork test helper to resolve the shared
DotSlash zsh and avoid silently falling back to host zsh.
- Kept the app-server zsh-fork tests configured via `config.toml`, using
a test wrapper path where needed to force `zsh -df` (and rewrite `-lc`
to `-c`) for the subcommand-decline test.
- Hardened the app-server subcommand-decline zsh-fork test for CI
variability:
  - tolerate an extra `/responses` POST with a no-op mock response
- tolerate non-target approval ordering while remaining strict on the
two `/usr/bin/true` approvals and decline behavior
- use `DangerFullAccess` on Linux for this one test because it validates
zsh approval flow, not Linux sandbox socket restrictions
- Fixed zsh-fork process launching on Linux by preserving `req.arg0` in
`ZshExecBridge::execute_shell_request(...)` so `codex-linux-sandbox`
arg0 dispatch continues to work.
- Moved `maybe_run_zsh_exec_wrapper_mode()` under
`arg0_dispatch_or_else(...)` in `app-server` and `cli` so wrapper-mode
handling coexists correctly with arg0-dispatched helper modes.
- Consolidated duplicated `dotslash -- fetch` resolution logic into
shared test support (`core/tests/common/lib.rs`).
- Updated `codex-rs/exec-server/tests/suite/accept_elicitation.rs` to
use DotSlash zsh and hardened the zsh elicitation test for Bazel/zsh
differences by:
  - resolving an absolute `git` path
  - running `git init --quiet .`
- asserting success / `.git` creation instead of relying on banner text

## Verification

- `cargo test -p codex-app-server turn_start_zsh_fork -- --nocapture`
- `cargo test -p codex-exec-server accept_elicitation -- --nocapture`
- `bazel test //codex-rs/exec-server:exec-server-all-test
--test_output=streamed --test_arg=--nocapture
--test_arg=accept_elicitation_for_prompt_rule_with_zsh`
- CI (`rust-ci`) on the final cleaned commit: `Tests — ubuntu-24.04 -
x86_64-unknown-linux-gnu` and `Tests — ubuntu-24.04-arm -
aarch64-unknown-linux-gnu` passed in [run
22291424358](https://github.com/openai/codex/actions/runs/22291424358)
2026-02-22 19:39:56 -08:00
Michael Bolin
af4695422f merge commit for archive created by Sapling 2026-02-22 19:03:47 -08:00
Michael Bolin
d158fc8e5a feat: use DotSlash to fetch zsh fork for tests 2026-02-22 19:03:36 -08:00
Michael Bolin
398556bf1a Merge c8e94229e6 into sapling-pr-archive-bolinfest 2026-02-22 18:49:37 -08:00
Michael Bolin
c8e94229e6 feat: use DotSlash to fetch zsh fork for tests 2026-02-22 18:49:30 -08:00
Michael Bolin
5d7feebe6d Merge 1659e2b563 into sapling-pr-archive-bolinfest 2026-02-22 18:36:34 -08:00
Michael Bolin
1659e2b563 feat: use DotSlash to fetch zsh fork for tests 2026-02-22 18:36:28 -08:00
Michael Bolin
ee998ba202 merge commit for archive created by Sapling 2026-02-22 18:25:17 -08:00
Michael Bolin
6eca037ca6 feat: use DotSlash to fetch zsh fork for tests 2026-02-22 18:25:06 -08:00
Michael Bolin
0a4d77373f merge commit for archive created by Sapling 2026-02-22 17:58:44 -08:00
Michael Bolin
706dec6b66 feat: use DotSlash to fetch zsh fork for tests 2026-02-22 17:58:40 -08:00
Michael Bolin
28d7587de4 merge commit for archive created by Sapling 2026-02-22 17:44:37 -08:00
Michael Bolin
ac80a626de feat: use DotSlash to fetch zsh fork for tests 2026-02-22 17:44:29 -08:00
Michael Bolin
1243ba644a Merge 719dd7e0e2 into sapling-pr-archive-bolinfest 2026-02-22 17:26:51 -08:00
Michael Bolin
719dd7e0e2 feat: use DotSlash to fetch zsh fork for tests 2026-02-22 17:26:48 -08:00
Michael Bolin
10a6cdba1d Merge 2aa40942af into sapling-pr-archive-bolinfest 2026-02-22 17:23:02 -08:00
Michael Bolin
2aa40942af feat: use DotSlash to fetch zsh fork for tests 2026-02-22 17:22:58 -08:00
Michael Bolin
aa7b86b2ad merge commit for archive created by Sapling 2026-02-22 17:21:04 -08:00
Michael Bolin
79b1dd88df feat: use DotSlash to fetch zsh fork for tests 2026-02-22 17:20:59 -08:00
Michael Bolin
008a77f3c5 merge commit for archive created by Sapling 2026-02-22 17:20:39 -08:00
Michael Bolin
52c6bac663 feat: use DotSlash to fetch zsh fork for tests 2026-02-22 17:20:34 -08:00
Michael Bolin
7be4c734d4 merge commit for archive created by Sapling 2026-02-22 17:18:08 -08:00
Michael Bolin
0b7f018b1f feat: use DotSlash to fetch zsh fork for tests 2026-02-22 17:16:07 -08:00
Michael Bolin
973168c199 merge commit for archive created by Sapling 2026-02-22 16:52:45 -08:00
Michael Bolin
db3e858014 feat: use DotSlash to fetch zsh fork for tests 2026-02-22 16:44:11 -08:00
Michael Bolin
06993e268b Merge ad081f7f93 into sapling-pr-archive-bolinfest 2026-02-22 16:25:46 -08:00
Michael Bolin
ad081f7f93 feat: use DotSlash to fetch zsh fork for tests 2026-02-22 16:25:41 -08:00
Michael Bolin
aee3ce1b2c merge commit for archive created by Sapling 2026-02-22 16:03:26 -08:00
Michael Bolin
5cbe1ac0f0 feat: use DotSlash to fetch zsh fork for tests 2026-02-22 16:03:18 -08:00
Michael Bolin
dba3e2eaa8 Merge 9a46fe57bb into sapling-pr-archive-bolinfest 2026-02-22 15:45:18 -08:00
Michael Bolin
9a46fe57bb feat: use DotSlash to fetch zsh fork for tests 2026-02-22 15:45:11 -08:00
Eric Traut
7e569f1162 Add PR babysitting skill for this repo (#12513)
## PR Notes

This PR adds a project-scoped `babysit-pr` skill for ongoing PR
monitoring (CI, reviews, mergeability).

Simply invoke this skill after creating a PR, and codex will do its best
to get it to a mergeable state:

### What the skill does
* Fixes CI failures related to the PR
* Retries CI failures due to flaky tests
* Addresses code review comments if it agrees with them
* Addresses merge conflicts on main branch

### How the skill works
- Polls PR status on a loop (CI checks, workflow runs, review activity,
mergeability, and review decision).
- Detects new review feedback (including inline comments and automated
Codex review comments) and prompts/handles follow-up work.
- Distinguishes pending vs failed vs passed CI and identifies likely
flaky failures.
- Can retry failed checks/workflows when appropriate.
- Prioritizes actionable code review feedback over flaky CI retries (to
avoid rerunning CI on a SHA that is about to be replaced).
- Continues monitoring after fixes are applied and pushed, rather than
stopping after a progress update.
- Uses a slower backoff polling cadence once CI is green, while still
watching for new review feedback or state changes.
- Treats required review/approval as a blocking condition and keeps
watching until the PR is actually merge-ready (or merged/closed, or
human intervention is needed).

### Intended outcome

Keep the PR moving with minimal manual babysitting by continuously
watching for CI failures, reviewer feedback, and merge blockers, and
responding in the right order until the PR is ready to merge.
2026-02-22 15:36:28 -08:00
Eric Traut
d5fef5c190 Add C# syntax option to highlight selections (#12511)
Summary
- map csharp/c-sharp aliases to the existing C# syntax in the highlight
matcher
- ensure the extension list and tests include .cs and the new aliases so
coverage stays accurate

Testing

<img width="543" height="266" alt="image"
src="https://github.com/user-attachments/assets/e6c8a42f-649c-4c30-b574-421b4287534c"
/>
2026-02-22 12:15:20 -08:00
Eric Traut
5684c82e45 Sort themes case-insensitively in picker (#12509)
## Summary
- order bundled and custom themes together by name while keeping entries
stable across platforms
- update the theme fixture names and tests to assert case-insensitive
ordering
2026-02-22 12:12:36 -08:00
Ahmed Ibrahim
e00fa19328 Revert "Revert "Route inbound realtime text into turn start or steer"" (#12480)
With working tests this time

---------

Co-authored-by: Codex <noreply@openai.com>
2026-02-22 11:54:16 -08:00
Douglas Chimento
2ada9e1b2d feat(tui): support Alt-d delete-forward-word (#12455)
Alt-d should delete the next word. It didn’t. Now it does. Added a small
test so it stays that way.

Details:
File updated:
[codex-rs/tui/src/bottom_pane/textarea.rs](./codex-rs/tui/src/bottom_pane/textarea.rs)
Test added: delete_forward_word_alt_d — verifies Alt-d deletes the next
word and keeps the cursor position correct.

Solves  Issue #12453
2026-02-22 11:22:17 -08:00
jif-oai
0a0caa9df2 Handle orphan exec ends without clobbering active exploring cell (#12313)
Summary
- distinguish exec end handling targets (active tracking, active orphan
history, new cell) so unified exec responses don’t clobber unrelated
exploring cells
- ensure orphan ends flush existing exploring history when complete,
insert standalone history entries, and keep active cells correct
- add regression tests plus a snapshot covering the new behavior and
expose the ExecCell completion result for verification

Fix for https://github.com/openai/codex/issues/12278

---------

Co-authored-by: Josh McKinney <joshka@openai.com>
2026-02-22 14:26:58 +00:00
jif-oai
4666a6e631 feat: monitor role (#12364) 2026-02-22 14:13:56 +00:00
Ahmed Ibrahim
55fc075723 Send events to realtime api (#12423)
- Send assistant messages, ExecCommandBegin, and
PatchApplyBegin/PatchApplyEnd
2026-02-21 23:24:51 -08:00
Dylan Hurd
85b00ae8de fix(core) exec policy parsing 3 (#12485)
## Summary
Quick fix
2026-02-22 06:26:13 +00:00