Commit Graph
608 Commits
Author SHA1 Message Date
Michael Bolin d045ce7ed7 merge commit for archive created by Sapling 2025-05-02 12:46:11 -07:00
Michael Bolin 48a15728e2 feat: introduce mcp-types crate 2025-05-02 12:46:04 -07:00
Michael Bolin 620871cc48 merge commit for archive created by Sapling 2025-05-02 12:37:49 -07:00
Michael Bolin 9bf3ab35ff feat: introduce mcp-types crate 2025-05-02 12:37:39 -07:00
Michael Bolin 53e395969e Merge 71ffb6df1b into sapling-pr-archive-bolinfest 2025-05-02 12:25:41 -07:00
Michael Bolin 71ffb6df1b feat: introduce mcp-types crate 2025-05-02 12:25:28 -07:00
f6b1ce2e3a Configure HTTPS agent for proxies (#775)
- Some workflows require you to route openAI API traffic through a proxy
- See
https://github.com/openai/openai-node/tree/v4?tab=readme-ov-file#configuring-an-https-agent-eg-for-proxies
for more details

---------

Co-authored-by: Thibault Sottiaux <tibo@openai.com>
Co-authored-by: Fouad Matin <fouad@openai.com>
2025-05-02 12:08:13 -07:00
Fouad Matin b864cc3810 update: vite version (#766) 2025-05-02 09:30:08 -07:00
Michael Bolin a4b51f6b67 feat: use Landlock for sandboxing on Linux in TypeScript CLI (#763)
Building on top of https://github.com/openai/codex/pull/757, this PR
updates Codex to use the Landlock executor binary for sandboxing in the
Node.js CLI. Note that Codex has to be invoked with either `--full-auto`
or `--auto-edit` to activate sandboxing. (Using `--suggest` or
`--dangerously-auto-approve-everything` ensures the sandboxing codepath
will not be exercised.)

When I tested this on a Linux host (specifically, `Ubuntu 24.04.1 LTS`),
things worked as expected: I ran Codex CLI with `--full-auto` and then
asked it to do `echo 'hello mbolin' into hello_world.txt` and it
succeeded without prompting me.

However, in my testing, I discovered that the sandboxing did *not* work
when using `--full-auto` in a Linux Docker container from a macOS host.
I updated the code to throw a detailed error message when this happens:


![image](https://github.com/user-attachments/assets/e5b99def-f00e-4ade-a0c5-2394d30df52e)
2025-05-01 12:34:56 -07:00
Michael Bolin 9db12eb5d2 merge commit for archive created by Sapling 2025-05-01 11:48:14 -07:00
Michael Bolin 3d5cdd3fd5 feat: use Landlock for sandboxing on Linux 2025-05-01 11:48:09 -07:00
Michael Bolin 9bc4fde11b merge commit for archive created by Sapling 2025-05-01 11:47:20 -07:00
Michael Bolin a490029d67 feat: use Landlock for sandboxing on Linux 2025-05-01 11:47:14 -07:00
Michael Bolin 1acf0d0e24 merge commit for archive created by Sapling 2025-05-01 08:46:06 -07:00
Michael Bolin 96037168e9 feat: use Landlock for sandboxing on Linux 2025-05-01 08:46:01 -07:00
Michael Bolin 404ea5c299 Merge 1bc4eee899 into sapling-pr-archive-bolinfest 2025-05-01 08:36:29 -07:00
Michael Bolin 1bc4eee899 feat: use Landlock for sandboxing on Linux 2025-05-01 08:36:20 -07:00
Michael Bolin 3f5975ad5a chore: make build process a single script to run (#757)
This introduces `./codex-cli/scripts/stage_release.sh`, which is a shell
script that stages a release for the Node.js module in a temp directory.
It updates the release to include these native binaries:

```
bin/codex-linux-sandbox-arm64
bin/codex-linux-sandbox-x64
```

though this PR does not update Codex CLI to use them yet.

When doing local development, run
`./codex-cli/scripts/install_native_deps.sh` to install these in your
own `bin/` folder.

This PR also updates `README.md` to document the new workflow.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/757).
* #763
* __->__ #757
2025-05-01 08:36:07 -07:00
Fouad Matin 463a230991 bump(version): 0.1.2504301751 (#768)
## `0.1.2504301751`

### 🚀 Features

- User config api key (#569)
- `@mention` files in codex (#701)
- Add `--reasoning` CLI flag (#314)
- Lower default retry wait time and increase number of tries (#720)
- Add common package registries domains to allowed-domains list (#414)

### 🪲 Bug Fixes

- Insufficient quota message (#758)
- Input keyboard shortcut opt+delete (#685)
- `/diff` should include untracked files (#686)
- Only allow running without sandbox if explicitly marked in safe
container (#699)
- Tighten up check for /usr/bin/sandbox-exec (#710)
- Check if sandbox-exec is available (#696)
- Duplicate messages in quiet mode (#680)
2025-04-30 17:55:34 -07:00
Fouad Matin 985fd44ec0 fix: input keyboard shortcut opt+delete (#685) 2025-04-30 17:17:13 -07:00
Michael Bolin e26bdaf006 merge commit for archive created by Sapling 2025-04-30 16:23:41 -07:00
Michael Bolin 07a6659814 feat: use Landlock for sandboxing on Linux 2025-04-30 16:23:35 -07:00
moppywhip bc4e6db749 feat: @mention files in codex (#701)
Solves #700

## State of the World Before

Prior to this PR, when users wanted to share file contents with Codex,
they had two options:
- Manually copy and paste file contents into the chat
- Wait for the assistant to use the shell tool to view the file

The second approach required the assistant to:
1. Recognize the need to view a file
2. Execute a shell tool call
3. Wait for the tool call to complete
4. Process the file contents

This consumed extra tokens and reduced user control over which files
were shared with the model.

## State of the World After

With this PR, users can now:
- Reference files directly in their chat input using the `@path` syntax
- Have file contents automatically expanded into XML blocks before being
sent to the LLM

For example, users can type `@src/utils/config.js` in their message, and
the file contents will be included in context. Within the terminal chat
history, these file blocks will be collapsed back to `@path` format in
the UI for clean presentation.

Tag File suggestions:
<img width="857" alt="file-suggestions"
src="https://github.com/user-attachments/assets/397669dc-ad83-492d-b5f0-164fab2ff4ba"
/>

Tagging files in action:
<img width="858" alt="tagging-files"
src="https://github.com/user-attachments/assets/0de9d559-7b7f-4916-aeff-87ae9b16550a"
/>

Demo video of file tagging:
[![Demo video of file
tagging](https://img.youtube.com/vi/vL4LqtBnqt8/0.jpg)](https://www.youtube.com/watch?v=vL4LqtBnqt8)

## Implementation Details

This PR consists of 2 main components:

1. **File Tag Utilities**:
- New `file-tag-utils.ts` utility module that handles both expansion and
collapsing of file tags
- `expandFileTags()` identifies `@path` tokens and replaces them with
XML blocks containing file contents
- `collapseXmlBlocks()` reverses the process, converting XML blocks back
to `@path` format for UI display
- Tokens are only expanded if they point to valid files (directories are
ignored)
   - Expansion happens just before sending input to the model

2. **Terminal Chat Integration**:
- Leveraged the existing file system completion system for tabbing to
support the `@path` syntax
   - Added `updateFsSuggestions` helper to manage filesystem suggestions
- Added `replaceFileSystemSuggestion` to replace input with filesystem
suggestions
- Applied `collapseXmlBlocks` in the chat response rendering so that
tagged files are shown as simple `@path` tags

The PR also includes test coverage for both the UI and the file tag
utilities.

## Next Steps

Some ideas I'd like to implement if this feature gets merged:

- Line selection: `@path[50:80]` to grab specific sections of files
- Method selection: `@path#methodName` to grab just one function/class
- Visual improvements: highlight file tags in the UI to make them more
noticeable
2025-04-30 16:19:55 -07:00
Kevin Alwell bd82101859 fix: insufficient quota message (#758)
This pull request includes a change to improve the error message
displayed when there is insufficient quota in the `AgentLoop` class. The
updated message provides more detailed information and a link for
managing or purchasing credits.

Error message improvement:

*
[`codex-cli/src/utils/agent/agent-loop.ts`](diffhunk://#diff-b15957eac2720c3f1f55aa32f172cdd0ac6969caf4e7be87983df747a9f97083L1140-R1140):
Updated the error message in the `AgentLoop` class to include the
specific error message (if available) and a link to manage or purchase
credits.


Fixes #751
2025-04-30 16:00:50 -07:00
Michael Bolin c45d43fefc merge commit for archive created by Sapling 2025-04-30 14:58:58 -07:00
Michael Bolin 4ea2219e90 chore: make build process a single script to run 2025-04-30 14:58:50 -07:00
Michael Bolin 24bad86ae6 feat: use Landlock for sandboxing on Linux 2025-04-30 14:58:50 -07:00
Michael Bolin 1074abb2bf merge commit for archive created by Sapling 2025-04-30 14:57:16 -07:00
Michael Bolin 2812bde15a feat: use Landlock for sandboxing on Linux 2025-04-30 14:57:09 -07:00
Michael Bolin 1ac157950f merge commit for archive created by Sapling 2025-04-30 14:31:06 -07:00
Michael Bolin 0e53e1bd54 chore: make build process a single script to run 2025-04-30 14:30:56 -07:00
Michael Bolin 9ae9a682fa feat: use Landlock for sandboxing on Linux 2025-04-30 14:30:56 -07:00
Michael Bolin 4a7aee7713 merge commit for archive created by Sapling 2025-04-30 14:24:37 -07:00
Michael Bolin 364b53900f feat: use Landlock for sandboxing on Linux 2025-04-30 14:24:27 -07:00
Michael Bolin dd1f839f52 chore: make build process a single script to run 2025-04-30 14:08:38 -07:00
Michael Bolin 033d379eca fix: remove unused _writableRoots arg to exec() function (#762)
I suspect this was done originally so that `execForSandbox()` had a
consistent signature for both the `SandboxType.NONE` and
`SandboxType.MACOS_SEATBELT` cases, but that is not really necessary and
turns out to make the upcoming Landlock support a bit more complicated
to implement, so I had Codex remove it and clean up the call sites.
2025-04-30 14:08:27 -07:00
Michael Bolin 6923cd5065 Merge 8312121a1f into sapling-pr-archive-bolinfest 2025-04-30 14:05:12 -07:00
Michael Bolin 8312121a1f fix: remove unused _writableRoots arg to exec() function 2025-04-30 14:04:59 -07:00
Michael Bolin e6fe8d6fa1 chore: mark Rust releases as "prerelease" (#761)
Apparently the URLs for draft releases cannot be downloaded using
unauthenticated `curl`, which means the DotSlash file only works for
users who are authenticated with `gh`. According to chat, prereleases
_can_ be fetched with unauthenticated `curl`, so let's try that.
codex-rs-e40bc9911433bd3f942ef4604626fab5638a7a72-1-rust-v0.0.2504301327
2025-04-30 13:25:53 -07:00
Michael Bolin 3de041fe2a Merge f361844ce5 into sapling-pr-archive-bolinfest 2025-04-30 13:21:29 -07:00
Michael Bolin f361844ce5 chore: mark Rust releases as "prerelease" 2025-04-30 13:21:22 -07:00
Michael Bolin b571249867 chore: script to create a Rust release (#759)
For now, keep things simple such that we never update the `version` in
the `Cargo.toml` for the workspace root on the `main` branch. Instead,
create a new branch for a release, push one commit that updates the
`version`, and then tag that branch to kick off a release.

To test, I ran this script and created this release job:

https://github.com/openai/codex/actions/runs/14762580641
codex-rs-72a4c38e41bc64f5a7c8c73d52f45784cb6b7137-1-rust-v0.0.2504301219
2025-04-30 12:39:03 -07:00
Michael Bolin 02c180f6c3 merge commit for archive created by Sapling 2025-04-30 12:16:11 -07:00
Michael Bolin 4ae8f2ba46 chore: script to create a Rust release 2025-04-30 12:16:04 -07:00
Michael Bolin cc74a71a69 Merge 8dff8943ee into sapling-pr-archive-bolinfest 2025-04-30 12:10:54 -07:00
Michael Bolin 8dff8943ee chore: script to create a Rust release 2025-04-30 12:10:46 -07:00
Michael Bolin 24278347b7 fix: remove codex-repl from GitHub workflows (#760)
I missed this when doing https://github.com/openai/codex/pull/754.
2025-04-30 12:10:24 -07:00
Michael Bolin 95ef46c6f8 Merge 549341afaf into sapling-pr-archive-bolinfest 2025-04-30 12:09:47 -07:00
Michael Bolin 549341afaf fix: remove codex-repl from GitHub workflows 2025-04-30 12:09:40 -07:00
Michael Bolin 7f18fd3f56 Merge 4e7f007e68 into sapling-pr-archive-bolinfest 2025-04-30 12:08:21 -07:00