Commit Graph
13401 Commits
Author SHA1 Message Date
Michael Bolin a69e2539ab Merge 869706f870 into sapling-pr-archive-bolinfest 2026-04-26 12:43:58 -07:00
Michael Bolin 869706f870 permissions: finish profile-backed app surfaces 2026-04-26 12:43:45 -07:00
Michael Bolin 8cf1ae2710 permissions: remove core legacy policy round trips 2026-04-26 12:43:45 -07:00
Michael Bolin dd8aee00ac permissions: migrate approval and sandbox consumers to profiles 2026-04-26 12:43:45 -07:00
Michael Bolin 5d0500420b permissions: derive compatibility policies from profiles 2026-04-26 12:43:45 -07:00
Michael Bolin 04805fb788 permissions: make runtime config profile-backed 2026-04-26 12:43:44 -07:00
Michael Bolin ac2bffa443 test: harden app-server integration tests (#19683)
## Why

Windows Bazel runs in the permissions stack exposed that app-server
integration tests were launching normal plugin startup warmups in every
subprocess. Those warmups can call
`https://chatgpt.com/backend-api/plugins/featured` when a test is not
specifically exercising plugin startup, which adds slow background work,
noisy stderr, and dependence on external network state. The relevant
startup/featured-plugin behavior was introduced across #15042 and
#15264.

A few app-server tests also had long optional waits or unbounded cleanup
paths, making failures expensive to diagnose and contributing to slow
Windows shards. One external-agent config test from #18246 used a
GitHub-style marketplace source, which was enough to exercise the
pending remote-import path but also meant the background completion task
could attempt a real clone.

## What Changed

- Adds explicit `AppServerRuntimeOptions` / `PluginStartupTasks`
plumbing and a hidden debug-only
`--disable-plugin-startup-tasks-for-tests` app-server flag, so
integration tests can suppress startup plugin warmups without adding a
production env-var gate.
- Has the app-server test harness pass that hidden flag by default,
while opting plugin-startup coverage back in for tests that
intentionally exercise startup sync and featured-plugin warmup behavior.
- Lowers normal app-server subprocess logging from `info`/`debug` to
`warn` to avoid multi-megabyte stderr output in Bazel logs.
- Prevents the external-agent config test from attempting a real
marketplace clone by using an invalid non-local source while still
exercising the pending-import completion path.
- Bounds optional filesystem/realtime waits and fake WebSocket
test-server shutdown so failures produce targeted timeouts instead of
hanging a shard.
- Fixes the Unix script-resolution test in `rmcp-client` to exercise
PATH resolution directly and include the actual spawn error in failures.

## Verification

- `cargo check -p codex-app-server`
- `cargo clippy -p codex-app-server --tests -- -D warnings`
- `cargo test -p codex-rmcp-client
program_resolver::tests::test_unix_executes_script_without_extension`
- `cargo test -p codex-app-server --test all
external_agent_config_import_sends_completion_notification_after_pending_plugins_finish
-- --nocapture`
- `cargo test -p codex-app-server --test all
plugin_list_uses_warmed_featured_plugin_ids_cache_on_first_request --
--nocapture`
- Windows Local Bazel passed with this test-hardening bundle before it
was extracted from #19606.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/19683).
* #19395
* #19394
* #19393
* #19392
* #19606
* __->__ #19683
2026-04-26 12:43:16 -07:00
Michael Bolin 750073b9f0 merge commit for archive created by Sapling 2026-04-26 09:04:29 -07:00
Michael Bolin 94b148985a permissions: finish profile-backed app surfaces 2026-04-26 09:04:18 -07:00
Michael Bolin 7fb2474298 permissions: remove core legacy policy round trips 2026-04-26 09:04:18 -07:00
Michael Bolin c06be99973 permissions: migrate approval and sandbox consumers to profiles 2026-04-26 09:04:18 -07:00
Michael Bolin bbf5996946 permissions: derive compatibility policies from profiles 2026-04-26 09:04:18 -07:00
Michael Bolin c966040ae7 permissions: make runtime config profile-backed 2026-04-26 09:04:18 -07:00
Michael Bolin 0b157cc217 test: harden app-server integration tests 2026-04-26 09:04:18 -07:00
Michael Bolin 7ae9c19c31 merge commit for archive created by Sapling 2026-04-26 08:50:14 -07:00
Michael Bolin 34ef6ea7c5 permissions: finish profile-backed app surfaces 2026-04-26 08:49:49 -07:00
Michael Bolin 84bcbc8a98 permissions: remove core legacy policy round trips 2026-04-26 08:49:49 -07:00
Michael Bolin 77258c7ee7 permissions: migrate approval and sandbox consumers to profiles 2026-04-26 08:49:49 -07:00
Michael Bolin 6bc3d4dcf5 permissions: derive compatibility policies from profiles 2026-04-26 08:49:49 -07:00
Michael Bolin 7fdbbbc894 permissions: make runtime config profile-backed 2026-04-26 08:49:49 -07:00
Michael Bolin 4fb4b54b68 test: harden app-server integration tests 2026-04-26 08:49:49 -07:00
Michael Bolin 3bcd06bfb7 Merge 4021347d96 into sapling-pr-archive-bolinfest 2026-04-26 08:03:31 -07:00
Michael Bolin 4021347d96 permissions: finish profile-backed app surfaces 2026-04-26 08:03:05 -07:00
Michael Bolin ace9fcdfa3 permissions: remove core legacy policy round trips 2026-04-26 08:03:05 -07:00
Michael Bolin bfcdfd2d45 permissions: migrate approval and sandbox consumers to profiles 2026-04-26 08:03:05 -07:00
Michael Bolin facb2ee0c0 permissions: derive compatibility policies from profiles 2026-04-26 08:03:05 -07:00
Michael Bolin b5f87a05e5 permissions: make runtime config profile-backed 2026-04-26 08:03:05 -07:00
Michael Bolin 3099353c93 test: harden app-server integration tests 2026-04-26 08:02:55 -07:00
Michael Bolin 0359197207 Merge 46ded5363b into sapling-pr-archive-bolinfest 2026-04-26 07:50:56 -07:00
Michael Bolin 46ded5363b permissions: finish profile-backed app surfaces 2026-04-26 07:50:46 -07:00
Michael Bolin 8d37a2efdc permissions: remove core legacy policy round trips 2026-04-26 07:50:46 -07:00
Michael Bolin dc73f13be1 Merge 8c7965546c into sapling-pr-archive-bolinfest 2026-04-26 07:14:14 -07:00
Michael Bolin f62abbc3b1 permissions: migrate approval and sandbox consumers to profiles 2026-04-26 07:14:00 -07:00
Michael Bolin 8c7965546c permissions: finish profile-backed app surfaces 2026-04-26 07:14:00 -07:00
Michael Bolin 1e298e87b2 permissions: derive compatibility policies from profiles 2026-04-26 07:14:00 -07:00
Michael Bolin a8ffa3fc51 permissions: remove core legacy policy round trips 2026-04-26 07:14:00 -07:00
Michael Bolin bd91e860dd Merge fbbf996142 into sapling-pr-archive-bolinfest 2026-04-26 06:54:20 -07:00
Michael Bolin 897e6b746b permissions: make runtime config profile-backed 2026-04-26 06:54:06 -07:00
Michael Bolin fbbf996142 permissions: finish profile-backed app surfaces 2026-04-26 06:54:06 -07:00
Michael Bolin d14c0dfa01 permissions: remove core legacy policy round trips 2026-04-26 06:54:06 -07:00
Michael Bolin f024fe1e2c permissions: migrate approval and sandbox consumers to profiles 2026-04-26 06:54:06 -07:00
Michael Bolin 44edab38c4 permissions: derive compatibility policies from profiles 2026-04-26 06:54:06 -07:00
Michael Bolin e6e73d9103 Merge dd93217ec3 into sapling-pr-archive-bolinfest 2026-04-26 06:09:58 -07:00
Michael Bolin dd93217ec3 permissions: finish profile-backed app surfaces 2026-04-26 06:09:48 -07:00
Michael Bolin 1eee3e5e32 permissions: remove core legacy policy round trips 2026-04-26 06:09:48 -07:00
Michael Bolin 4f124bd369 permissions: migrate approval and sandbox consumers to profiles 2026-04-26 06:09:48 -07:00
Michael Bolin 27402fb9b0 permissions: derive compatibility policies from profiles 2026-04-26 06:09:48 -07:00
Michael Bolin 79128ce55f permissions: make runtime config profile-backed 2026-04-26 06:09:48 -07:00
Michael Bolin 067ba4589e Merge 62788b743c into sapling-pr-archive-bolinfest 2026-04-26 05:37:58 -07:00
Michael Bolin 62788b743c permissions: finish profile-backed app surfaces 2026-04-26 05:37:51 -07:00