Commit Graph

847 Commits

Author SHA1 Message Date
Michael Bolin
7499042ed3 merge commit for archive created by Sapling 2025-05-07 12:55:01 -07:00
Michael Bolin
5743c170e5 feat: support map of alternative providers like in TypeScript CLI 2025-05-07 12:54:56 -07:00
Michael Bolin
e74f213cc9 Merge ea13757d3f into sapling-pr-archive-bolinfest 2025-05-07 12:52:58 -07:00
Michael Bolin
ea13757d3f fix: add optional timeout to McpClient::send_request() 2025-05-07 12:52:11 -07:00
Michael Bolin
17c3ebbd12 merge commit for archive created by Sapling 2025-05-07 12:51:15 -07:00
Michael Bolin
8ec2dffc7a feat: support map of alternative providers like in TypeScript CLI 2025-05-07 12:51:05 -07:00
Michael Bolin
c131d26f07 merge commit for archive created by Sapling 2025-05-07 12:46:13 -07:00
Michael Bolin
be73b208cd fix: add optional timeout to McpClient::send_request() 2025-05-07 12:46:04 -07:00
Michael Bolin
0360b4d0d7 feat: introduce the use of tui-markdown (#851)
This introduces the use of the `tui-markdown` crate to parse an
assistant message as Markdown and style it using ANSI for a better user
experience. As shown in the screenshot below, it has support for syntax
highlighting for _tagged_ fenced code blocks:

<img width="907" alt="image"
src="https://github.com/user-attachments/assets/900dc229-80bb-46e8-b1bb-efee4c70ba3c"
/>

That said, `tui-markdown` is not as configurable (or stylish!) as
https://www.npmjs.com/package/marked-terminal, which is what we use in
the TypeScript CLI. In particular:

* The styles are hardcoded and `tui_markdown::from_str()` does not take
any options whatsoever. It uses "bold white" for inline code style which
does not stand out as much as the yellow used by `marked-terminal`:


65402cbda7/tui-markdown/src/lib.rs (L464)

I asked Codex to take a first pass at this and it came up with:

https://github.com/joshka/tui-markdown/pull/80

* If a fenced code block is not tagged, then it does not get
highlighted. I would rather add some logic here:


65402cbda7/tui-markdown/src/lib.rs (L262)

that uses something like https://pypi.org/project/guesslang/ to examine
the value of `text` and try to use the appropriate syntax highlighter.

* When we have a fenced code block, we do not want to show the opening
and closing triple backticks in the output.

To unblock ourselves, we might want to bundle our own fork of
`tui-markdown` temporarily until we figure out what the shape of the API
should be and then try to upstream it.
2025-05-07 10:46:32 -07:00
Michael Bolin
0e32859c90 merge commit for archive created by Sapling 2025-05-07 10:18:54 -07:00
Michael Bolin
d289a825df feat: introduce the use of tui_markdown 2025-05-07 10:18:46 -07:00
Michael Bolin
b2177f86dd Merge b13eaa7c12 into sapling-pr-archive-bolinfest 2025-05-07 10:10:33 -07:00
Michael Bolin
b13eaa7c12 feat: save rollouts in Rust CLI 2025-05-07 10:10:05 -07:00
Michael Bolin
5c6c9839ff merge commit for archive created by Sapling 2025-05-07 10:09:35 -07:00
Michael Bolin
7235e057fe feat: introduce the use of tui_markdown 2025-05-07 10:09:00 -07:00
jcoens-openai
a080d7b0fd Update submodules version to come from the workspace (#850)
Tie the version of submodules to the workspace version.
2025-05-07 10:08:06 -07:00
Michael Bolin
a044f30f38 Merge bd910aad64 into sapling-pr-archive-bolinfest 2025-05-07 09:55:09 -07:00
Michael Bolin
bd910aad64 feat: introduce the use of tui_markdown 2025-05-07 09:54:56 -07:00
jcoens-openai
8a89d3aeda Update cargo to 2024 edition (#842)
Some effects of this change:
- New formatting changes across many files. No functionality changes
should occur from that.
- Calls to `set_env` are considered unsafe, since this only happens in
tests we wrap them in `unsafe` blocks
2025-05-07 08:37:48 -07:00
Michael Bolin
c48246f143 merge commit for archive created by Sapling 2025-05-06 22:53:49 -07:00
Michael Bolin
27b6fd3524 feat: save rollouts in Rust CLI 2025-05-06 22:53:42 -07:00
Michael Bolin
c7ee7b2579 merge commit for archive created by Sapling 2025-05-06 22:48:52 -07:00
Michael Bolin
0f52b17cde feat: save rollouts in Rust CLI 2025-05-06 22:48:48 -07:00
Michael Bolin
6d99328428 merge commit for archive created by Sapling 2025-05-06 22:46:33 -07:00
Michael Bolin
3f1d34bdd7 feat: save rollouts in Rust CLI 2025-05-06 22:46:26 -07:00
Michael Bolin
96cec49cf5 Merge 0b46df2677 into sapling-pr-archive-bolinfest 2025-05-06 22:04:03 -07:00
Michael Bolin
0b46df2677 feat: save rollouts in Rust CLI 2025-05-06 22:03:57 -07:00
Michael Bolin
e9ddb55fb8 merge commit for archive created by Sapling 2025-05-06 18:57:45 -07:00
Michael Bolin
f11b4bc909 chore: introduce new --native flag to Node module release process 2025-05-06 18:57:37 -07:00
Michael Bolin
c135d8c45a merge commit for archive created by Sapling 2025-05-06 18:53:38 -07:00
Michael Bolin
1db64b94d3 chore: introduce new --native flag to Node module release process 2025-05-06 18:53:11 -07:00
Michael Bolin
b113bde210 Merge 6995f5273e into sapling-pr-archive-bolinfest 2025-05-06 18:26:10 -07:00
Michael Bolin
6995f5273e chore: introduce new --native flag to Node module release process 2025-05-06 18:26:03 -07:00
Michael Bolin
c577e94b67 chore: introduce codex-common crate (#843)
I started this PR because I wanted to share the `format_duration()`
utility function in `codex-rs/exec/src/event_processor.rs` with the TUI.
The question was: where to put it?

`core` should have as few dependencies as possible, so moving it there
would introduce a dependency on `chrono`, which seemed undesirable.
`core` already had this `cli` feature to deal with a similar situation
around sharing common utility functions, so I decided to:

* make `core` feature-free
* introduce `common`
* `common` can have as many "special interest" features as it needs,
each of which can declare their own deps
* the first two features of common are `cli` and `elapsed`

In practice, this meant updating a number of `Cargo.toml` files,
replacing this line:

```toml
codex-core = { path = "../core", features = ["cli"] }
```

with these:

```toml
codex-core = { path = "../core" }
codex-common = { path = "../common", features = ["cli"] }
```

Moving `format_duration()` into its own file gave it some "breathing
room" to add a unit test, so I had Codex generate some tests and new
support for durations over 1 minute.
codex-rs-132146b6d4e133d014f763a0d8dabd853f3fc0c0-1-rust-v0.0.2505061740
2025-05-06 17:38:56 -07:00
Michael Bolin
a03be77956 Merge 413e5370aa into sapling-pr-archive-bolinfest 2025-05-06 17:33:52 -07:00
Michael Bolin
413e5370aa chore: introduce codex-common crate 2025-05-06 17:33:49 -07:00
Michael Bolin
e426018866 Merge 51facd79bf into sapling-pr-archive-bolinfest 2025-05-06 17:33:14 -07:00
Michael Bolin
51facd79bf chore: introduce codex-common crate 2025-05-06 17:33:11 -07:00
Michael Bolin
5f83da6046 merge commit for archive created by Sapling 2025-05-06 17:32:32 -07:00
Michael Bolin
6da5631a7c chore: introduce codex-common crate 2025-05-06 17:32:28 -07:00
Michael Bolin
a0a7e0a7f0 merge commit for archive created by Sapling 2025-05-06 17:28:34 -07:00
Michael Bolin
d82a893b35 chore: introduce codex-common crate 2025-05-06 17:28:28 -07:00
Michael Bolin
98168f0cae merge commit for archive created by Sapling 2025-05-06 17:16:36 -07:00
Michael Bolin
a648355cae chore: introduce codex-common crate 2025-05-06 17:16:28 -07:00
Michael Bolin
15d8356af4 merge commit for archive created by Sapling 2025-05-06 17:09:56 -07:00
Michael Bolin
bf30f991b0 chore: introduce codex-common crate 2025-05-06 17:07:33 -07:00
Michael Bolin
7d8b38b37b feat: show MCP tool calls in codex exec subcommand (#841)
This is analogous to the change for the TUI in
https://github.com/openai/codex/pull/836, but for `codex exec`.

To test, I ran:

```
cargo run --bin codex-exec -- 'what is the weather in wellesley ma tomorrow'
```

and saw:


![image](https://github.com/user-attachments/assets/5714e07f-88c7-4dd9-aa0d-be54c1670533)
2025-05-06 16:52:43 -07:00
Michael Bolin
9945874de7 Merge 81fc840604 into sapling-pr-archive-bolinfest 2025-05-06 16:40:52 -07:00
Michael Bolin
81fc840604 feat: show MCP tool calls in codex exec subcommand 2025-05-06 16:40:49 -07:00
Michael Bolin
932498589d Merge c714c40710 into sapling-pr-archive-bolinfest 2025-05-06 16:37:36 -07:00