Commit Graph
12624 Commits
Author SHA1 Message Date
rhan-oai 581161ab41 Release 0.171.0-alpha.13 2026-11-17 20:34:05 -08:00
richardopenai 1b84166252 Flush HTTP/2 tunnel data to the local TCP writer (#62186)
## Why

An interactive tunnel can stall when a buffered local writer holds data
that the client needs before it can reply.

## What changed

Flush the local TCP writer after each HTTP/2 data chunk, before releasing
receive flow-control capacity.

## Testing

Extend the relay test to verify that the client receives the server's
initial bytes through a buffered writer before sending its upload.

GitOrigin-RevId: 7c6c37a707319ce77f2abb627924337b0c944c32
2026-11-18 04:16:11 +00:00
viyatb-oai 6ee9bc1ba7 Select process sandboxes during launch preparation (#62183)
## Why

Workspace-relative permission rules need to resolve against the execution
host's workspace roots so a grant applies to the intended directory.
Restricted launches also need to check that the host can provide the
required sandbox.

## What changed

- Select the platform sandbox while preparing a launch, using the permission
  profile, network requirements, and Windows sandbox settings.
- Pass workspace roots into policy resolution for local commands and shell
  snapshots. Already-bound command profiles validate their concrete paths
  without resolving Windows launcher hints on hosts that do not use them.
- Share local launch preparation between tool commands and shell snapshots,
  and require a platform sandbox for exec-server launches that request one.

## Testing

Cover network-only restrictions and verify that a
`:workspace_roots` write grant allows writes to the configured subdirectory
under the command's working directory while denying writes to a sibling file
and the corresponding subdirectory under the parent. Exercise the path grant
through both app-server command execution and WebSocket exec-server execution.

GitOrigin-RevId: 492fe7ab8deddf30cfd2e2bdabf28d02d67e00c5
2026-11-18 03:59:37 +00:00
Owen Lin 9f80bb5957 Expose bioPolicy errors in app-server v2 (#62176)
## Why

App-server clients received the generic `other` error code for biology
policy errors, so they couldn't distinguish them by code.

## What changed

Map the core `BioPolicy` error to `bioPolicy` in app-server v2 and include
the new value in the generated JSON schemas, TypeScript types, and Python
SDK enum.

## Testing

Update the error conversion test to assert that `BioPolicy` serializes as
`"bioPolicy"`.

GitOrigin-RevId: 77fa969a3d8cbd4c12fe6f7aa5d4833f6adaa99b
2026-11-18 03:37:23 +00:00
Eric Traut fc25d8f120 Fix stale terminal dimensions in immediate TUI redraws (#62175)
## Why

An immediate redraw can happen before the TUI receives a resize event.
For example, submitting a turn just after shrinking the terminal can
render the frame using the previous dimensions.

## What changed

Resolve the screen size and run resize handling before immediate paints
for turn submission, session lifecycle actions, startup modals, Cloud
switching, and shutdown. Consume the reserved size when drawing the frame
and preserve the scheduled recheck for settled terminal dimensions.

## Testing

Add regression coverage for fullscreen turn submission and archive
progress after a terminal shrink, plus checks that a draw consumes its
reserved size and an early paint preserves the scheduled size recheck.

GitOrigin-RevId: 494c746cb02712350cc600ea4aea64460c608639
2026-11-18 03:36:14 +00:00
Eric Traut 3dbc6f8657 Keep the TUI composer caret anchored while typing (#62174)
## Why

When the composer footer gains or loses a hint row, typing the first
character or deleting the last one can move the caret vertically.

## What changed

Reserve a row for passive footer hints when the status line is visible
and there is room after laying out the input, slash-command suggestions,
and previews. The row can stay blank until a hint appears.

## Testing

Add a regression test that checks the caret row before typing, after
typing one character, and after pressing Backspace. Extend coverage to
check that slash-command suggestions and a short status line fit together
when space is tight.

GitOrigin-RevId: 25df697826cebc4b7cb4aab4460c432b7454d5ea
2026-11-18 03:08:53 +00:00
Sean Huang f09fb197f5 Remove Python from MCP permission request hook tests (#62172)
The MCP permission request hook tests depend on a Python interpreter to
run their fixture, so running them requires Python on the host or in
Bazel's test inputs.

Run the Rust test binary as the hook subprocess. It reads the hook
payload from stdin, appends it to the JSON Lines log, and writes the
configured response to stdout. Drop the Python runtime and files from
the core Bazel test dependencies.

GitOrigin-RevId: b9e26384c6b455b0f0936c7009a445d3eabfe2c6
2026-11-18 02:56:01 +00:00
Benjamin Carlsson 409973e0e2 Extract TUI thread resume finalization (#62171)
## What changed

Move subscription state updates, history hydration, and resumed session
setup into `finish_thread_resume`. Let callers supply a
`HistoryHydrationScope` and keep using `HistoryHydrationScope::Initial`
for the existing resume path.

GitOrigin-RevId: ebb8b422827a2374d8dce194e8d59afe57327f29
2026-11-18 02:54:51 +00:00
Dylan Hurd 345f166d01 Wait for the search connector in hosted web search tests (#62165)
## Why

MCP tool catalogs can change during startup, so a search binding
captured during startup may go uncached. That makes the test's
per-turn discovery request count depend on startup timing.

## What changed

When hosted search is allowed, wait for the thread's connector to
report `ready` before starting the first turn. This lets the test
check discovery reuse with a stable binding.

GitOrigin-RevId: 50d77eca6bfa7a6bfd5657e4c1ed3aad52beb8c5
2026-11-18 02:31:46 +00:00
Michael Bolin bb6b4b63b9 Move the app-server socket relay into the Codex CLI (#62163)
## What changed

Move the stdio-to-Unix-socket relay used by `codex app-server proxy`
into the CLI crate. Remove the standalone `codex-stdio-to-uds` crate
and binary and the hidden `codex stdio-to-uds` subcommand.

## Testing

Replace the standalone binary test with a CLI integration test that
runs `codex app-server proxy --sock` and checks that the socket receives
the bytes from stdin and the reply appears on stdout.

GitOrigin-RevId: e630f8f70e93ce90b0005e4992a3d0b257b208db
2026-11-18 02:18:36 +00:00
Dylan Hurd b65d9a3b2d Stabilize app-server app/list integration tests (#62162)
## Why

Fixed delays make notification-order assertions sensitive to when the mock
directory and tool requests finish. Model discovery can also make network
requests while these tests exercise app listing.

## What changed

- Pause mock directory responses until the tests receive the expected tool
  update. During forced refetch, assert that the next notification includes
  the fresh directory so an intermediate inaccessible-only update fails the
  test.
- Use the bundled model catalog through `model_catalog_json` and preserve
  that setting when the thread feature flag test rewrites `config.toml`.

GitOrigin-RevId: 0356d757391f15cdcee99a6ac3311dc78b8df00b
2026-11-18 02:17:25 +00:00
Benjamin Carlsson 29091c7234 Wait for the system bwrap probe with a pidfd (#62160)
## Why

The system `bwrap` user namespace probe checks for child exit at fixed
intervals. A pidfd signals exit as soon as the child terminates, even
when a descendant still holds its stderr pipe open.

## What changed

Poll the probe child's pidfd for the time remaining before the deadline.
Keep the bounded `try_wait` loop to collect the exit status and handle
systems where `pidfd_open` fails.

GitOrigin-RevId: f69f10aa49404a7760c33bbcbfde456513ebdaa0
2026-11-18 02:05:25 +00:00
Felipe Coury bedafe7156 Open subagent transcripts from activity links in the TUI (#62159)
## Why

When a transcript mentions a subagent, readers have to find it in the
sidebar chooser to inspect its work.

## What changed

Underline subagent labels in transcript activity when the sidebar is
available. Clicking a label opens that agent's transcript beside the
parent conversation, including when the link is in an unfocused pane.

Use backend ancestry to confirm that the linked agent belongs to the
current conversation. If a click arrives while agent discovery is in
progress after resume, resolve it when discovery finishes.

## Testing

Cover clicks from the parent transcript and a nested-agent link in an
unfocused pane, along with clicks during discovery and inherited
activity from a fork. Snapshot the underline across a wrapped label.

GitOrigin-RevId: 75b343c56eac4a009d644f0cfc135b6d9bfbe3a0
2026-11-18 02:04:55 +00:00
Felipe Coury cc3757a99d Open subagent transcripts in the TUI sidebar (#62157)
## Why

Selecting a subagent from the sidebar switched the active conversation
to that agent. Keeping the parent conversation visible makes it easier
to review the agent's work in context.

## What changed

- Open the selected subagent in a sidebar tab alongside its parent
  conversation. Switch focus between the two panes as needed.
- Show parent-owned subagents in a watch-only reader with transcript
  navigation, search, and selection.
- Press `Esc` from the reader to return to the subagent list with the
  same agent selected. The tab also supports the sidebar's close button
  and close shortcut.

## Testing

Add a TUI integration test that opens a saved subagent through the
sidebar, snapshots the watch-only view, and covers transcript
navigation, search, resizing, and tab dismissal.

GitOrigin-RevId: 60da0759b7c046c33b665abdbb063153c5beafa4
2026-11-18 02:03:29 +00:00
Dylan Hurd 3aaa23a437 Reduce overhead in CLI integration tests (#62153)
## Why

SSE-only mocks return 404 on WebSocket upgrades by default, causing
retries before the tests reach the HTTP stream. In parallel runs, each
CLI subprocess can also start a Tokio worker per host CPU.

## What changed

- Share an SSE mock that returns HTTP 426 on WebSocket upgrades to
  trigger immediate HTTP fallback. Reuse it in the fallback test.
- Set `TOKIO_WORKER_THREADS=2` for CLI subprocesses launched by the
  affected test helpers. Run streaming and resume cases that don't need
  the repository checkout in temporary working directories.
- Test promptless `codex exec fork` option validation without creating a
  source thread. In the successful promptless fork case, keep stdin
  open and rely on the test runner's timeout to catch a blocked read.

GitOrigin-RevId: 94c20d4b2fd7cc65bc0f2a1cd0318ac188f59f22
2026-11-18 01:48:42 +00:00
Benjamin Carlsson 1c2e4cd45f Limit recovery after repeated cloud reply stream disconnects (#62151)
## Why

A cloud reply stream can drop again shortly after reconnecting, leaving
users in a cycle of disconnects and recovery.

## What changed

Delay recovery by 500 ms for each replacement stream already installed
in the current recovery sequence. After three replacements, return an
error that tells users their transcript and draft are still available.

Clear the count when recovery state is reset or when a stream disconnects
after staying connected for at least 15 seconds.

GitOrigin-RevId: 6ae2e88023464fc41d8e26d47dd94af624660d5f
2026-11-18 01:36:57 +00:00
Benjamin Carlsson 2f7c5a8588 Cancel Cloud overview refreshes that block TUI navigation (#62150)
## Why

An in-flight Cloud task list from the agents overview can keep the Cloud
worker busy while the TUI waits for a session request, such as listing
tasks in the resume picker or unsubscribing from a discarded blank task.

## What changed

Cancel the affected backend's Cloud overview refresh when dismissing the
overview or before session operations that need the same worker. Wait for
the aborted task to drop its request before proceeding. When opening the
resume picker, clear queued Cloud refreshes first so canceling the active
refresh cannot start another page ahead of the picker's requests.

## Testing

Add regression tests that hold Cloud list requests open while returning to
the current chat, opening the resume picker, or switching backends.
Cover canceling a refresh before starting a fresh plan implementation
session and preserving another backend's in-flight page during archive.

GitOrigin-RevId: 94993aa0014ac895a30f454e3ff5f4cbc45bb429
2026-11-18 01:35:51 +00:00
Felipe Coury 18352dc4e8 Show subagents and their status in the TUI sidebar chooser (#62149)
## Why

The sidebar chooser lists side chats and files. Adding subagents lets
users check their progress and switch to their conversations from the
same menu.

## What changed

- Add a `Subagents` section for the main conversation's spawn tree.
  Show each agent's name and status, and let users select an agent to
  switch to its conversation.
- Keep explicit outcomes such as `Completed`, `Stopped`, and `Failed`
  visible through idle or unloaded updates. Restore outcomes from saved
  activity and give live updates precedence over in-flight discovery.

## Testing

Add wide and narrow chooser snapshots and regression tests for outcome
retention and discovery updates that race with live notifications.

GitOrigin-RevId: 93092e6bd5c59724f69f52785e3c22aa2c1313d8
2026-11-18 01:11:31 +00:00
Benjamin Carlsson 2f5c413e19 Batch mouse wheel scrolling in the TUI (#62146)
## Why

Rapid wheel input can trigger a synchronous transcript redraw for each tick, even when the current layout can still be used.

## What changed

Accumulate wheel movement in the main transcript and side panes until the next frame when the rendered layout is safe to reuse. Refresh first when the transcript has changed, cached content can change height, or the side pane has buffered reply text. Refresh immediately when toggling side-pane zoom so subsequent mouse events use the new layout.

Start composer scrolling from the caret-adjusted viewport after an edit so wheel ticks can accumulate before the next frame.

## Testing

Cover wheel bursts while the plan menu is open, composer scrolling after edits, refresh requirements for mutable history and buffered side replies, and immediate layout updates when toggling side-pane zoom.

GitOrigin-RevId: 342d4d4c014d8a41b2e690b91622197ee97fc059
2026-11-18 00:58:27 +00:00
JonLuca De Caro 67d8266e06 Signal workspace routing readiness in account updates (#62145)
## Why

App-server clients receive `account/updated` both when routing is ready
for a saved ChatGPT workspace and when a user logs in, logs out, or
switches workspaces. The notification payload gives clients no explicit
way to identify the initial routing update.

## What changed

Add a nullable `reason` to `account/updated`. Set it to
`workspaceRoutingReady` on the initial saved-workspace routing
notification when the authenticated owner is unchanged, including when
routing is ready before the connection initializes. Login, logout, and
workspace-switch updates send `null`. Update the protocol schemas,
TypeScript types, and Python SDK models.

## Testing

Extend the app-server integration tests to check the reason in the JSON
payloads for saved-workspace discovery, login, workspace switching, and
logout.

GitOrigin-RevId: 96758519985a6bdb07474e48307ed53b125823ee
2026-11-18 00:46:17 +00:00
Owen Lin 06789c7618 Preserve web search provider ownership across thread resumes (#62144)
## Why

Search MCP and native web search produce provider-specific references.
Switching providers after a thread resumes can mix those references and
break follow-up calls that use them.

## What changed

Persist whether a thread has used Search MCP, native web search, or
neither. Restore that state from response history, including compacted
history, and use legacy attribution and fallback markers for older
threads. When resumed history lacks a search state or legacy attribution
checkpoint, withhold native fallback unless a legacy marker identifies
native search.

Require every Search MCP call to claim the thread's search provider
before execution, including calls retained by Code Mode.

## Testing

Cover resuming a thread with Search MCP references after discovery
becomes unavailable, both with a saved search state and with imported
history that lacks search checkpoints.

GitOrigin-RevId: 100d21c92b0bdbf737ec36c3474f0bc020df8efc
2026-11-18 00:45:07 +00:00
Ax 83c46d0a58 Add audio transcription to the backend client (#62142)
## What changed

Add `Client::transcribe_audio` to send a single audio clip to the
`/transcribe` dictation endpoint as an authenticated multipart upload
and return the transcript text. Accept WAV, MP3, M4A, WebM, and Ogg,
and cap the response body at 64 KiB.

## Testing

Add a mock-server test that checks the bearer token, the exact multipart
body for an M4A clip, and the returned transcript text.

GitOrigin-RevId: 50ab00d932aefda942c730a8b037b53d4f5003c2
2026-11-18 00:33:23 +00:00
zm-oai 2ae806bdf7 Repair missing or stale Windows sandbox Core registration (#62141)
## Why

When protected Core is requested, valid cached sandbox credentials can let
command startup skip setup even if Core registration is missing or stale.

## What changed

Run automatic setup when the requested registration is unready, even if
cached credentials are valid. Require registration readiness after setup
before returning sandbox credentials.

## Testing

Extend credential setup coverage to verify that valid cached credentials
trigger one setup attempt when registration is unready. Verify that setup
reloads credentials when registration becomes ready and returns an error
when it remains unready.

GitOrigin-RevId: 2822e8f294d98ea3df4f3bd7cf3f1e83ef5a2e7b
2026-11-18 00:32:46 +00:00
Benjamin Carlsson f39fcc1bfb Hold Cloud reply streams until history can be refreshed (#62140)
## Why

A Cloud conversation can miss an entire turn while disconnected. A
successful reattach, even with an idle thread, cannot establish that the
client's history is complete.

## What changed

Add an app-server client operation that reattaches a disconnected,
loaded Cloud thread and returns its cached settings. The worker holds
the replacement stream so the caller can refresh turn and item history
before explicitly installing the stream and receiving buffered events.

Reattachment, recovery history reads, and stream installation share a
deadline and use the original Cloud sign-in and network permit. Dropping
the release handle cancels the replacement. Personal access token
sessions still reconnect by reopening the conversation.

## Testing

Extend Cloud connection tests to cover quiet and busy reattachments,
buffered event delivery, cancellation and retry, slow history reads,
and sign-in changes during recovery.

GitOrigin-RevId: a4e5cb967e097021596bc83aac2f8d1a95373712
2026-11-18 00:32:11 +00:00
Benjamin Carlsson 1283c91ad7 Update crossterm to fix stray input when scrolling (#62139)
## Why

On Unix, a mouse scroll report split across terminal reads can be
misread as keystrokes and insert stray characters into the composer.

## What changed

Advance the `crossterm` pin in Cargo and Bazel to a revision that lets
both Unix input backends wait briefly for the rest of an escape sequence
before interpreting the initial byte as an Escape keypress.

GitOrigin-RevId: 3866299999ce0f61e331f848b821e07e113c454e
2026-11-18 00:30:46 +00:00
Charlie Marsh 3e5f072ca1 Use the state database first for TUI analytics thread lists (#62138)
## Why

Listing root threads for chat and task analytics can trigger filesystem
scans and metadata repair. The state database can serve these lists
without that work.

## What changed

Start root thread pagination with `thread/list` and `useStateDbOnly`
enabled. If the server returns JSON-RPC error `-32603`, discard the
partial results and restart from the first page with filesystem repair
enabled. SQLite cursors may identify different pages in the filesystem
listing.

## Testing

The chat analytics regression test simulates an error on the second
indexed page and checks that the fallback restarts pagination, excludes
discarded results, and preserves the usage estimate budget. The task
analytics test checks that only root listings use the database-only mode.

GitOrigin-RevId: 9de78a9eca4662df06d22a86cffb6e7bcba428cb
2026-11-18 00:18:42 +00:00
felixxia-oai 44de9d99ef Remove fixed message-board views and bulk subscriptions (#62137)
## Why

Guardian v3 reviewers can retrieve evidence from the live board, including
posts that arrive after a review begins. Fixed board views and bulk
subscription updates have no remaining callers outside tests.
https://github.com/openai/codex/commit/c2595ad3438311ce3070b1a7eef05cd0da8ad631

## What changed

Remove `BoardReadView`, its snapshot-specific tool bindings, and the
captured catalog and post cutoff from local board queries. Remove
`set_subscriptions` and keep individual subscription changes through
`set_subscription`.

Update the Guardian housekeeping test to check channel descriptions
through `list_channels`, and store captured Guardian evidence in an
owned vector.

GitOrigin-RevId: ede9e48abf4d009a2b4a82a437851657e41cf009
2026-11-18 00:03:53 +00:00
felixxia-oai 9e3681977b Deliver subscribed evidence to idle Guardian reviewers (#62136)
## Why

Guardian queued newly committed evidence for subscribed actors, but the
retained reviewer conversation did not consume that queue. A reviewer
could stay idle without receiving originals routed to it.

## What changed

Drain each actor's inbox when its reviewer becomes idle and before
reserving the conversation for a verdict. Read the queued posts by ID and
inject whole originals in source order within the reviewer's model budget,
without starting a model turn. Track delivery per conversation so a reused
reviewer receives each queued original once and a replacement can replay
the inbox.

## Testing

Cover delivery after the reviewer becomes idle, retention of queued
evidence after unsubscribe, and replay in a replacement conversation.

GitOrigin-RevId: ce83b98dc3eb2bae13ba0b7b5a82831a98b8aec4
2026-11-18 00:03:18 +00:00
felixxia-oai 5916098d02 Use live evidence retrieval and subscriber inboxes in Guardian (#62135)
## Why

A fixed evidence view hides posts routed after the review cutoff. Live
retrieval lets reviewers find those posts as they arrive while still
allowing intake to confirm that evidence through a requested history
position has been routed.

## What changed

Guardian retrieval tools search the live message board, including channels
the reviewer does not subscribe to. Subscription tools update only the
acting reviewer's subscriptions.

The housekeeper uses the subscribers present at each post's insertion to
queue one committed post per original in each recipient's inbox, even when
multiple subscribed channels match. It acknowledges catch-up requests
after routing and queuing evidence through the requested history position.

## Testing

Cover catch-up ordering, delivery based on subscription state at insertion,
live search across unsubscribed channels, and caller-scoped subscription
changes.

GitOrigin-RevId: 28b447d936f19ea68bd3c3adb297d473d65173c0
2026-11-18 00:02:00 +00:00
felixxia-oai 18d82cf7eb Add reusable per-agent reviewer conversations to Guardian v3 (#62134)
## What changed

Give the root agent and subagents with a board identity their own Guardian
reviewer reservation. Each new reviewer thread starts with empty history
and uses the acting agent's live message-board retrieval tools.

Keep one reservation active per agent and retain the conversation only
when the caller marks it reusable. Reuse requires matching reviewer settings
and history-reset version. Dropping a reservation retires its thread.

## Testing

Add an integration test that checks thread reuse after a reusable
disposition, replacement after an unfinished reservation is dropped, and
exclusion of legacy subagents without a board identity.

GitOrigin-RevId: c7bccf4651ad4e04c42d9aee1d9e8de24b5b48df
2026-11-17 23:48:01 +00:00
felixxia-oai c2595ad343 Add live evidence retrieval for Guardian v3 reviewers (#62133)
## Why

A captured board view limits evidence searches to the review's cutoff. A
verdict reviewer needs to be able to check for later evidence, including
restrictions or revocations, before deciding on an action.

## What changed

Add a live `guardian_board` binding that lets reviewers search and read
any Guardian evidence channel, including channels they do not follow.
Search also matches text inside JSON-encoded tool arguments.

Reviewers can list their own subscriptions with `subscribed_channels`
and subscribe or unsubscribe by channel. Subscriptions control delivery
of future evidence. Earlier posts are available through search and read
tools.

Let review setup and prewarming select guidance for the installed
retrieval tools. The live board guidance explains how to find original
user messages and assess their authority. Share the provider-scoped
reviewer header setup through the core Guardian review API.

## Testing

Cover searches beyond the captured cutoff and in unsubscribed channels,
paginated listing of the reviewer's own subscriptions, and channel-only
subscription changes in both live and captured views.

GitOrigin-RevId: c2e1c6c849346cd3d6e316bcf17e44260fcd4c8e
2026-11-17 23:47:24 +00:00
matthewdavis-oai 3bf4e138fe Stream partial thread search results and support cancellation (#62132)
## Why

Clients using `thread/search` have to wait for the search to finish before
they can show any matches. A search can also outlive the query that triggered
it, such as when a user changes their task mention query.

## What changed

- Add experimental `thread/search/stream` with best-effort
  `thread/search/partial` notifications. Each notification carries the original
  `requestId` and a batch of verified matches. Clients replace provisional
  matches with the final page, which determines results, ordering, and cursors.
- Support connection-scoped cancellation through `thread/search/stream/cancel`
  and `thread/search/cancel` for their respective search methods. Disconnecting
  also stops active searches and reaps their search subprocesses.
- Cancel superseded or timed-out TUI task mention searches without delaying
  available title matches.

## Testing

Add coverage for incremental results and final-page parity, slow clients,
connection-scoped cancellation and subprocess cleanup, and TUI task search
cancellation.

GitOrigin-RevId: b58abf7a1df424f191c8ede806d1d5266d299548
2026-11-17 23:46:48 +00:00
Dylan Hurd c90234de95 Isolate auth storage attribution tests from account switches (#62131)
## Why

Switching accounts revokes in-flight metric exports, which can interrupt
the auth storage events these app-server tests use to verify client
attribution.

## What changed

- Add a device-code login test that blocks the credential save by making
  `auth.json` a directory. Verify that login reports the failure and that
  the storage metric carries the `codex_vscode` originator. Keep the
  successful login and notification checks in their own test.
- Seed the concurrent-client test with the API key all three clients use
  so their writes keep the same account. Point the turn-cost probe at a
  local mock server and disable online model discovery.

GitOrigin-RevId: e735c2e0f81c6e58fd545943b47ff7bbd11339d7
2026-11-17 23:45:23 +00:00
Nick Steele 7066a55a7b Support enterprise MCP sign-in without refresh tokens (#62129)
## Why

An enterprise identity provider can return an OpenID Connect ID token
without issuing a refresh token, even when Codex requests
`offline_access`. The refresh-token requirement blocked those sign-ins.

## What changed

For `ema_auth`, keep requesting `offline_access` and prefer a refresh
token when available. Otherwise, use the stored ID token for the ID-JAG
exchange after checking its issuer, audience, and expiry. Require
reauthentication when the ID token is expired or invalid and no refresh
token is available.

Update `rmcp` to 3.6.0 for ID token exchange support.

## Testing

Add regression coverage for sign-in with and without a refresh token,
ID token expiry and issuer binding, and the subject token type sent to
the identity provider.

GitOrigin-RevId: ee7e253627c8274f9b3096e3b87e92e2f99885ea
2026-11-17 23:33:09 +00:00
jif e73da8bd1b Preserve base and developer instructions in host child preparation (#62128)
## Why

Hosts preparing a child thread lacked the parent's effective base
instructions and the developer instructions a native subagent would inherit.
Hosts also need the base instruction provenance to preserve custom text
while letting model-owned instructions resolve for the child's model.

## What changed

Include effective base instruction text and provenance in
`PreparedChildContext`. Share developer instruction selection with native
subagent creation so host preparation uses the configured V2 subagent
override when present and falls back to the parent turn's developer
instructions otherwise.

## Testing

Add integration coverage that starts a child on a different model and
checks that custom base instructions persist, model-owned instructions
resolve for the child model, and the V2 override takes precedence over
the parent developer instructions.

GitOrigin-RevId: 0e151e343e58d995c8901a9ba819cb7f60d248f5
2026-11-17 23:31:58 +00:00
Charlie Marsh ea6b64fd12 Use the local session index in the multi-backend resume picker (#62127)
## Why

The resume picker starts local-only listings from the state database.
When multiple backends are available, the shared listing mode makes
local backends use the default thread store listing too.

## What changed

Choose the initial page mode per backend. Local workspaces start with
`StateDbOnly`, and remote workspaces use `StoreDefault`. Each backend
paginates in its current mode and can fall back to `StoreDefault`
independently. Explicit recovery requests keep their requested mode.

## Testing

Cover mixed local and remote listings, per-backend fallback and
pagination, and an explicit recovery request after fallback fails.

GitOrigin-RevId: d0c9284211b86bb781b3df6642660054cb3c6ccf
2026-11-17 23:18:54 +00:00
Benjamin Carlsson 7d7af7b903 Share picker setup for the TUI status line and terminal title (#62126)
## Why

The status line and terminal title pickers duplicated the logic for
ordering configured items and displaying live rate-limit labels.

## What changed

Build both pickers' item lists with the same helper. Keep configured
items in order, skip unknown IDs, and collapse aliases to one row per
canonical ID. Use live rate-limit names and descriptions when available.

Use the shared multi-select picker directly for terminal title setup
and opt it in to accepting input while disconnected.

## Testing

Cover alias deduplication and configured order, and assert that the
title picker accepts input while disconnected while the shared picker
defaults to disabling it.

GitOrigin-RevId: 48971f003bd73523599d1d1ad677d855844767db
2026-11-17 23:18:18 +00:00
marksteinbrick-oai 9c60cb0a27 Include classifier turn IDs in Guardian v2 analytics (#62125)
## Why

Guardian v2 classification events need the classifier's turn ID to
correlate outcomes with the corresponding Responses requests.

## What changed

Assign one turn ID per classification and reuse it across request retries.
Once request preparation succeeds, include the same ID from
`client_metadata.turn_id` as `classifier_turn_id` in the classification event.

## Testing

Extend the scoped tool approval integration test to check that the event's
classifier turn ID matches the request metadata.

GitOrigin-RevId: b3ed4bea12cdc06d0b742775f34f296e9c4de376
2026-11-17 23:15:04 +00:00
andrewgu-oai 4e51bfbacc Refresh tool hashes in core scenario snapshots (#62124)
## What changed

Update the expected hashes for tool lists and incremental tool declarations
across seven core scenario snapshots. The fixtures cover Code Mode, dynamic
tools, and MCP discovery and sharing.

GitOrigin-RevId: 8d69870b488dffc5a24afe0e1c8f522335b25105
2026-11-17 22:58:38 +00:00
chess 84a93030e7 Restrict control of the Windows sandbox service (#62122)
## Why

Authenticated users need to query and start the sandbox service during
setup. Administrative operations such as stopping or reconfiguring the
service should require elevated privileges.

## What changed

Apply an explicit access control list during service startup. Grant full
control to Windows SYSTEM and elevated administrators, and give other
authenticated users limited access that includes querying and starting
the service. Fail startup if the permissions cannot be applied.

GitOrigin-RevId: 05f6e87eec6260935e1ff058f65369bd2e9c5a0f
2026-11-17 22:45:51 +00:00
Eric Traut 5f775c7f4f Add /rc to manage remote control from the TUI (#62121)
## What changed

Open `/rc` (or `/remote`) to enable or disable remote control for the
managed local background server. The menu checks whether the preference
was saved for the next restart and reports when saving fails. Once remote
control is enabled, **Add device** displays a manual pairing code.

The command can also manage the local server while viewing a cloud
session. Its actions apply only to local sessions.

## Testing

Add tests for menu states, daemon requests and manual pairing, local
daemon selection from a cloud session, and timeout messages.

GitOrigin-RevId: 888abaec3b041d78a6b35a9e76e28cd7dc5305ca
2026-11-17 22:45:02 +00:00
Dylan Hurd b8f6787e95 Stabilize TUI startup tests and strengthen daemon recovery coverage (#62116)
## Why

Model fetches can delay the startup screens that PTY tests wait for. Daemon compatibility recovery also probes the daemon version on a separate connection before offering a recovery choice.

## What changed

- Configure the daemon compatibility and external editor tests with a local catalog of bundled models to avoid model-fetch delays.
- Return a complete `InitializeResponse` from the mock daemon and verify the version probe's `initialize`/`initialized` handshake before selecting recovery.
- Keep the daemon listener open and assert that the TUI does not reconnect after choosing to run without the daemon, for both explicit feature enable and disable scenarios.

GitOrigin-RevId: 243f5075fca42d1192f0087e2cc21a6b0796226b
2026-11-17 22:14:52 +00:00
Shuo 8dcd56d0cb Add external header auth for existing realtime calls (#62114)
## What changed

Add `RealtimeExistingCallAuth` to `RealtimeAttachmentOptions`, with model-provider authentication as the default. Embedding hosts can explicitly select `ExternalHeaders` for existing calls to use header-based credentials and the host's transport without adding model-provider headers or performing runtime agent registration.

Require an explicit, nonempty sideband URL and header-based authentication for this mode. Destination authorization remains the trusted host's responsibility, and application network policy still applies.

## Testing

Add integration coverage for external-header and model-provider authentication through event delivery, reconnect, and detach. Verify that model-provider credentials are excluded in external-header mode and that invalid authentication, missing URLs, and network policy denials reject the attachment before a WebSocket handshake.

GitOrigin-RevId: 2c915e1cf76a3563f58f751272db1ec50718d925
2026-11-17 22:00:20 +00:00
nvogt-oai 39a7b53fa4 Trust the bundled Memory session hook without saved hashes (#62112)
## Why

The bundled Memory hook needs to supply context at startup and after compaction without requiring saved hook trust.

## What changed

Recognize the exact bundled Memory `SessionStart` declaration as a built-in hook: the `^(startup|compact)$` matcher, `codex_apps` server, `codex_dream_memory.get_mec` tool, and empty input. Carry the expected app connector identity through discovery for dispatch checks, and hide this built-in hook from hook listings while preserving other plugin hooks.

## Testing

Add coverage for exact declaration matching, hook listings without an Apps connection, and a scenario snapshot verifying memory context injection at startup and after compaction without saved trust.

GitOrigin-RevId: edc0e8ffa955227328345f46afecc2a868c0be49
2026-11-17 21:40:36 +00:00
Abhinav 8fca6ffb92 Support OTel header helpers in local managed requirements (#62110)
## What changed

- Allow system `requirements.toml` and MDM requirements to set `otel.headers_helper` and `otel.headers_helper_refresh_interval_ms`, and expose both fields through the requirements API.
- Require an absolute executable path and run managed helpers directly from their installation directory. Reject helper settings from cloud requirements.
- Restrict managed helper headers to OTLP HTTP exporters with nonempty endpoints configured in the same requirements layer. Replacing the helper or an exporter revokes the previous binding.
- Document deployment and rollback requirements, including client compatibility and pausing affected exports until a failed helper recovers.

## Testing

Add coverage for exporter layer boundaries, cloud policy rejection, relative path rejection, managed helper execution and recovery, missing executable diagnostics, and requirements API output.

GitOrigin-RevId: 271058010c2e3090eb97cb357b70be4dc41b43db
2026-11-17 21:10:09 +00:00
ben zhang 8011b92bc8 Log macOS user verification enrollment failure diagnostics (#62107)
## What changed

Add structured warnings for enrollment failures during key lookup, access control creation, key creation, key validation, and public key export. Include available native and underlying error codes and allowlisted error domains, without logging error descriptions or other error metadata.

After a failure, check biometric readiness using a fresh, noninteractive context and include the result in the warning. Preserve the original error classification.

GitOrigin-RevId: 697e1a69dc5c8e457b61aff9a674e7aca77f86f2
2026-11-17 20:05:26 +00:00
andrewgu-oai 6c0cee502d Add GPT-6.2 Sol and Astra to model catalogs (#62106)
## What changed

- Add `gpt-6.2-sol` and `gpt-6.2-astra` to the bundled, Amazon Bedrock, and Vertex catalogs, including Bedrock Runtime global and US cross-region variants.
- Make GPT-6.2 Sol the default catalog selection and refresh model ordering, descriptions, and bundled instructions.
- Increase the GPT-6.1 Sol context window to 500,000 tokens.
- Advertise the `ultrafast` service tier for GPT-6.2 Astra on Bedrock.
- Supply the same current model catalog to both executors in the prompt-prefix compatibility test so catalog updates do not cause prefix mismatches.

## Testing

Extend provider, app-server, and TUI coverage for catalog ordering, model fallback, Vertex requests, and GPT-6.2 Astra's Bedrock `ultrafast` selection and clearing behavior. Refresh model-picker and request snapshots.

GitOrigin-RevId: f28940e4a255fcdd88f7114873259bd1f3399812
2026-11-17 20:04:36 +00:00
Charlie Marsh 9a56c2b1aa Preserve plugin runtimes across catalog metadata updates (#62105)
## Why

An advertised plugin release or installation metadata change should preserve live MCP sessions and cached skills while the active local bundle remains unchanged, including when an upgrade fails.

## What changed

- Compare runtime identity, enablement, connector ownership, and the active bundle separately from catalog release, policy, and display metadata.
- Track the active bundle's directory version and persisted remote plugin ID so changes made by another process refresh the runtime.
- Retain pending runtime notifications until a host callback is available and deliver them through `plugin/reconcile`.
- Preserve cancellation recovery across retries while avoiding unnecessary runtime invalidation for catalog fetch failures.

## Testing

Add unit and app-server regression coverage for catalog-only updates, failed upgrades, externally activated bundles, deferred notifications, and reconciliation recovery.

GitOrigin-RevId: ab20012c1bfd760adea55614f49fbbc7ef86fe8b
2026-11-17 19:46:24 +00:00
Tom 7457b7268f Preserve trace context during WebSocket startup prewarm (#62103)
## What changed

- Inject the current span's W3C trace headers into WebSocket handshakes.
- Promote `startup_prewarm` to an info span and fall back to the current span when it is disabled, preserving trace context in the spawned task.

## Testing

Add a regression test for `traceparent` and `tracestate` propagation through the handshake, prewarm request, and subsequent turn on the same connection. Verify that prewarm uses the startup trace while the turn uses its own trace, with the prewarm span both enabled and filtered out.

GitOrigin-RevId: 1e196e132a1991206469060ab80a474857fa7909
2026-11-17 19:24:17 +00:00
Dylan Hurd 7fb2cd20c8 Stabilize app-server and login integration tests (#62102)
## What changed

- Run guardian action-budget permission hooks locally with a host-accessible working directory, and apply the test timeout to thread startup.
- Use an empty probe file for the process-spawn handshake, removing the content assertion after file creation is detected.
- Remove the explicit graceful shutdown from the config-server login/logout test.
- Wait for fallback login cancellation to finish and assert that it returns an error, replacing the two-second timeout.

GitOrigin-RevId: a696834162bf910bf114c35648366a4f94bb56f2
2026-11-17 19:23:05 +00:00