Commit Graph
12155 Commits
Author SHA1 Message Date
Michael Bolin 29c4dd96ae merge commit for archive created by Sapling 2026-04-21 07:37:22 -07:00
Michael Bolin f7d034ca9f build: reduce Rust dev debuginfo
The slow codex-core rebuilds are dominated by debug-info codegen, not parsing
or type checking. On a warm-dependency package rebuild, the baseline
codex-core compile was about 39.5s wall / 38.9s rustc total, with
codegen_crate around 14.0s and LLVM_passes around 13.4s. Setting codex-core
to line-tables-only debug info brought that to about 27.2s wall / 26.7s rustc
total, with codegen_crate around 3.1s and LLVM_passes around 2.8s.

I also sampled other first-party crates instead of keeping a codex-core-only
package override. codex-app-server showed the same pattern: rustc total
dropped from 15.85s to 10.48s, while codegen_crate plus LLVM_passes dropped
from about 13.47s to 3.23s. codex-app-server-protocol had a smaller but still
real improvement, 16.05s to 14.58s total, and smaller crates showed modest
wins. That points to a workspace dev-profile policy rather than a
hand-maintained list of large crates.

Use `[profile.dev] debug = 1` so local dev builds keep line tables and useful
backtraces while avoiding full variable debug info. This can cause a one-time
rebuild because the Cargo dev profile hash changes, but subsequent rebuilds
avoid the expensive debug-info work.

Bazel does not read Cargo profiles for this setting. rules_rust derives
debuginfo from Bazel toolchain/compilation-mode settings and the current
fastbuild action already emitted `--codegen=debuginfo=0`. This change makes
the CI choice explicit for both target and exec-configuration Rust actions
with `-Cdebuginfo=0`.

Verification:

- `just bazel-lock-update`
- `just bazel-lock-check`
- `cargo check -p codex-core --lib`
- `cargo test -p codex-core --lib`
- Bazel `aquery --config=ci-linux` confirmed `--codegen=debuginfo=0` and
  `-Cdebuginfo=0` for `//codex-rs/core:core`
2026-04-21 07:35:29 -07:00
Michael Bolin 4259a0df98 Merge dc9c6dc8c9 into sapling-pr-archive-bolinfest 2026-04-20 23:18:35 -07:00
Michael Bolin 63faf33300 merge commit for archive created by Sapling 2026-04-20 23:17:19 -07:00
Michael Bolin dc9c6dc8c9 tests: isolate approval fixtures from host rules 2026-04-20 23:16:54 -07:00
Michael Bolin c1cbd7a6fe shell-escalation: carry resolved permission profiles 2026-04-20 23:16:54 -07:00
Michael Bolin bbb84c437c mcp: include permission profiles in sandbox state 2026-04-20 23:16:54 -07:00
Michael Bolin 3bdedd091b tui: carry permission profiles on user turns 2026-04-20 23:16:54 -07:00
Michael Bolin fe05ed6838 tui: sync session permission profiles 2026-04-20 23:16:54 -07:00
Michael Bolin a673f976a1 app-server: accept command permission profiles 2026-04-20 23:16:54 -07:00
Michael Bolin f4b6873f50 protocol: report session permission profiles 2026-04-20 23:16:54 -07:00
Michael Bolin 072750e046 rollout: persist turn permission profiles 2026-04-20 23:16:54 -07:00
Michael Bolin ab0e270801 clients: send permission profiles to app-server 2026-04-20 23:16:54 -07:00
Michael Bolin 9d354ba7d9 app-server: accept permission profile overrides 2026-04-20 23:16:54 -07:00
Michael Bolin 40397502d5 app-server: expose thread permission profiles 2026-04-20 23:16:54 -07:00
Michael Bolin 8618f6482f core: derive active permission profiles 2026-04-20 23:16:54 -07:00
Michael Bolin 7ed53a50c3 exec-server: carry filesystem sandbox profiles 2026-04-20 23:16:54 -07:00
Michael Bolin cf9f1ea320 sandboxing: intersect permission profiles semantically 2026-04-20 23:16:53 -07:00
Michael Bolin 8a7d1a1db8 Merge 9a309e592e into sapling-pr-archive-bolinfest 2026-04-20 23:10:47 -07:00
Michael Bolin 9a309e592e tests: isolate approval fixtures from host rules 2026-04-20 23:09:48 -07:00
Michael Bolin 055fda9df9 shell-escalation: carry resolved permission profiles 2026-04-20 23:09:48 -07:00
Michael Bolin d776838702 mcp: include permission profiles in sandbox state 2026-04-20 23:09:48 -07:00
Michael Bolin 3b69ad41e6 tui: carry permission profiles on user turns 2026-04-20 23:09:48 -07:00
Michael Bolin e6e68b3b0d tui: sync session permission profiles 2026-04-20 23:09:48 -07:00
Michael Bolin f64a036721 app-server: accept command permission profiles 2026-04-20 23:09:48 -07:00
Michael Bolin e17a9a2f91 protocol: report session permission profiles 2026-04-20 23:09:48 -07:00
Michael Bolin b235e21b1a rollout: persist turn permission profiles 2026-04-20 23:09:48 -07:00
Michael Bolin ea8eb64bf7 clients: send permission profiles to app-server 2026-04-20 23:09:48 -07:00
Michael Bolin 1a9b5dc389 app-server: accept permission profile overrides 2026-04-20 23:09:48 -07:00
Michael Bolin 89da5a0825 app-server: expose thread permission profiles 2026-04-20 23:09:48 -07:00
Michael Bolin 5ae72d87dc core: derive active permission profiles 2026-04-20 23:09:48 -07:00
Michael Bolin 668e164a0d exec-server: carry filesystem sandbox profiles 2026-04-20 23:09:48 -07:00
Michael Bolin 5bc0ac8294 sandboxing: intersect permission profiles semantically 2026-04-20 23:09:48 -07:00
Michael Bolin 1dcea729d3 chore: enable await-holding clippy lints (#18698)
Follow-up to https://github.com/openai/codex/pull/18178, where we said
the await-holding clippy rule would be enabled separately.

Enable `await_holding_lock` and `await_holding_invalid_type` after the
preceding commits fixed or explicitly documented the current offenders.
2026-04-21 06:06:05 +00:00
Michael Bolin 04de961d22 merge commit for archive created by Sapling 2026-04-20 22:55:03 -07:00
Michael Bolin 0614e9f1ab tests: isolate approval fixtures from host rules 2026-04-20 22:54:43 -07:00
Michael Bolin 5454243057 shell-escalation: carry resolved permission profiles 2026-04-20 22:54:43 -07:00
Michael Bolin df803281cf mcp: include permission profiles in sandbox state 2026-04-20 22:54:43 -07:00
Michael Bolin e0554ee748 tui: carry permission profiles on user turns 2026-04-20 22:54:43 -07:00
Michael Bolin ff5026da6c tui: sync session permission profiles 2026-04-20 22:54:43 -07:00
Michael Bolin 906e02007c app-server: accept command permission profiles 2026-04-20 22:54:43 -07:00
Michael Bolin 0f16cb0995 protocol: report session permission profiles 2026-04-20 22:54:43 -07:00
Michael Bolin 43a0192183 rollout: persist turn permission profiles 2026-04-20 22:54:43 -07:00
Michael Bolin 44c5e27996 clients: send permission profiles to app-server 2026-04-20 22:54:43 -07:00
Michael Bolin 99292055e2 app-server: accept permission profile overrides 2026-04-20 22:54:43 -07:00
Michael Bolin ecfabb04da app-server: expose thread permission profiles 2026-04-20 22:54:43 -07:00
Michael Bolin 70709987b6 core: derive active permission profiles 2026-04-20 22:54:43 -07:00
Michael Bolin 45aa43ad88 exec-server: carry filesystem sandbox profiles 2026-04-20 22:54:43 -07:00
Michael Bolin d4fca7cba9 sandboxing: intersect permission profiles semantically 2026-04-20 22:54:43 -07:00
Michael Bolin 9d5825ab6e merge commit for archive created by Sapling 2026-04-20 22:49:19 -07:00