Commit Graph
10510 Commits
Author SHA1 Message Date
Michael Bolin 23ff2a1795 Merge ac60b5ba8f into sapling-pr-archive-bolinfest 2026-03-28 12:52:48 -07:00
Michael Bolin ac60b5ba8f ci: run Windows argument-comment-lint via native Bazel 2026-03-28 12:51:54 -07:00
Eric Traut 48144a7fa4 Remove remaining custom prompt support (#16115)
## Summary
- remove protocol and core support for discovering and listing custom
prompts
- simplify the TUI slash-command flow and command popup to built-in
commands only
- delete obsolete custom prompt tests, helpers, and docs references
- clean up downstream event handling for the removed protocol events
2026-03-28 13:49:37 -06:00
Michael Bolin ec68f8c22a merge commit for archive created by Sapling 2026-03-28 12:49:19 -07:00
Michael Bolin 90e10bbc19 stabilize zsh-fork approvals and resume --last 2026-03-28 12:48:29 -07:00
Michael Bolin 92f520af4c merge commit for archive created by Sapling 2026-03-28 12:45:12 -07:00
Michael Bolin da925f1770 ci: run Windows argument-comment-lint via native Bazel 2026-03-28 12:44:56 -07:00
Michael Bolin fce0f76d57 build: migrate argument-comment-lint to a native Bazel aspect (#16106)
## Why

`argument-comment-lint` had become a PR bottleneck because the repo-wide
lane was still effectively running a `cargo dylint`-style flow across
the workspace instead of reusing Bazel's Rust dependency graph. That
kept the lint enforced, but it threw away the main benefit of moving
this job under Bazel in the first place: metadata reuse and cacheable
per-target analysis in the same shape as Clippy.

This change moves the repo-wide lint onto a native Bazel Rust aspect so
Linux and macOS can lint `codex-rs` without rebuilding the world
crate-by-crate through the wrapper path.

## What Changed

- add a nightly Rust toolchain with `rustc-dev` for Bazel and a
dedicated crate-universe repo for `tools/argument-comment-lint`
- add `tools/argument-comment-lint/driver.rs` and
`tools/argument-comment-lint/lint_aspect.bzl` so Bazel can run the lint
as a custom `rustc_driver`
- switch repo-wide `just argument-comment-lint` and the Linux/macOS
`rust-ci` lanes to `bazel build --config=argument-comment-lint
//codex-rs/...`
- keep the Python/DotSlash wrappers as the package-scoped fallback path
and as the current Windows CI path
- gate the Dylint entrypoint behind a `bazel_native` feature so the
Bazel-native library avoids the `dylint_*` packaging stack
- update the aspect runtime environment so the driver can locate
`rustc_driver` correctly under remote execution
- keep the dedicated `tools/argument-comment-lint` package tests and
wrapper unit tests in CI so the source and packaged entrypoints remain
covered

## Verification

- `python3 -m unittest discover -s tools/argument-comment-lint -p
'test_*.py'`
- `cargo test` in `tools/argument-comment-lint`
- `bazel build
//tools/argument-comment-lint:argument-comment-lint-driver
--@rules_rust//rust/toolchain/channel=nightly`
- `bazel build --config=argument-comment-lint
//codex-rs/utils/path-utils:all`
- `bazel build --config=argument-comment-lint
//codex-rs/rollout:rollout`







---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/openai/codex/pull/16106).
* #16120
* __->__ #16106
2026-03-28 12:41:56 -07:00
Michael Bolin 51d174aa3c merge commit for archive created by Sapling 2026-03-28 12:22:53 -07:00
Michael Bolin 5495a3f27e ci: run Windows argument-comment-lint via native Bazel 2026-03-28 12:22:46 -07:00
Michael Bolin 865f58ed79 merge commit for archive created by Sapling 2026-03-28 12:13:58 -07:00
Michael Bolin 6e69a6cac5 ci: run Windows argument-comment-lint via native Bazel 2026-03-28 12:13:49 -07:00
Michael Bolin 7310bf6389 merge commit for archive created by Sapling 2026-03-28 12:03:13 -07:00
Michael Bolin 0bcb13b032 ci: run Windows argument-comment-lint via native Bazel 2026-03-28 12:02:57 -07:00
Michael Bolin 8c87ac2ca6 Merge b8972c1c39 into sapling-pr-archive-bolinfest 2026-03-28 11:44:00 -07:00
Michael Bolin b8972c1c39 ci: run Windows argument-comment-lint via native Bazel 2026-03-28 11:43:46 -07:00
Michael Bolin a42d109d38 merge commit for archive created by Sapling 2026-03-28 11:27:07 -07:00
Michael Bolin d301137cfb ci: run Windows argument-comment-lint via native Bazel 2026-03-28 11:26:36 -07:00
Michael Bolin 90a9f79889 Merge a5fb96dc40 into sapling-pr-archive-bolinfest 2026-03-28 11:21:44 -07:00
Michael Bolin a5fb96dc40 ci: run Windows argument-comment-lint via native Bazel 2026-03-28 11:21:41 -07:00
Michael Bolin 59cda84f8c Merge c67cf0b9c4 into sapling-pr-archive-bolinfest 2026-03-28 11:16:57 -07:00
Michael Bolin c67cf0b9c4 ci: run Windows argument-comment-lint via native Bazel 2026-03-28 11:16:49 -07:00
Michael Bolin b85f017527 Merge 5ffa06bab9 into sapling-pr-archive-bolinfest 2026-03-28 11:09:55 -07:00
Michael Bolin 5ffa06bab9 ci: run argument-comment-lint through bazel package tests 2026-03-28 11:09:46 -07:00
Michael Bolin 65f631c3d6 fix: fix comment linter lint violations in Linux-only code (#16118)
https://github.com/openai/codex/pull/16071 took care of this for
Windows, so this takes care of things for Linux.

We don't touch the CI jobs in this PR because
https://github.com/openai/codex/pull/16106 is going to be the real fix
there (including a major speedup!).
2026-03-28 11:09:41 -07:00
Michael Bolin 04e3d04d30 Merge 318e7740ef into sapling-pr-archive-bolinfest 2026-03-28 11:06:09 -07:00
Michael Bolin 318e7740ef fix: fix comment linter lint violations in Linux-only code 2026-03-28 11:05:40 -07:00
Eric Traut 61429a6c10 Rename tui_app_server to tui (#16104)
This is a follow-up to https://github.com/openai/codex/pull/15922. That
previous PR deleted the old `tui` directory and left the new
`tui_app_server` directory in place. This PR renames `tui_app_server` to
`tui` and fixes up all references.
2026-03-28 11:23:07 -06:00
Michael Bolin 733df3cdb8 merge commit for archive created by Sapling 2026-03-28 09:38:26 -07:00
Michael Bolin 9e7f6b26cf build: migrate argument-comment-lint to a native Bazel aspect 2026-03-28 09:38:15 -07:00
Eric Traut 3d1abf3f3d Update PR babysitter skill for review replies and resolution (#16112)
This PR updates the "PR Babysitter" skill to clarify that non-actionable
review comments should receive a direct reply explaining why no change
is needed, and actionable review comments should be marked "resolved"
after they are addressed.
2026-03-28 10:35:20 -06:00
Michael Bolin 39e8fe9c11 merge commit for archive created by Sapling 2026-03-28 09:15:26 -07:00
Michael Bolin d5424b571e build: migrate argument-comment-lint to a native Bazel aspect 2026-03-28 09:15:11 -07:00
Michael Bolin f93bfe1ac4 merge commit for archive created by Sapling 2026-03-28 08:49:36 -07:00
Michael Bolin 501fc122b5 build: migrate argument-comment-lint to a native Bazel aspect 2026-03-28 08:49:28 -07:00
Michael Bolin 999f10f9c8 merge commit for archive created by Sapling 2026-03-28 08:40:51 -07:00
Michael Bolin d9411c1b7f build: migrate argument-comment-lint to a native Bazel aspect 2026-03-28 08:40:41 -07:00
Michael Bolin a763f9af48 Merge d6d4dbcfab into sapling-pr-archive-bolinfest 2026-03-28 08:28:11 -07:00
Michael Bolin d6d4dbcfab build: migrate argument-comment-lint to a native Bazel aspect 2026-03-28 08:27:48 -07:00
Felipe CouryandEric Traut bede1d9e23 fix(tui): refresh footer on collaboration mode changes (#16026)
## Summary
- Moves status surface refresh (`refresh_status_surfaces` /
`refresh_status_line`) from `App` event handlers into `ChatWidget`
setters via a new `refresh_model_dependent_surfaces()` method
- Ensures model-dependent UI stays in sync whenever collaboration mode,
model, or reasoning effort changes, including the footer and terminal
title in both `tui` and `tui_app_server`
- Applies the fix to both `tui` and `tui_app_server` widgets

#15961

## Test plan
- [x] Added snapshot test
`status_line_model_with_reasoning_plan_mode_footer` verifying footer
renders correctly in plan mode
- [x] Added
`terminal_title_model_updates_on_model_change_without_manual_refresh` in
`tui_app_server`
- [ ] Verify switching collaboration modes updates the footer in real
TUI
- [ ] Verify model/reasoning effort changes reflect in the status bar
and terminal title

---------

Co-authored-by: Eric Traut <etraut@openai.com>
2026-03-28 08:55:32 -06:00
Michael Bolin fda1ef1b3d Merge acd10385b4 into sapling-pr-archive-bolinfest 2026-03-28 04:52:10 -07:00
Michael Bolin acd10385b4 ci: run argument-comment-lint through bazel package tests 2026-03-28 04:52:07 -07:00
Michael Bolin 82f818672c merge commit for archive created by Sapling 2026-03-28 04:20:28 -07:00
Michael Bolin a4200b969c ci: run argument-comment-lint through bazel package tests 2026-03-28 04:20:22 -07:00
Michael Bolin 803289f29b Merge 1608791b3e into sapling-pr-archive-bolinfest 2026-03-28 03:17:31 -07:00
Michael Bolin 1608791b3e ci: run argument-comment-lint through bazel package tests 2026-03-28 03:17:26 -07:00
Michael Bolin 6afba17422 merge commit for archive created by Sapling 2026-03-28 02:01:04 -07:00
Michael Bolin 335f56b5ed ci: run argument-comment-lint through bazel package tests 2026-03-28 02:00:57 -07:00
Michael Bolin 9bdef62d08 merge commit for archive created by Sapling 2026-03-28 00:52:04 -07:00
Michael Bolin 52e610b8cd ci: run argument-comment-lint through bazel package tests 2026-03-28 00:51:56 -07:00