openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-28 18:58:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move MCP UI capability tests to sibling module

Browse Source
This commit is contained in:
martinauyeung-oai
2026-07-07 04:26:39 -07:00
parent ad1db47cec
commit fed1dd3b8d
2 changed files with 94 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/codex-mcp/src/client_capabilities.rs
+2 -92
View File
@@ -64,95 +64,5 @@ pub(crate) fn with_client_capabilities_meta(
}
#[cfg(test)]
mod tests {
use pretty_assertions::assert_eq;
use serde_json::json;
use super::*;
#[test]
fn recognizes_only_the_webview_mime_type() {
let extensions = HashMap::from([
(
MCP_APP_UI_EXTENSION_ID.to_string(),
json!({
"mimeTypes": [
MCP_APP_UI_WEBVIEW_MIME_TYPE,
"text/x-dil;profile=mcp-app",
],
}),
),
("example/other".to_string(), json!({"enabled": true})),
]);
assert!(supports_mcp_app_ui_webview(Some(&extensions)));
assert!(!supports_mcp_app_ui_webview(Some(&HashMap::from([(
MCP_APP_UI_EXTENSION_ID.to_string(),
json!({"mimeTypes": ["text/x-dil;profile=mcp-app"]}),
),]))));
assert!(!supports_mcp_app_ui_webview(Some(&HashMap::from([(
MCP_APP_UI_EXTENSION_ID.to_string(),
json!("invalid")
),]))));
}
#[test]
fn trusted_capabilities_replace_spoofed_request_metadata() {
let meta = with_client_capabilities_meta(
Some(json!({
MCP_CLIENT_CAPABILITIES_META_KEY: {"spoofed": true},
"caller": "preserved",
})),
/*supports_mcp_app_ui_webview*/ true,
);
assert_eq!(
meta,
Some(json!({
"caller": "preserved",
MCP_CLIENT_CAPABILITIES_META_KEY: {
"extensions": {
MCP_APP_UI_EXTENSION_ID: {
"mimeTypes": [
MCP_APP_UI_WEBVIEW_MIME_TYPE,
]
}
}
}
}))
);
}
#[test]
fn absent_host_capabilities_remove_spoofed_request_metadata() {
assert_eq!(
with_client_capabilities_meta(
Some(json!({
MCP_CLIENT_CAPABILITIES_META_KEY: {"spoofed": true},
"caller": "preserved",
})),
/*supports_mcp_app_ui_webview*/ false,
),
Some(json!({"caller": "preserved"}))
);
}
#[test]
fn invalid_caller_metadata_does_not_suppress_trusted_capabilities() {
assert_eq!(
with_client_capabilities_meta(
Some(json!("invalid")),
/*supports_mcp_app_ui_webview*/ true,
),
Some(json!({
MCP_CLIENT_CAPABILITIES_META_KEY: {
"extensions": {
MCP_APP_UI_EXTENSION_ID: {
"mimeTypes": [MCP_APP_UI_WEBVIEW_MIME_TYPE],
}
}
}
}))
);
}
}
#[path = "client_capabilities_tests.rs"]
mod tests;
codex-rs/codex-mcp/src/client_capabilities_tests.rs
+92
View File
@@ -0,0 +1,92 @@
use std::collections::HashMap;
use pretty_assertions::assert_eq;
use serde_json::json;
use super::*;
#[test]
fn recognizes_only_the_webview_mime_type() {
let extensions = HashMap::from([
(
MCP_APP_UI_EXTENSION_ID.to_string(),
json!({
"mimeTypes": [
MCP_APP_UI_WEBVIEW_MIME_TYPE,
"text/x-dil;profile=mcp-app",
],
}),
),
("example/other".to_string(), json!({"enabled": true})),
]);
assert!(supports_mcp_app_ui_webview(Some(&extensions)));
assert!(!supports_mcp_app_ui_webview(Some(&HashMap::from([(
MCP_APP_UI_EXTENSION_ID.to_string(),
json!({"mimeTypes": ["text/x-dil;profile=mcp-app"]}),
),]))));
assert!(!supports_mcp_app_ui_webview(Some(&HashMap::from([(
MCP_APP_UI_EXTENSION_ID.to_string(),
json!("invalid")
),]))));
}
#[test]
fn trusted_capabilities_replace_spoofed_request_metadata() {
let meta = with_client_capabilities_meta(
Some(json!({
MCP_CLIENT_CAPABILITIES_META_KEY: {"spoofed": true},
"caller": "preserved",
})),
/*supports_mcp_app_ui_webview*/ true,
);
assert_eq!(
meta,
Some(json!({
"caller": "preserved",
MCP_CLIENT_CAPABILITIES_META_KEY: {
"extensions": {
MCP_APP_UI_EXTENSION_ID: {
"mimeTypes": [
MCP_APP_UI_WEBVIEW_MIME_TYPE,
]
}
}
}
}))
);
}
#[test]
fn absent_host_capabilities_remove_spoofed_request_metadata() {
assert_eq!(
with_client_capabilities_meta(
Some(json!({
MCP_CLIENT_CAPABILITIES_META_KEY: {"spoofed": true},
"caller": "preserved",
})),
/*supports_mcp_app_ui_webview*/ false,
),
Some(json!({"caller": "preserved"}))
);
}
#[test]
fn invalid_caller_metadata_does_not_suppress_trusted_capabilities() {
assert_eq!(
with_client_capabilities_meta(
Some(json!("invalid")),
/*supports_mcp_app_ui_webview*/ true,
),
Some(json!({
MCP_CLIENT_CAPABILITIES_META_KEY: {
"extensions": {
MCP_APP_UI_EXTENSION_ID: {
"mimeTypes": [MCP_APP_UI_WEBVIEW_MIME_TYPE],
}
}
}
}))
);
}