openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-14 11:57:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix rusty_v8 runtime archive staging in CI

Browse Source
This commit is contained in:
Channing Conger
2026-03-14 08:15:19 +00:00
parent e1ce599001
commit e268210ea5
2 changed files with 24 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
.github/scripts/rusty_v8_bazel.py vendored
View File

@@ -23,6 +23,11 @@ RUNTIME_LIB_FILENAMES = {
"libcxxabi": "liblibcxxabi.static.a",
"libunwind": "liblibunwind.static.a",
}
RUNTIME_LIB_LABELS = {
"libcxx": "@llvm//runtimes/libcxx:libcxx.static",
"libcxxabi": "@llvm//runtimes/libcxx:libcxxabi.static",
"libunwind": "@llvm//runtimes/libunwind:libunwind.static",
}
V8_CACHE_KEY_INPUT_PATTERNS = [
".bazelrc",
".bazelversion",
@@ -120,13 +125,6 @@ def platform_bin_dir(platform: str) -> Path:
return bazel_execroot() / "bazel-out" / f"{platform}-fastbuild" / "bin"
def platform_st_bin_dir(platform: str) -> Path:
matches = sorted((bazel_execroot() / "bazel-out").glob(f"{platform}-fastbuild-ST-*/bin"))
if not matches:
raise SystemExit(f"could not find ST bin dir for {platform}")
return matches[-1]
def toolchain_dir() -> Path:
return find_single_path(
"external/llvm++http_archive+llvm-toolchain-minimal-*",
@@ -153,14 +151,20 @@ def musl_generated_include_dir(platform: str, target: str) -> Path:
def static_runtime_libs(platform: str) -> tuple[Path, Path, Path]:
st_bin = platform_st_bin_dir(platform)
libcxx = st_bin / f"external/llvm++llvm_source+libcxx/libcxx.static_/{RUNTIME_LIB_FILENAMES['libcxx']}"
libcxxabi = st_bin / f"external/llvm++llvm_source+libcxxabi/libcxxabi.static_/{RUNTIME_LIB_FILENAMES['libcxxabi']}"
libunwind = st_bin / f"external/llvm++llvm_source+libunwind/libunwind.static_/{RUNTIME_LIB_FILENAMES['libunwind']}"
outputs = bazel_output_files(platform, list(RUNTIME_LIB_LABELS.values()))
return (
first_existing_path([libcxx], "libcxx static archive"),
first_existing_path([libcxxabi], "libcxxabi static archive"),
first_existing_path([libunwind], "libunwind static archive"),
first_existing_path(
[path for path in outputs if path.name == RUNTIME_LIB_FILENAMES["libcxx"]],
"libcxx static archive",
),
first_existing_path(
[path for path in outputs if path.name == RUNTIME_LIB_FILENAMES["libcxxabi"]],
"libcxxabi static archive",
),
first_existing_path(
[path for path in outputs if path.name == RUNTIME_LIB_FILENAMES["libunwind"]],
"libunwind static archive",
),
)

6
.github/workflows/rusty-v8-bazel-build.yml vendored
View File

@@ -99,12 +99,18 @@ jobs:
target_suffix="${TARGET//-/_}"
lib_target="//third_party/v8:v8_${version_suffix}_${target_suffix}"
binding_target="//third_party/v8:src_binding_release_${target_suffix}"
runtime_targets=(
'@llvm//runtimes/libcxx:libcxx.static'
'@llvm//runtimes/libcxx:libcxxabi.static'
'@llvm//runtimes/libunwind:libunwind.static'
)
bazel_args=(
build
"--platforms=@llvm//platforms:${PLATFORM}"
"${lib_target}"
"${binding_target}"
"${runtime_targets[@]}"
'--remote_download_regex=.*third_party/v8/libv8_.*\.a$'
'--remote_download_regex=.*third_party/v8/src_binding_release_.*\.rs$'
'--remote_download_regex=.*liblibcxx\.static\.a$'