openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-14 11:57:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

better encoding

Browse Source
This commit is contained in:
jif-oai
2026-01-09 12:06:06 +00:00
parent 7bc77bdd0c
commit ddd46d8f99
1 changed files with 46 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
codex-rs/protocol/src/models.rs
View File

@@ -329,10 +329,10 @@ impl From<Vec<UserInput>> for ResponseInputItem {
Ok(inline) => inline,
Err(err) => return Some(inline_image_error_placeholder(err)),
};
let Some(mime) = inline.mime.as_deref() else {
return Some(unsupported_inline_image_error_placeholder("unknown"));
};
if !mime.starts_with("image/") {
if let Some(mime) = inline.mime.as_deref()
&& !mime.starts_with("image/")
&& mime != "application/octet-stream"
{
return Some(unsupported_inline_image_error_placeholder(mime));
}
match load_and_resize_bytes(
@@ -629,6 +629,48 @@ mod tests {
}
}
#[test]
fn data_url_with_generic_mime_is_processed_locally() {
let payload = "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMB/ee9bQAAAABJRU5ErkJggg==";
let item = ResponseInputItem::from(vec![UserInput::Image {
image_url: format!("data:application/octet-stream;base64,{}", payload),
}]);
let ResponseInputItem::Message { content, .. } = item else {
panic!("expected message response input");
};
match content.as_slice() {
[ContentItem::InputImage { image_url }] => {
assert!(image_url.starts_with("data:image/"));
}
[ContentItem::InputText { text }] => {
panic!("expected input image, got placeholder: {text}");
}
_ => panic!("expected single input content item"),
}
}
#[test]
fn data_url_with_missing_mime_is_processed_locally() {
let payload = "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMB/ee9bQAAAABJRU5ErkJggg==";
let item = ResponseInputItem::from(vec![UserInput::Image {
image_url: format!("data:;base64,{}", payload),
}]);
let ResponseInputItem::Message { content, .. } = item else {
panic!("expected message response input");
};
match content.as_slice() {
[ContentItem::InputImage { image_url }] => {
assert!(image_url.starts_with("data:image/"));
}
[ContentItem::InputText { text }] => {
panic!("expected input image, got placeholder: {text}");
}
_ => panic!("expected single input content item"),
}
}
#[test]
fn data_url_with_non_image_mime_renders_placeholder() {
let item = ResponseInputItem::from(vec![UserInput::Image {