openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-18 17:18:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clarify ChatGPT sign-in success copy (#49031)

Browse Source 
Describe permissions and approvals explicitly in the Codex docs link text,
and clarify that the user's ChatGPT plan rate limits and training data
preferences apply. Remove the “Before you start” preamble to shorten the
success screen.

Update the rendering snapshot and hyperlink styling assertions for the
revised copy and layout.

GitOrigin-RevId: 5166ddade6a433191fa86c960899c4da5092b9f5
This commit is contained in:
Benjamin Carlsson
2026-09-28 16:52:39 +00:00
committed by copyberry
parent f817e16905
commit d8fc718809
1 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/tui/src/onboarding/auth.rs
+16 -17
View File
@@ -619,17 +619,19 @@ impl AuthModeWidget {
}
fn render_chatgpt_success_message(&self, area: Rect, buf: &mut Buffer) {
let mut docs_line = HyperlinkLine::new(Line::from(" For more details see the ").dim());
let mut docs_line =
HyperlinkLine::new(Line::from(" Learn about permissions and approvals in the ").dim());
docs_line.push_span(
"Codex docs".underlined(),
Some("https://developers.openai.com/codex/security"),
);
let mut preferences_line =
HyperlinkLine::new(Line::from(" Uses your plan's rate limits and ").dim());
HyperlinkLine::new(Line::from(" Your plan's rate limits and ").dim());
preferences_line.push_span(
"training data preferences".underlined(),
Some("https://chatgpt.com/#settings"),
);
preferences_line.push_span(" apply".into(), /*destination*/ None);
let lines = vec![
HyperlinkLine::new(
@@ -638,9 +640,7 @@ impl AuthModeWidget {
.into(),
),
"".into(),
" Before you start:".into(),
"".into(),
" Decide how much autonomy you want to grant Codex".into(),
" You're in control".into(),
docs_line,
"".into(),
" Codex can make mistakes".into(),
@@ -650,7 +650,7 @@ impl AuthModeWidget {
.into(),
),
"".into(),
" Powered by your ChatGPT account".into(),
" Included with your ChatGPT plan".into(),
preferences_line,
"".into(),
HyperlinkLine::new(Line::from(vec![
@@ -1492,7 +1492,7 @@ mod tests {
fn chatgpt_success_message_renders_osc8_hyperlinks() {
let runtime = tokio::runtime::Runtime::new().unwrap();
let (widget, _tmp) = runtime.block_on(widget_forced_chatgpt());
let area = Rect::new(0, 0, 80, 14);
let area = Rect::new(0, 0, 80, 12);
let mut buf = Buffer::empty(area);
widget.render_chatgpt_success_message(area, &mut buf);
@@ -1506,18 +1506,19 @@ mod tests {
"training data preferences"
);
assert_eq!(
(0..37).map(|x| buf[(x, 5)].modifier).collect::<Vec<_>>(),
(0..57).map(|x| buf[(x, 3)].modifier).collect::<Vec<_>>(),
[
vec![Modifier::DIM; 27],
vec![Modifier::DIM; 47],
vec![Modifier::DIM | Modifier::UNDERLINED; 10],
]
.concat()
);
assert_eq!(
(0..60).map(|x| buf[(x, 11)].modifier).collect::<Vec<_>>(),
(0..61).map(|x| buf[(x, 9)].modifier).collect::<Vec<_>>(),
[
vec![Modifier::DIM; 35],
vec![Modifier::DIM; 30],
vec![Modifier::DIM | Modifier::UNDERLINED; 25],
vec![Modifier::DIM; 6],
]
.concat()
);
@@ -1536,16 +1537,14 @@ mod tests {
insta::assert_snapshot!(visible, @r###"
✓ Signed in with your ChatGPT account
Before you start:
Decide how much autonomy you want to grant Codex
For more details see the Codex docs
You're in control
Learn about permissions and approvals in the Codex docs
Codex can make mistakes
Review the code it writes and commands it runs
Powered by your ChatGPT account
Uses your plan's rate limits and training data preferences
Included with your ChatGPT plan
Your plan's rate limits and training data preferences apply
Press enter to continue
"###);