Pause runtime sandbox integrity checks (#62389)

## Why

The telemetry-only integrity checks duplicate policy preparation already
performed by sandbox enforcement.

## What changed

Disable integrity checks at the shared entry point for exec-server and legacy
local execution. Command launches now skip integrity dependency discovery,
policy preparation, and telemetry.

## Testing

Ignore the command-launch integration cases for checker errors and timeouts
while runtime checks are paused. Keep the isolated checker tests.

GitOrigin-RevId: e29d3538e5c8fc943c1a265d75508ee904bfc166
This commit is contained in:
iceweasel-oai
2026-11-19 01:16:07 +00:00
committed by copyberry
parent f1b6986416
commit c332754aa3
3 changed files with 13 additions and 2 deletions
+1
View File
@@ -1339,6 +1339,7 @@ async fn build_exec_request_projects_workspace_roots_only_for_windows_sandbox()
#[test_case(false; "checker_error")]
#[test_case(true; "checker_timeout")]
#[ignore = "sandbox integrity checks are paused"]
fn command_runs_after_integrity_check_failure(time_out: bool) -> anyhow::Result<()> {
let directory = tempfile::tempdir()?;
let cwd = directory.path().abs();
@@ -1,6 +1,11 @@
# Sandbox integrity: scope and review contract
These checks currently emit telemetry only. Findings and preparation errors must
Runtime integrity checks are paused at the shared runner entry point. Do not
perform dependency discovery, policy preparation, checks, or telemetry during
command execution. The checker implementation and isolated tests remain for now;
the command-launch failure/timeout integration test is ignored while paused.
When enabled, these checks emit telemetry only. Findings and preparation errors must
not change sandbox construction, permissions, approvals, or command execution.
Supported backends are Seatbelt, bubblewrap, and MXC; legacy Windows is out of scope.
@@ -1,4 +1,5 @@
//! Prepare the policy and dependency facts, then run checks per dependency.
//! Runtime checks are paused; retain the implementation for isolated tests.
//! Results never affect execution. See AGENTS.md for scope and accepted approximations.
use super::backend;
@@ -13,12 +14,16 @@ use std::io;
use std::time::Duration;
use std::time::Instant;
// Pause all observations to avoid duplicating enforcement's policy preparation.
const INTEGRITY_CHECKS_ENABLED: bool = false;
const CHECK_TIMEOUT: Duration = Duration::from_secs(/*secs*/ 5);
/// Observe executor-local containment dependencies without affecting the launch.
/// Used by both exec-server and the legacy local execution path.
pub async fn run_integrity_checks(request: SandboxIntegrityRequest<'_>) {
run_checks_with_metrics(request, codex_otel::global().as_ref()).await;
if INTEGRITY_CHECKS_ENABLED {
run_checks_with_metrics(request, codex_otel::global().as_ref()).await;
}
}
async fn run_checks_with_metrics(