build: fix V8 Python cross-exec

This commit is contained in:
Adam Perry
2026-06-22 11:51:14 -07:00
committed by Adam Perry @ OpenAI
parent 6a71ade683
commit b9afe5dcd1
+10 -16
View File
@@ -242,15 +242,14 @@ index b432f86..28c567b 100644
],
outs = [
"include/inspector/Debugger.h",
@@ -4462,15 +4467,21 @@ genrule(
@@ -4462,15 +4467,16 @@ genrule(
"src/inspector/protocol/Schema.cpp",
"src/inspector/protocol/Schema.h",
],
- cmd = "$(location :code_generator) --jinja_dir . \
- --inspector_protocol_dir third_party/inspector_protocol \
+ cmd = "INSPECTOR_PROTOCOL_DIR=$$(dirname $(execpath third_party/inspector_protocol/code_generator.py)); \
+ PYTHONPATH=$$INSPECTOR_PROTOCOL_DIR:external/rules_python++pip+v8_python_deps_311_jinja2/site-packages:external/rules_python++pip+v8_python_deps_311_markupsafe/site-packages:$${PYTHONPATH-} \
+ $(PYTHON3) $(execpath third_party/inspector_protocol/code_generator.py) --jinja_dir . \
+ $(location :code_generator) --jinja_dir . \
+ --inspector_protocol_dir $$INSPECTOR_PROTOCOL_DIR \
--config $(location :src/inspector/inspector_protocol_config.json) \
--config_value protocol.path=$(location :include/js_protocol.pdl) \
@@ -259,16 +258,11 @@ index b432f86..28c567b 100644
- local = 1,
message = "Generating inspector files",
tools = [
- ":code_generator",
+ requirement("jinja2"),
+ requirement("markupsafe"),
":code_generator",
],
+ toolchains = [
+ "@rules_python//python:current_py_toolchain",
+ ],
)
@@ -4484,6 +4495,35 @@ filegroup(
@@ -4484,6 +4490,35 @@ filegroup(
],
)
@@ -304,7 +298,7 @@ index b432f86..28c567b 100644
filegroup(
name = "d8_files",
srcs = [
@@ -4603,16 +4643,9 @@ cc_library(
@@ -4603,16 +4638,9 @@ cc_library(
],
)
@@ -324,7 +318,7 @@ index b432f86..28c567b 100644
)
v8_library(
@@ -4629,7 +4662,7 @@ v8_library(
@@ -4629,7 +4657,7 @@ v8_library(
copts = ["-Wno-implicit-fallthrough"],
icu_deps = [
":icu/generated_torque_definitions_headers",
@@ -333,7 +327,7 @@ index b432f86..28c567b 100644
],
icu_srcs = [
":generated_regexp_special_case",
@@ -4644,7 +4677,7 @@ v8_library(
@@ -4644,7 +4672,7 @@ v8_library(
],
deps = [
":lib_dragonbox",
@@ -342,7 +336,7 @@ index b432f86..28c567b 100644
":lib_fp16",
":simdutf",
":v8_libbase",
@@ -4700,6 +4733,7 @@ alias(
@@ -4700,6 +4728,7 @@ alias(
alias(
name = "core_lib_icu",
actual = "icu/v8",
@@ -350,7 +344,7 @@ index b432f86..28c567b 100644
)
v8_library(
@@ -4751,7 +4785,7 @@ v8_binary(
@@ -4751,7 +4780,7 @@ v8_binary(
],
deps = [
":v8_libbase",
@@ -359,7 +353,7 @@ index b432f86..28c567b 100644
],
)
@@ -4791,9 +4825,20 @@ v8_binary(
@@ -4791,9 +4820,20 @@ v8_binary(
":icu/generated_torque_initializers",
":icu/v8_initializers_files",
],