openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-11-05 20:10:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tui): keep tab status working for background terminals

Browse Source
This commit is contained in:
Felipe Coury
2026-06-12 12:36:44 -07:00
parent 38ebee8ebe
commit b25542ba78
1 changed files with 51 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/tui/src/bottom_pane/mod.rs
+51 -1
View File
@@ -317,7 +317,7 @@ impl BottomPane {
fn desired_tab_status(&self) -> TabStatus {
if self.terminal_title_requires_action() {
TabStatus::Waiting
} else if self.is_task_running {
} else if self.is_task_running || !self.unified_exec_footer.is_empty() {
TabStatus::Working
} else {
TabStatus::Idle
@@ -1254,6 +1254,7 @@ impl BottomPane {
pub(crate) fn set_unified_exec_processes(&mut self, processes: Vec<String>) {
if self.unified_exec_footer.set_processes(processes) {
self.sync_status_inline_message();
self.refresh_tab_status();
self.request_redraw();
}
}
@@ -2031,6 +2032,55 @@ mod tests {
assert_eq!(pane.last_tab_status_for_test(), Some(TabStatus::Idle));
}
#[test]
fn tab_status_tracks_background_terminal_lifecycle() {
let features = Features::with_defaults();
let mut pane = fresh_pane();
let mut states = Vec::new();
pane.refresh_tab_status();
states.push(pane.last_tab_status_for_test());
pane.set_unified_exec_processes(vec!["sleep 30".to_string()]);
states.push(pane.last_tab_status_for_test());
pane.set_task_running(/*running*/ true);
pane.set_task_running(/*running*/ false);
states.push(pane.last_tab_status_for_test());
pane.push_approval_request(exec_request(), &features);
states.push(pane.last_tab_status_for_test());
let _ = pane.on_ctrl_c();
states.push(pane.last_tab_status_for_test());
pane.set_unified_exec_processes(Vec::new());
states.push(pane.last_tab_status_for_test());
assert_snapshot!(format!("{states:#?}"), @r###"
[
Some(
Idle,
),
Some(
Working,
),
Some(
Working,
),
Some(
Waiting,
),
Some(
Working,
),
Some(
Idle,
),
]
"###);
}
#[test]
fn tab_status_clears_via_on_active_view_complete_bypass() {
// Some completion paths bypass pop_active_view_with_completion