Merge 6fe18bbbff into sapling-pr-archive-bolinfest

This commit is contained in:
Michael Bolin
2026-04-25 13:26:58 -07:00
committed by GitHub
2 changed files with 17 additions and 0 deletions
@@ -9294,6 +9294,7 @@ fn merge_persisted_resume_metadata(
}
typesafe_overrides.model = persisted_metadata.model.clone();
typesafe_overrides.model_provider = Some(persisted_metadata.model_provider.clone());
if let Some(reasoning_effort) = persisted_metadata.reasoning_effort {
request_overrides.get_or_insert_with(HashMap::new).insert(
@@ -10991,6 +10992,10 @@ mod tests {
typesafe_overrides.model,
Some("gpt-5.1-codex-max".to_string())
);
assert_eq!(
typesafe_overrides.model_provider,
Some("mock_provider".to_string())
);
assert_eq!(
request_overrides,
Some(HashMap::from([(
@@ -11021,6 +11026,7 @@ mod tests {
);
assert_eq!(typesafe_overrides.model, Some("gpt-5.2-codex".to_string()));
assert_eq!(typesafe_overrides.model_provider, None);
assert_eq!(
request_overrides,
Some(HashMap::from([(
@@ -11049,6 +11055,7 @@ mod tests {
);
assert_eq!(typesafe_overrides.model, None);
assert_eq!(typesafe_overrides.model_provider, None);
assert_eq!(
request_overrides,
Some(HashMap::from([(
@@ -11100,6 +11107,7 @@ mod tests {
);
assert_eq!(typesafe_overrides.model, None);
assert_eq!(typesafe_overrides.model_provider, None);
assert_eq!(
request_overrides,
Some(HashMap::from([(
@@ -11124,6 +11132,10 @@ mod tests {
);
assert_eq!(typesafe_overrides.model, None);
assert_eq!(
typesafe_overrides.model_provider,
Some("mock_provider".to_string())
);
assert_eq!(request_overrides, None);
Ok(())
}
@@ -54,6 +54,8 @@ async fn thread_start_with_non_local_thread_store_does_not_create_local_persiste
let server = create_mock_responses_server_repeating_assistant("Done").await;
let codex_home = TempDir::new()?;
let store_id = Uuid::new_v4().to_string();
// Plugin startup warmups may create `.tmp` under codex_home. Disable them
// here so this regression stays focused on thread persistence artifacts.
create_config_toml_with_thread_store(codex_home.path(), &server.uri(), &store_id)?;
let loader_overrides = LoaderOverrides::without_managed_config_for_tests();
@@ -248,6 +250,9 @@ base_url = "{server_uri}/v1"
wire_api = "responses"
request_max_retries = 0
stream_max_retries = 0
[features]
plugins = false
"#
),
)