openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-09-14 11:57:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Size unified mention popups to visible results (#34771)

Browse Source 
## What changed

- Size the unified mention popup from its filtered row count, while keeping a one-row minimum and the existing maximum.
- Update composer snapshots to cover the compact layout when only one mention result is visible.

GitOrigin-RevId: 7cd30a5c53c7e81cf7158a6b3dda3c09bd024f29
This commit is contained in:
Eric Traut
2026-07-22 15:23:55 +00:00
committed by copyberry
parent 32f4687b8c
commit 9ee63da142
3 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
codex-rs/tui/src/bottom_pane/mentions_v2/popup.rs
View File

@@ -76,7 +76,8 @@ impl Popup {
}
pub(crate) fn calculate_required_height(&self, _width: u16) -> u16 {
(MAX_POPUP_ROWS as u16).saturating_add(2)
let visible = self.rows().len().clamp(1, MAX_POPUP_ROWS);
(visible as u16).saturating_add(2)
}
fn clamp_selection(&mut self) {

6
codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__chat_composer__tests__default_unified_mention_popup.snap
View File

@@ -5,9 +5,9 @@ expression: terminal.backend()
" "
"› @sa "
" "
" "
" "
" "
"> Sample Plugin Plugin with skills and an MCP server Plugin"
" "
" "
" "
" "
" enter insert · esc close · ←/→ switch search modes [All Results] Filesystem Only Plugins "

6
codex-rs/tui/src/bottom_pane/snapshots/codex_tui__bottom_pane__chat_composer__tests__unified_mention_popup_falls_back_from_bound_plugin_on_right.snap
View File

@@ -5,9 +5,9 @@ expression: terminal.backend()
" "
"› @left @bound "
" "
" "
" "
" "
"> left Plugin used to test bound mention fallback. Plugin"
" "
" "
" "
" "
" enter insert · esc close · ←/→ switch search modes [All Results] Filesystem Only Plugins "