openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-11-14 21:40:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(core): split MCP backend from session state

Browse Source
This commit is contained in:
Joe Gershenson
2026-03-19 23:37:06 -07:00
parent 461ba012fc
commit 945b674884
2 changed files with 899 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/core/src/mcp_connection_manager.rs
+883 -55
View File
File diff suppressed because it is too large Load Diff
codex-rs/core/src/mcp_connection_manager_tests.rs
+16 -4
View File
@@ -409,7 +409,10 @@ async fn list_all_tools_uses_startup_snapshot_while_client_is_pending() {
.shared();
let approval_policy = Constrained::allow_any(AskForApproval::OnFailure);
let mut manager = McpConnectionManager::new_uninitialized(&approval_policy);
manager.clients.insert(
Arc::get_mut(&mut manager.backend)
.expect("test manager backend should be uniquely owned")
.clients
.insert(
CODEX_APPS_MCP_SERVER_NAME.to_string(),
AsyncManagedClient {
client: pending_client,
@@ -434,7 +437,10 @@ async fn list_all_tools_blocks_while_client_is_pending_without_startup_snapshot(
.shared();
let approval_policy = Constrained::allow_any(AskForApproval::OnFailure);
let mut manager = McpConnectionManager::new_uninitialized(&approval_policy);
manager.clients.insert(
Arc::get_mut(&mut manager.backend)
.expect("test manager backend should be uniquely owned")
.clients
.insert(
CODEX_APPS_MCP_SERVER_NAME.to_string(),
AsyncManagedClient {
client: pending_client,
@@ -456,7 +462,10 @@ async fn list_all_tools_does_not_block_when_startup_snapshot_cache_hit_is_empty(
.shared();
let approval_policy = Constrained::allow_any(AskForApproval::OnFailure);
let mut manager = McpConnectionManager::new_uninitialized(&approval_policy);
manager.clients.insert(
Arc::get_mut(&mut manager.backend)
.expect("test manager backend should be uniquely owned")
.clients
.insert(
CODEX_APPS_MCP_SERVER_NAME.to_string(),
AsyncManagedClient {
client: pending_client,
@@ -488,7 +497,10 @@ async fn list_all_tools_uses_startup_snapshot_when_client_startup_fails() {
let approval_policy = Constrained::allow_any(AskForApproval::OnFailure);
let mut manager = McpConnectionManager::new_uninitialized(&approval_policy);
let startup_complete = Arc::new(std::sync::atomic::AtomicBool::new(true));
manager.clients.insert(
Arc::get_mut(&mut manager.backend)
.expect("test manager backend should be uniquely owned")
.clients
.insert(
CODEX_APPS_MCP_SERVER_NAME.to_string(),
AsyncManagedClient {
client: failed_client,