openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-11-14 21:40:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

codex: fix CI failure on PR #22493

Browse Source
This commit is contained in:
Abhinav Vedmala
2026-05-13 15:09:25 +00:00
parent bc4b0c27ff
commit 8001509fda
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/tui/src/history_cell/hook_cell.rs
+7 -7
View File
@@ -225,13 +225,12 @@ impl HookCell {
};
let presentation = hook_presentation(&run);
let HookPresentation::Render { entries } = presentation else {
if run.status == HookRunStatus::Completed {
if !self.runs[index]
if run.status == HookRunStatus::Completed
&& !self.runs[index]
.state
.complete_quiet_success(Instant::now())
{
self.runs.remove(index);
}
{
self.runs.remove(index);
}
return true;
};
@@ -689,7 +688,8 @@ pub(crate) fn new_completed_hook_cell(run: HookRunSummary, animations_enabled: b
/// Returns true when a hook marked as hidden has no user-relevant consequence to render.
pub(crate) fn hook_run_should_skip_render(run: &HookRunSummary) -> bool {
matches!(hook_presentation(run), HookPresentation::Skip)
run.visibility_hint == HookVisibilityHint::Hidden
&& matches!(hook_presentation(run), HookPresentation::Skip)
}
/// Chooses the transcript presentation for a hook run:
@@ -876,7 +876,7 @@ mod tests {
let mut run = hook_run_summary("hook-1");
run.status = HookRunStatus::Completed;
assert!(hook_run_should_skip_render(&run));
assert!(!hook_run_should_skip_render(&run));
assert_eq!(hook_presentation(&run), HookPresentation::Skip);
}