openai/codex
1
0
Fork 0
mirror of https://github.com/openai/codex.git synced 2026-10-20 17:38:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(imagegen): avoid duplicate markdown image links

Browse Source
This commit is contained in:
Kunyao Liu
2026-07-07 15:16:48 -07:00
parent f158b31db5
commit 7a7084857d
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
codex-rs/core/src/context/image_generation_instructions.rs
+1 -1
View File
@@ -18,7 +18,7 @@ fn image_generation_hint(
image_output_path: impl Display,
) -> String {
format!(
"Generated images are saved to {image_output_dir} as {image_output_path} by default.\nIf you need to use a generated image at another path, copy it and leave the original in place unless the user explicitly asks you to delete it."
"Generated images are saved to {image_output_dir} as {image_output_path} by default.\nThe generated image is already displayed to the user. Do not embed or link it, or an unchanged copy of it, in Markdown.\nIf you need to use the generated image at another path for further work, copy it and leave the original in place unless the user explicitly asks you to delete it."
)
}
codex-rs/ext/image-generation/src/tests.rs
+7 -2
View File
@@ -224,9 +224,12 @@ async fn recent_image_fallback_requires_requested_count() {
fn generated_output_returns_image_input_and_output_hint() {
let output_hint =
extension_image_generation_output_hint("/tmp", "/tmp/call-1.png").expect("hint should fit");
let expected_output_hint = "Generated images are saved to /tmp as /tmp/call-1.png by default.
The generated image is already displayed to the user. Do not embed or link it, or an unchanged copy of it, in Markdown.
If you need to use the generated image at another path for further work, copy it and leave the original in place unless the user explicitly asks you to delete it.";
let output = GeneratedImageOutput {
result: RESULT.to_string(),
output_hint: Some(output_hint.clone()),
output_hint: Some(output_hint),
};
let ResponseInputItem::FunctionCallOutput {
@@ -246,7 +249,9 @@ fn generated_output_returns_image_input_and_output_hint() {
image_url: format!("data:image/png;base64,{RESULT}"),
detail: Some(DEFAULT_IMAGE_DETAIL),
},
FunctionCallOutputContentItem::InputText { text: output_hint },
FunctionCallOutputContentItem::InputText {
text: expected_output_hint.to_string(),
},
]
);
}