codex: address PR review feedback (#28463)

This commit is contained in:
Adam Perry
2026-06-16 17:36:08 +00:00
parent 0b19ab190c
commit 785ca4476b

View File

@@ -31,15 +31,6 @@ pub struct WineTestCommand {
env: Vec<(OsString, OsString)>,
}
/// Owns a Wine process and its isolated wineserver.
///
/// Call [`Self::scope`] or [`Self::shutdown`] on every successful path. A
/// normal unguarded drop panics, while a drop during unwinding performs
/// blocking cleanup without introducing a second panic.
pub struct WineTestProcess {
processes: Option<WineProcesses>,
}
/// Captured output and exit status from a Wine test command.
#[derive(Debug, PartialEq, Eq)]
pub struct WineCommandOutput {
@@ -51,6 +42,15 @@ pub struct WineCommandOutput {
pub exit_code: i32,
}
/// Owns a Wine process and its isolated wineserver.
///
/// Call [`Self::scope`] or [`Self::shutdown`] on every successful path. A
/// normal unguarded drop panics, while a drop during unwinding performs
/// blocking cleanup without introducing a second panic.
pub struct WineTestProcess {
processes: Option<WineProcesses>,
}
struct WineProcesses {
child: Child,
cleanup_complete: bool,