mirror of
https://github.com/openai/codex.git
synced 2026-09-08 15:50:34 +00:00
codex: address PR review feedback (#28463)
This commit is contained in:
@@ -31,15 +31,6 @@ pub struct WineTestCommand {
|
||||
env: Vec<(OsString, OsString)>,
|
||||
}
|
||||
|
||||
/// Owns a Wine process and its isolated wineserver.
|
||||
///
|
||||
/// Call [`Self::scope`] or [`Self::shutdown`] on every successful path. A
|
||||
/// normal unguarded drop panics, while a drop during unwinding performs
|
||||
/// blocking cleanup without introducing a second panic.
|
||||
pub struct WineTestProcess {
|
||||
processes: Option<WineProcesses>,
|
||||
}
|
||||
|
||||
/// Captured output and exit status from a Wine test command.
|
||||
#[derive(Debug, PartialEq, Eq)]
|
||||
pub struct WineCommandOutput {
|
||||
@@ -51,6 +42,15 @@ pub struct WineCommandOutput {
|
||||
pub exit_code: i32,
|
||||
}
|
||||
|
||||
/// Owns a Wine process and its isolated wineserver.
|
||||
///
|
||||
/// Call [`Self::scope`] or [`Self::shutdown`] on every successful path. A
|
||||
/// normal unguarded drop panics, while a drop during unwinding performs
|
||||
/// blocking cleanup without introducing a second panic.
|
||||
pub struct WineTestProcess {
|
||||
processes: Option<WineProcesses>,
|
||||
}
|
||||
|
||||
struct WineProcesses {
|
||||
child: Child,
|
||||
cleanup_complete: bool,
|
||||
|
||||
Reference in New Issue
Block a user